Rewrite std::string("") to std::string(), Linux edition.

This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 12 insertions, 12 deletions

diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc
index 083343d..f86821c 100644
--- a/net/http/http_util_unittest.cc
+++ b/net/http/http_util_unittest.cc
@@ -966,12 +966,12 @@ TEST(HttpUtilTest, NameValuePairsIteratorCopyAndAssign) {
 }
 
 TEST(HttpUtilTest, NameValuePairsIteratorEmptyInput) {
-  std::string data = "";
+  std::string data;
   HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
 
   EXPECT_TRUE(parser.valid());
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }
 
 TEST(HttpUtilTest, NameValuePairsIterator) {
@@ -997,19 +997,19 @@ TEST(HttpUtilTest, NameValuePairsIterator) {
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "f", "'hello world'"));
   ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, true, true, "g", ""));
+      CheckNextNameValuePair(&parser, true, true, "g", std::string()));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "h", "hello"));
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }
 
 TEST(HttpUtilTest, NameValuePairsIteratorIllegalInputs) {
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", "; beta"));
-  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("", "beta"));
+  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair(std::string(), "beta"));
 
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", "; 'beta'=2"));
-  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("", "'beta'=2"));
+  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair(std::string(), "'beta'=2"));
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", ";beta="));
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1",
                                                     ";beta=;cappa=2"));
@@ -1033,8 +1033,8 @@ TEST(HttpUtilTest, NameValuePairsIteratorExtraSeparators) {
       CheckNextNameValuePair(&parser, true, true, "beta", "2"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "cappa", "3"));
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }
 
 // See comments on the implementation of NameValuePairsIterator::GetNext
@@ -1046,6 +1046,6 @@ TEST(HttpUtilTest, NameValuePairsIteratorMissingEndQuote) {
 
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "name", "value"));
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }