diff options
| author | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-02 17:13:04 +0000 |
|---|---|---|
| committer | rvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-02 17:13:04 +0000 |
| commit | f5648e992f39ea16b866fea20945cbd04d3f6c24 (patch) | |
| tree | fe9fd658a2d74dfc2297ca122f006b0c73ae11f9 /net/http | |
| parent | 5661a84a5c4e69afb3de758f45b699b2610c0b29 (diff) | |
| download | chromium_src-f5648e992f39ea16b866fea20945cbd04d3f6c24.zip chromium_src-f5648e992f39ea16b866fea20945cbd04d3f6c24.tar.gz chromium_src-f5648e992f39ea16b866fea20945cbd04d3f6c24.tar.bz2 | |
Http cache: Always revalidate PUT and DELETE requests.
BUG=136320
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10829114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149643 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http')
| -rw-r--r-- | net/http/http_cache_transaction.cc | 3 | ||||
| -rw-r--r-- | net/http/http_cache_unittest.cc | 8 |
2 files changed, 5 insertions, 6 deletions
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc index 7b84844..7dd8ecf 100644 --- a/net/http/http_cache_transaction.cc +++ b/net/http/http_cache_transaction.cc @@ -1770,6 +1770,9 @@ bool HttpCache::Transaction::RequiresValidation() { if (effective_load_flags_ & LOAD_VALIDATE_CACHE) return true; + if (request_->method == "PUT" || request_->method == "DELETE") + return true; + if (response_.headers->RequiresValidation( response_.request_time, response_.response_time, Time::Now())) return true; diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc index 589b565..b223f3e 100644 --- a/net/http/http_cache_unittest.cc +++ b/net/http/http_cache_unittest.cc @@ -2355,9 +2355,7 @@ TEST(HttpCache, SimplePUT_Miss) { TEST(HttpCache, SimplePUT_Invalidate) { MockHttpCache cache; - MockTransaction transaction(kSimplePOST_Transaction); - transaction.method = "GET"; - + MockTransaction transaction(kSimpleGET_Transaction); MockHttpRequest req1(transaction); // Attempt to populate the cache. @@ -2408,9 +2406,7 @@ TEST(HttpCache, SimpleDELETE_Miss) { TEST(HttpCache, SimpleDELETE_Invalidate) { MockHttpCache cache; - MockTransaction transaction(kSimplePOST_Transaction); - transaction.method = "GET"; - + MockTransaction transaction(kSimpleGET_Transaction); MockHttpRequest req1(transaction); // Attempt to populate the cache. |