RefCounted types should not have public destructors, net/

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10066045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 17 insertions, 2 deletions

diff --git a/net/http/http_pipelined_connection_impl.cc b/net/http/http_pipelined_connection_impl.cc
index 8e87a89..fe55598 100644
--- a/net/http/http_pipelined_connection_impl.cc
+++ b/net/http/http_pipelined_connection_impl.cc
@@ -38,6 +38,9 @@ class ReceivedHeadersParameters : public NetLog::EventParameters {
     return dict;
   }
 
+ protected:
+  virtual ~ReceivedHeadersParameters() {}
+
  private:
   const NetLog::Source source_;
   const std::string feedback_;
@@ -55,6 +58,9 @@ class StreamClosedParameters : public NetLog::EventParameters {
     return dict;
   }
 
+ protected:
+  virtual ~StreamClosedParameters() {}
+
  private:
   const NetLog::Source source_;
   const bool not_reusable_;
diff --git a/net/http/http_pipelined_connection_impl_unittest.cc b/net/http/http_pipelined_connection_impl_unittest.cc
index 64b97cc..819b47a 100644
--- a/net/http/http_pipelined_connection_impl_unittest.cc
+++ b/net/http/http_pipelined_connection_impl_unittest.cc
@@ -27,6 +27,7 @@ namespace net {
 class DummySocketParams : public base::RefCounted<DummySocketParams> {
  private:
   friend class base::RefCounted<DummySocketParams>;
+  ~DummySocketParams() {}
 };
 
 REGISTER_SOCKET_PARAMS_FOR_POOL(MockTransportClientSocketPool,
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index bc4af30..b236b5e 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -51,10 +51,14 @@ class HttpStreamJobParameters : public NetLog::EventParameters {
 
   virtual Value* ToValue() const;
 
+ protected:
+  virtual ~HttpStreamJobParameters() {}
+
  private:
   HttpStreamJobParameters(const GURL& original_url, const GURL& url)
       : original_url_(original_url.GetOrigin().spec()),
-        url_(url.GetOrigin().spec()) {}
+        url_(url.GetOrigin().spec()) {
+  }
 
   const std::string original_url_;
   const std::string url_;
@@ -80,13 +84,17 @@ class HttpStreamProtoParameters : public NetLog::EventParameters {
 
   virtual Value* ToValue() const;
 
+ protected:
+  virtual ~HttpStreamProtoParameters() {}
+
  private:
   HttpStreamProtoParameters(const SSLClientSocket::NextProtoStatus status,
                             const std::string& proto,
                             const std::string& server_protos)
       : status_(status),
         proto_(proto),
-        server_protos_(server_protos) {}
+        server_protos_(server_protos) {
+  }
 
   const SSLClientSocket::NextProtoStatus status_;
   const std::string proto_;