diff options
author | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-31 03:58:46 +0000 |
---|---|---|
committer | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-31 03:58:46 +0000 |
commit | 8e3c78cb4857505329f602e6af71a46d05346e99 (patch) | |
tree | 0f42439dbfdea47be8189bc39d682062d071d3ec /net/http | |
parent | 9822df966d60c67faaf4c4adacc70801aed9edaf (diff) | |
download | chromium_src-8e3c78cb4857505329f602e6af71a46d05346e99.zip chromium_src-8e3c78cb4857505329f602e6af71a46d05346e99.tar.gz chromium_src-8e3c78cb4857505329f602e6af71a46d05346e99.tar.bz2 |
Move NextProto enum to a new file net/socket/next_proto.h
BUG=120890
Review URL: http://codereview.chromium.org/9959033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130038 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http')
36 files changed, 131 insertions, 132 deletions
diff --git a/net/http/http_network_layer.cc b/net/http/http_network_layer.cc index 6afadea..9bb5c92 100644 --- a/net/http/http_network_layer.cc +++ b/net/http/http_network_layer.cc @@ -65,11 +65,11 @@ void HttpNetworkLayer::EnableSpdy(const std::string& mode) { if (option == kOff) { HttpStreamFactory::set_spdy_enabled(false); } else if (option == kDisableSSL) { - SpdySession::set_default_protocol(SSLClientSocket::kProtoSPDY2); + SpdySession::set_default_protocol(kProtoSPDY2); HttpStreamFactory::set_force_spdy_over_ssl(false); HttpStreamFactory::set_force_spdy_always(true); } else if (option == kSSL) { - SpdySession::set_default_protocol(SSLClientSocket::kProtoSPDY2); + SpdySession::set_default_protocol(kProtoSPDY2); HttpStreamFactory::set_force_spdy_over_ssl(true); HttpStreamFactory::set_force_spdy_always(true); } else if (option == kDisablePing) { diff --git a/net/http/http_network_transaction_spdy21_unittest.cc b/net/http/http_network_transaction_spdy21_unittest.cc index 9da8f91..7744e7f 100644 --- a/net/http/http_network_transaction_spdy21_unittest.cc +++ b/net/http/http_network_transaction_spdy21_unittest.cc @@ -174,7 +174,7 @@ class HttpNetworkTransactionSpdy21Test : public PlatformTest { }; virtual void SetUp() { - SpdySession::set_default_protocol(SSLClientSocket::kProtoSPDY21); + SpdySession::set_default_protocol(kProtoSPDY21); NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); MessageLoop::current()->RunAllPending(); } @@ -2170,7 +2170,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, HttpsProxySpdyGet) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); TestCompletionCallback callback1; @@ -2254,7 +2254,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, HttpsProxySpdyGetWithProxyAuth) { session_deps.socket_factory.AddSocketDataProvider(data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); TestCompletionCallback callback1; @@ -2349,11 +2349,11 @@ TEST_F(HttpNetworkTransactionSpdy21Test, HttpsProxySpdyConnectHttps) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); ssl2.was_npn_negotiated = false; - ssl2.protocol_negotiated = SSLClientSocket::kProtoUnknown; + ssl2.protocol_negotiated = kProtoUnknown; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -2428,11 +2428,11 @@ TEST_F(HttpNetworkTransactionSpdy21Test, HttpsProxySpdyConnectSpdy) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); - ssl2.SetNextProto(SSLClientSocket::kProtoSPDY21); - ssl2.protocol_negotiated = SSLClientSocket::kProtoSPDY21; + ssl2.SetNextProto(kProtoSPDY21); + ssl2.protocol_negotiated = kProtoSPDY21; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -2492,10 +2492,10 @@ TEST_F(HttpNetworkTransactionSpdy21Test, HttpsProxySpdyConnectFailure) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); - ssl2.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl2.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -4597,7 +4597,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, RedirectOfHttpsConnectViaSpdyProxy) { data_reads, arraysize(data_reads), data_writes, arraysize(data_writes))); SSLSocketDataProvider proxy_ssl(ASYNC, OK); // SSL to the proxy - proxy_ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + proxy_ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSocketDataProvider(data.get()); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy_ssl); @@ -4716,7 +4716,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, data_reads, arraysize(data_reads), data_writes, arraysize(data_writes))); SSLSocketDataProvider proxy_ssl(ASYNC, OK); // SSL to the proxy - proxy_ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + proxy_ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSocketDataProvider(data.get()); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy_ssl); @@ -4826,7 +4826,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, BasicAuthSpdyProxy) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); // Negotiate SPDY to the proxy SSLSocketDataProvider proxy(ASYNC, OK); - proxy.SetNextProto(SSLClientSocket::kProtoSPDY21); + proxy.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy); // Vanilla SSL to the server SSLSocketDataProvider server(ASYNC, OK); @@ -6904,7 +6904,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7003,7 +7003,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, AlternateProtocolWithSpdyLateBinding) { session_deps.socket_factory.AddSocketDataProvider(&hanging_socket); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req1(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7109,7 +7109,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, StallAlternateProtocolForNpnSpdy) { session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); @@ -7242,7 +7242,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7346,7 +7346,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -8181,7 +8181,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, NpnWithHttpOverSSL) { SSLSocketDataProvider ssl(ASYNC, OK); ssl.next_proto_status = SSLClientSocket::kNextProtoNegotiated; ssl.next_proto = "http/1.1"; - ssl.protocol_negotiated = SSLClientSocket::kProtoHTTP11; + ssl.protocol_negotiated = kProtoHTTP11; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); @@ -8229,7 +8229,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, SpdyPostNPNServerHangup) { request.load_flags = 0; SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -8360,7 +8360,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, SpdyAlternateProtocolThroughProxy) { data_writes_2, arraysize(data_writes_2))); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); StaticSocketDataProvider hanging_non_alternate_protocol_socket( @@ -8641,7 +8641,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, PreconnectWithExistingSpdySession) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps)); @@ -9078,7 +9078,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, UseIPConnectionPooling) { pool_peer.DisableDomainAuthenticationVerification(); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> host1_req(ConstructSpdyGet( @@ -9229,7 +9229,7 @@ TEST_F(HttpNetworkTransactionSpdy21Test, pool_peer.DisableDomainAuthenticationVerification(); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl.SetNextProto(kProtoSPDY21); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> host1_req(ConstructSpdyGet( diff --git a/net/http/http_network_transaction_spdy2_unittest.cc b/net/http/http_network_transaction_spdy2_unittest.cc index 9ba424b..1eb3cec 100644 --- a/net/http/http_network_transaction_spdy2_unittest.cc +++ b/net/http/http_network_transaction_spdy2_unittest.cc @@ -174,7 +174,7 @@ class HttpNetworkTransactionSpdy2Test : public PlatformTest { }; virtual void SetUp() { - SpdySession::set_default_protocol(SSLClientSocket::kProtoSPDY2); + SpdySession::set_default_protocol(kProtoSPDY2); NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); MessageLoop::current()->RunAllPending(); } @@ -2170,7 +2170,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, HttpsProxySpdyGet) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); TestCompletionCallback callback1; @@ -2254,7 +2254,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, HttpsProxySpdyGetWithProxyAuth) { session_deps.socket_factory.AddSocketDataProvider(data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); TestCompletionCallback callback1; @@ -2349,11 +2349,11 @@ TEST_F(HttpNetworkTransactionSpdy2Test, HttpsProxySpdyConnectHttps) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); ssl2.was_npn_negotiated = false; - ssl2.protocol_negotiated = SSLClientSocket::kProtoUnknown; + ssl2.protocol_negotiated = kProtoUnknown; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -2428,11 +2428,11 @@ TEST_F(HttpNetworkTransactionSpdy2Test, HttpsProxySpdyConnectSpdy) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); - ssl2.SetNextProto(SSLClientSocket::kProtoSPDY2); - ssl2.protocol_negotiated = SSLClientSocket::kProtoSPDY2; + ssl2.SetNextProto(kProtoSPDY2); + ssl2.protocol_negotiated = kProtoSPDY2; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -2492,10 +2492,10 @@ TEST_F(HttpNetworkTransactionSpdy2Test, HttpsProxySpdyConnectFailure) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); - ssl2.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl2.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -4597,7 +4597,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, RedirectOfHttpsConnectViaSpdyProxy) { data_reads, arraysize(data_reads), data_writes, arraysize(data_writes))); SSLSocketDataProvider proxy_ssl(ASYNC, OK); // SSL to the proxy - proxy_ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + proxy_ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSocketDataProvider(data.get()); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy_ssl); @@ -4716,7 +4716,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, data_reads, arraysize(data_reads), data_writes, arraysize(data_writes))); SSLSocketDataProvider proxy_ssl(ASYNC, OK); // SSL to the proxy - proxy_ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + proxy_ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSocketDataProvider(data.get()); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy_ssl); @@ -4826,7 +4826,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, BasicAuthSpdyProxy) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); // Negotiate SPDY to the proxy SSLSocketDataProvider proxy(ASYNC, OK); - proxy.SetNextProto(SSLClientSocket::kProtoSPDY2); + proxy.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy); // Vanilla SSL to the server SSLSocketDataProvider server(ASYNC, OK); @@ -6903,7 +6903,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UseAlternateProtocolForNpnSpdy) { session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7002,7 +7002,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, AlternateProtocolWithSpdyLateBinding) { session_deps.socket_factory.AddSocketDataProvider(&hanging_socket); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req1(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7108,7 +7108,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, StallAlternateProtocolForNpnSpdy) { session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); @@ -7241,7 +7241,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7345,7 +7345,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -8180,7 +8180,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, NpnWithHttpOverSSL) { SSLSocketDataProvider ssl(ASYNC, OK); ssl.next_proto_status = SSLClientSocket::kNextProtoNegotiated; ssl.next_proto = "http/1.1"; - ssl.protocol_negotiated = SSLClientSocket::kProtoHTTP11; + ssl.protocol_negotiated = kProtoHTTP11; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); @@ -8228,7 +8228,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, SpdyPostNPNServerHangup) { request.load_flags = 0; SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -8359,7 +8359,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, SpdyAlternateProtocolThroughProxy) { data_writes_2, arraysize(data_writes_2))); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); StaticSocketDataProvider hanging_non_alternate_protocol_socket( @@ -8640,7 +8640,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, PreconnectWithExistingSpdySession) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps)); @@ -9077,7 +9077,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UseIPConnectionPooling) { pool_peer.DisableDomainAuthenticationVerification(); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> host1_req(ConstructSpdyGet( @@ -9228,7 +9228,7 @@ TEST_F(HttpNetworkTransactionSpdy2Test, pool_peer.DisableDomainAuthenticationVerification(); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl.SetNextProto(kProtoSPDY2); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> host1_req(ConstructSpdyGet( diff --git a/net/http/http_network_transaction_spdy3_unittest.cc b/net/http/http_network_transaction_spdy3_unittest.cc index 16aea62..587722d 100644 --- a/net/http/http_network_transaction_spdy3_unittest.cc +++ b/net/http/http_network_transaction_spdy3_unittest.cc @@ -175,7 +175,7 @@ class HttpNetworkTransactionSpdy3Test : public PlatformTest { }; virtual void SetUp() { - SpdySession::set_default_protocol(SSLClientSocket::kProtoSPDY3); + SpdySession::set_default_protocol(kProtoSPDY3); NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); MessageLoop::current()->RunAllPending(); } @@ -2171,7 +2171,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, HttpsProxySpdyGet) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); TestCompletionCallback callback1; @@ -2255,7 +2255,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, HttpsProxySpdyGetWithProxyAuth) { session_deps.socket_factory.AddSocketDataProvider(data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); TestCompletionCallback callback1; @@ -2350,11 +2350,11 @@ TEST_F(HttpNetworkTransactionSpdy3Test, HttpsProxySpdyConnectHttps) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); ssl2.was_npn_negotiated = false; - ssl2.protocol_negotiated = SSLClientSocket::kProtoUnknown; + ssl2.protocol_negotiated = kProtoUnknown; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -2429,11 +2429,11 @@ TEST_F(HttpNetworkTransactionSpdy3Test, HttpsProxySpdyConnectSpdy) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); - ssl2.SetNextProto(SSLClientSocket::kProtoSPDY3); - ssl2.protocol_negotiated = SSLClientSocket::kProtoSPDY3; + ssl2.SetNextProto(kProtoSPDY3); + ssl2.protocol_negotiated = kProtoSPDY3; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -2493,10 +2493,10 @@ TEST_F(HttpNetworkTransactionSpdy3Test, HttpsProxySpdyConnectFailure) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); SSLSocketDataProvider ssl2(ASYNC, OK); - ssl2.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl2.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl2); TestCompletionCallback callback1; @@ -4598,7 +4598,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, RedirectOfHttpsConnectViaSpdyProxy) { data_reads, arraysize(data_reads), data_writes, arraysize(data_writes))); SSLSocketDataProvider proxy_ssl(ASYNC, OK); // SSL to the proxy - proxy_ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + proxy_ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSocketDataProvider(data.get()); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy_ssl); @@ -4717,7 +4717,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, data_reads, arraysize(data_reads), data_writes, arraysize(data_writes))); SSLSocketDataProvider proxy_ssl(ASYNC, OK); // SSL to the proxy - proxy_ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + proxy_ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSocketDataProvider(data.get()); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy_ssl); @@ -4827,7 +4827,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, BasicAuthSpdyProxy) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); // Negotiate SPDY to the proxy SSLSocketDataProvider proxy(ASYNC, OK); - proxy.SetNextProto(SSLClientSocket::kProtoSPDY3); + proxy.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&proxy); // Vanilla SSL to the server SSLSocketDataProvider server(ASYNC, OK); @@ -6903,7 +6903,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, UseAlternateProtocolForNpnSpdy) { session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7002,7 +7002,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, AlternateProtocolWithSpdyLateBinding) { session_deps.socket_factory.AddSocketDataProvider(&hanging_socket); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req1(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7108,7 +7108,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, StallAlternateProtocolForNpnSpdy) { session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); @@ -7241,7 +7241,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -7345,7 +7345,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, session_deps.socket_factory.AddSocketDataProvider(&first_transaction); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -8180,7 +8180,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, NpnWithHttpOverSSL) { SSLSocketDataProvider ssl(ASYNC, OK); ssl.next_proto_status = SSLClientSocket::kNextProtoNegotiated; ssl.next_proto = "http/1.1"; - ssl.protocol_negotiated = SSLClientSocket::kProtoHTTP11; + ssl.protocol_negotiated = kProtoHTTP11; session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); @@ -8228,7 +8228,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, SpdyPostNPNServerHangup) { request.load_flags = 0; SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> req(ConstructSpdyGet(NULL, 0, false, 1, LOWEST)); @@ -8359,7 +8359,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, SpdyAlternateProtocolThroughProxy) { data_writes_2, arraysize(data_writes_2))); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); StaticSocketDataProvider hanging_non_alternate_protocol_socket( @@ -8640,7 +8640,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, PreconnectWithExistingSpdySession) { session_deps.socket_factory.AddSocketDataProvider(spdy_data.get()); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps)); @@ -9076,7 +9076,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, UseIPConnectionPooling) { pool_peer.DisableDomainAuthenticationVerification(); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> host1_req(ConstructSpdyGet( @@ -9227,7 +9227,7 @@ TEST_F(HttpNetworkTransactionSpdy3Test, pool_peer.DisableDomainAuthenticationVerification(); SSLSocketDataProvider ssl(ASYNC, OK); - ssl.SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl.SetNextProto(kProtoSPDY3); session_deps.socket_factory.AddSSLSocketDataProvider(&ssl); scoped_ptr<SpdyFrame> host1_req(ConstructSpdyGet( diff --git a/net/http/http_pipelined_connection.h b/net/http/http_pipelined_connection.h index 020acc6..67b1e83 100644 --- a/net/http/http_pipelined_connection.h +++ b/net/http/http_pipelined_connection.h @@ -54,7 +54,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnection { const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) = 0; + NextProto protocol_negotiated) = 0; }; virtual ~HttpPipelinedConnection() {} @@ -86,7 +86,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnection { virtual bool was_npn_negotiated() const = 0; // Protocol negotiated with the server. - virtual SSLClientSocket::NextProto protocol_negotiated() const = 0; + virtual NextProto protocol_negotiated() const = 0; }; } // namespace net diff --git a/net/http/http_pipelined_connection_impl.cc b/net/http/http_pipelined_connection_impl.cc index 4f6fc51..e4e5032 100644 --- a/net/http/http_pipelined_connection_impl.cc +++ b/net/http/http_pipelined_connection_impl.cc @@ -70,7 +70,7 @@ HttpPipelinedConnectionImpl::HttpPipelinedConnectionImpl( const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) + NextProto protocol_negotiated) : delegate_(delegate), connection_(connection), used_ssl_config_(used_ssl_config), @@ -811,7 +811,7 @@ bool HttpPipelinedConnectionImpl::was_npn_negotiated() const { return was_npn_negotiated_; } -SSLClientSocket::NextProto HttpPipelinedConnectionImpl::protocol_negotiated() +NextProto HttpPipelinedConnectionImpl::protocol_negotiated() const { return protocol_negotiated_; } diff --git a/net/http/http_pipelined_connection_impl.h b/net/http/http_pipelined_connection_impl.h index 3f9e269..a20361d 100644 --- a/net/http/http_pipelined_connection_impl.h +++ b/net/http/http_pipelined_connection_impl.h @@ -56,7 +56,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnectionImpl const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) OVERRIDE { + NextProto protocol_negotiated) OVERRIDE { return new HttpPipelinedConnectionImpl(connection, delegate, origin, used_ssl_config, used_proxy_info, net_log, was_npn_negotiated, @@ -71,7 +71,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnectionImpl const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated); + NextProto protocol_negotiated); virtual ~HttpPipelinedConnectionImpl(); // HttpPipelinedConnection interface. @@ -89,7 +89,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnectionImpl virtual const ProxyInfo& used_proxy_info() const OVERRIDE; virtual const BoundNetLog& net_log() const OVERRIDE; virtual bool was_npn_negotiated() const OVERRIDE; - virtual SSLClientSocket::NextProto protocol_negotiated() const OVERRIDE; + virtual NextProto protocol_negotiated() const OVERRIDE; // Used by HttpPipelinedStream. @@ -307,7 +307,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnectionImpl BoundNetLog net_log_; bool was_npn_negotiated_; // Protocol negotiated with the server. - SSLClientSocket::NextProto protocol_negotiated_; + NextProto protocol_negotiated_; scoped_refptr<GrowableIOBuffer> read_buf_; int next_pipeline_id_; bool active_; diff --git a/net/http/http_pipelined_connection_impl_unittest.cc b/net/http/http_pipelined_connection_impl_unittest.cc index 0aaa253..64b97cc 100644 --- a/net/http/http_pipelined_connection_impl_unittest.cc +++ b/net/http/http_pipelined_connection_impl_unittest.cc @@ -92,7 +92,7 @@ class HttpPipelinedConnectionImplTest : public testing::Test { BoundNetLog()); pipeline_.reset(new HttpPipelinedConnectionImpl( connection, &delegate_, origin_, ssl_config_, proxy_info_, - BoundNetLog(), false, SSLClientSocket::kProtoUnknown)); + BoundNetLog(), false, kProtoUnknown)); } HttpRequestInfo* GetRequestInfo(const std::string& filename) { diff --git a/net/http/http_pipelined_host.h b/net/http/http_pipelined_host.h index 24b6e3a..03c685a 100644 --- a/net/http/http_pipelined_host.h +++ b/net/http/http_pipelined_host.h @@ -80,7 +80,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedHost { const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) = 0; + NextProto protocol_negotiated) = 0; // Tries to find an existing pipeline with capacity for a new request. If // successful, returns a new stream on that pipeline. Otherwise, returns NULL. diff --git a/net/http/http_pipelined_host_forced.cc b/net/http/http_pipelined_host_forced.cc index 7f0c91a..000936c 100644 --- a/net/http/http_pipelined_host_forced.cc +++ b/net/http/http_pipelined_host_forced.cc @@ -38,7 +38,7 @@ HttpPipelinedStream* HttpPipelinedHostForced::CreateStreamOnNewPipeline( const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) { + NextProto protocol_negotiated) { CHECK(!pipeline_.get()); StreamSocket* wrapped_socket = connection->release_socket(); BufferedWriteStreamSocket* buffered_socket = new BufferedWriteStreamSocket( diff --git a/net/http/http_pipelined_host_forced.h b/net/http/http_pipelined_host_forced.h index fb222f5..9dc2727 100644 --- a/net/http/http_pipelined_host_forced.h +++ b/net/http/http_pipelined_host_forced.h @@ -47,7 +47,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedHostForced const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) OVERRIDE; + NextProto protocol_negotiated) OVERRIDE; virtual HttpPipelinedStream* CreateStreamOnExistingPipeline() OVERRIDE; diff --git a/net/http/http_pipelined_host_forced_unittest.cc b/net/http/http_pipelined_host_forced_unittest.cc index de91b1b..2d3e4ba 100644 --- a/net/http/http_pipelined_host_forced_unittest.cc +++ b/net/http/http_pipelined_host_forced_unittest.cc @@ -37,7 +37,7 @@ class HttpPipelinedHostForcedTest : public testing::Test { MatchesOrigin(key_.origin()), Ref(ssl_config_), Ref(proxy_info_), Ref(net_log_), true, - SSLClientSocket::kProtoSPDY21)) + kProtoSPDY21)) .Times(1) .WillOnce(Return(pipeline)); EXPECT_CALL(*pipeline, CreateNewStream()) @@ -45,7 +45,7 @@ class HttpPipelinedHostForcedTest : public testing::Test { .WillOnce(Return(kDummyStream)); EXPECT_EQ(kDummyStream, host_->CreateStreamOnNewPipeline( &connection_, ssl_config_, proxy_info_, net_log_, true, - SSLClientSocket::kProtoSPDY21)); + kProtoSPDY21)); return pipeline; } diff --git a/net/http/http_pipelined_host_impl.cc b/net/http/http_pipelined_host_impl.cc index 5aa561f..2c8238a 100644 --- a/net/http/http_pipelined_host_impl.cc +++ b/net/http/http_pipelined_host_impl.cc @@ -43,7 +43,7 @@ HttpPipelinedStream* HttpPipelinedHostImpl::CreateStreamOnNewPipeline( const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) { + NextProto protocol_negotiated) { if (capability_ == PIPELINE_INCAPABLE) { return NULL; } diff --git a/net/http/http_pipelined_host_impl.h b/net/http/http_pipelined_host_impl.h index 55e929e..7a5b664 100644 --- a/net/http/http_pipelined_host_impl.h +++ b/net/http/http_pipelined_host_impl.h @@ -49,7 +49,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedHostImpl const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) OVERRIDE; + NextProto protocol_negotiated) OVERRIDE; virtual HttpPipelinedStream* CreateStreamOnExistingPipeline() OVERRIDE; diff --git a/net/http/http_pipelined_host_impl_unittest.cc b/net/http/http_pipelined_host_impl_unittest.cc index 4559278..6fc3a6a 100644 --- a/net/http/http_pipelined_host_impl_unittest.cc +++ b/net/http/http_pipelined_host_impl_unittest.cc @@ -48,7 +48,7 @@ class HttpPipelinedHostImplTest : public testing::Test { MatchesOrigin(key_.origin()), Ref(ssl_config_), Ref(proxy_info_), Ref(net_log_), true, - SSLClientSocket::kProtoSPDY21)) + kProtoSPDY21)) .Times(1) .WillOnce(Return(pipeline)); EXPECT_CALL(*pipeline, CreateNewStream()) @@ -56,7 +56,7 @@ class HttpPipelinedHostImplTest : public testing::Test { .WillOnce(Return(kDummyStream)); EXPECT_EQ(kDummyStream, host_->CreateStreamOnNewPipeline( kDummyConnection, ssl_config_, proxy_info_, net_log_, true, - SSLClientSocket::kProtoSPDY21)); + kProtoSPDY21)); return pipeline; } @@ -208,7 +208,7 @@ TEST_F(HttpPipelinedHostImplTest, ShutsDownOnOldVersion) { ClearTestPipeline(pipeline); EXPECT_EQ(NULL, host_->CreateStreamOnNewPipeline( kDummyConnection, ssl_config_, proxy_info_, net_log_, true, - SSLClientSocket::kProtoSPDY21)); + kProtoSPDY21)); } TEST_F(HttpPipelinedHostImplTest, ShutsDownOnAuthenticationRequired) { @@ -227,7 +227,7 @@ TEST_F(HttpPipelinedHostImplTest, ShutsDownOnAuthenticationRequired) { ClearTestPipeline(pipeline); EXPECT_EQ(NULL, host_->CreateStreamOnNewPipeline( kDummyConnection, ssl_config_, proxy_info_, net_log_, true, - SSLClientSocket::kProtoSPDY2)); + kProtoSPDY2)); } TEST_F(HttpPipelinedHostImplTest, ConnectionCloseHasNoEffect) { diff --git a/net/http/http_pipelined_host_pool.cc b/net/http/http_pipelined_host_pool.cc index 5adb8a4..7b00e7e 100644 --- a/net/http/http_pipelined_host_pool.cc +++ b/net/http/http_pipelined_host_pool.cc @@ -65,7 +65,7 @@ HttpPipelinedStream* HttpPipelinedHostPool::CreateStreamOnNewPipeline( const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated) { + NextProto protocol_negotiated) { HttpPipelinedHost* host = GetPipelinedHost(key, true); if (!host) { return NULL; diff --git a/net/http/http_pipelined_host_pool.h b/net/http/http_pipelined_host_pool.h index 1d0bbc6..9f0681d 100644 --- a/net/http/http_pipelined_host_pool.h +++ b/net/http/http_pipelined_host_pool.h @@ -57,7 +57,7 @@ class NET_EXPORT_PRIVATE HttpPipelinedHostPool const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated); + NextProto protocol_negotiated); // Tries to find an existing pipeline with capacity for a new request. If // successful, returns a new stream on that pipeline. Otherwise, returns NULL. diff --git a/net/http/http_pipelined_host_pool_unittest.cc b/net/http/http_pipelined_host_pool_unittest.cc index 11db1e9..3064f23 100644 --- a/net/http/http_pipelined_host_pool_unittest.cc +++ b/net/http/http_pipelined_host_pool_unittest.cc @@ -56,7 +56,7 @@ class MockHost : public HttpPipelinedHost { const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated)); + NextProto protocol_negotiated)); MOCK_METHOD0(CreateStreamOnExistingPipeline, HttpPipelinedStream*()); MOCK_CONST_METHOD0(IsExistingPipelineAvailable, bool()); MOCK_CONST_METHOD0(PipelineInfoToValue, base::Value*()); @@ -77,7 +77,7 @@ class HttpPipelinedHostPoolTest : public testing::Test { pool_(new HttpPipelinedHostPool(&delegate_, factory_, http_server_properties_.get(), false)), was_npn_negotiated_(false), - protocol_negotiated_(SSLClientSocket::kProtoUnknown) { + protocol_negotiated_(kProtoUnknown) { } void CreateDummyStream(const HttpPipelinedHost::Key& key, @@ -124,7 +124,7 @@ class HttpPipelinedHostPoolTest : public testing::Test { const ProxyInfo proxy_info_; const BoundNetLog net_log_; bool was_npn_negotiated_; - SSLClientSocket::NextProto protocol_negotiated_; + NextProto protocol_negotiated_; }; TEST_F(HttpPipelinedHostPoolTest, DefaultUnknown) { diff --git a/net/http/http_pipelined_host_test_util.h b/net/http/http_pipelined_host_test_util.h index eeb7b34..245ff02 100644 --- a/net/http/http_pipelined_host_test_util.h +++ b/net/http/http_pipelined_host_test_util.h @@ -33,7 +33,7 @@ class MockPipelineFactory : public HttpPipelinedConnection::Factory { const ProxyInfo& used_proxy_info, const BoundNetLog& net_log, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated)); + NextProto protocol_negotiated)); }; class MockPipeline : public HttpPipelinedConnection { @@ -57,7 +57,7 @@ class MockPipeline : public HttpPipelinedConnection { MOCK_CONST_METHOD0(used_proxy_info, const ProxyInfo&()); MOCK_CONST_METHOD0(net_log, const BoundNetLog&()); MOCK_CONST_METHOD0(was_npn_negotiated, bool()); - MOCK_CONST_METHOD0(protocol_negotiated, SSLClientSocket::NextProto()); + MOCK_CONST_METHOD0(protocol_negotiated, NextProto()); private: int depth_; diff --git a/net/http/http_pipelined_stream.cc b/net/http/http_pipelined_stream.cc index ba14981..2756c02 100644 --- a/net/http/http_pipelined_stream.cc +++ b/net/http/http_pipelined_stream.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -138,7 +138,7 @@ bool HttpPipelinedStream::was_npn_negotiated() const { return pipeline_->was_npn_negotiated(); } -SSLClientSocket::NextProto HttpPipelinedStream::protocol_negotiated() const { +NextProto HttpPipelinedStream::protocol_negotiated() const { return pipeline_->protocol_negotiated(); } diff --git a/net/http/http_pipelined_stream.h b/net/http/http_pipelined_stream.h index 6930c08..76897ac 100644 --- a/net/http/http_pipelined_stream.h +++ b/net/http/http_pipelined_stream.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -98,7 +98,7 @@ class HttpPipelinedStream : public HttpStream { bool was_npn_negotiated() const; // Protocol negotiated with the server. - SSLClientSocket::NextProto protocol_negotiated() const; + NextProto protocol_negotiated() const; private: HttpPipelinedConnectionImpl* pipeline_; diff --git a/net/http/http_proxy_client_socket.cc b/net/http/http_proxy_client_socket.cc index 1a2bac5..47aaa7b 100644 --- a/net/http/http_proxy_client_socket.cc +++ b/net/http/http_proxy_client_socket.cc @@ -34,7 +34,7 @@ HttpProxyClientSocket::HttpProxyClientSocket( HttpAuthHandlerFactory* http_auth_handler_factory, bool tunnel, bool using_spdy, - SSLClientSocket::NextProto protocol_negotiated, + NextProto protocol_negotiated, bool is_https_proxy) : ALLOW_THIS_IN_INITIALIZER_LIST(io_callback_( base::Bind(&HttpProxyClientSocket::OnIOComplete, @@ -92,8 +92,7 @@ bool HttpProxyClientSocket::IsUsingSpdy() const { return using_spdy_; } -SSLClientSocket::NextProto -HttpProxyClientSocket::GetProtocolNegotiated() const { +NextProto HttpProxyClientSocket::GetProtocolNegotiated() const { return protocol_negotiated_; } diff --git a/net/http/http_proxy_client_socket.h b/net/http/http_proxy_client_socket.h index db6f7e0..e0c9980 100644 --- a/net/http/http_proxy_client_socket.h +++ b/net/http/http_proxy_client_socket.h @@ -46,7 +46,7 @@ class HttpProxyClientSocket : public ProxyClientSocket { HttpAuthHandlerFactory* http_auth_handler_factory, bool tunnel, bool using_spdy, - SSLClientSocket::NextProto protocol_negotiated, + NextProto protocol_negotiated, bool is_https_proxy); // On destruction Disconnect() is called. @@ -59,7 +59,7 @@ class HttpProxyClientSocket : public ProxyClientSocket { virtual const scoped_refptr<HttpAuthController>& GetAuthController() const OVERRIDE; virtual bool IsUsingSpdy() const OVERRIDE; - virtual SSLClientSocket::NextProto GetProtocolNegotiated() const OVERRIDE; + virtual NextProto GetProtocolNegotiated() const OVERRIDE; // StreamSocket implementation. virtual int Connect(const CompletionCallback& callback) OVERRIDE; @@ -151,7 +151,7 @@ class HttpProxyClientSocket : public ProxyClientSocket { // If true, then the connection to the proxy is a SPDY connection. const bool using_spdy_; // Protocol negotiated with the server. - SSLClientSocket::NextProto protocol_negotiated_; + NextProto protocol_negotiated_; // If true, then SSL is used to communicate with this proxy const bool is_https_proxy_; diff --git a/net/http/http_proxy_client_socket_pool.cc b/net/http/http_proxy_client_socket_pool.cc index ebea776..01dc023 100644 --- a/net/http/http_proxy_client_socket_pool.cc +++ b/net/http/http_proxy_client_socket_pool.cc @@ -89,7 +89,7 @@ HttpProxyConnectJob::HttpProxyConnectJob( callback_(base::Bind(&HttpProxyConnectJob::OnIOComplete, base::Unretained(this)))), using_spdy_(false), - protocol_negotiated_(SSLClientSocket::kProtoUnknown) { + protocol_negotiated_(kProtoUnknown) { } HttpProxyConnectJob::~HttpProxyConnectJob() {} diff --git a/net/http/http_proxy_client_socket_pool.h b/net/http/http_proxy_client_socket_pool.h index 483520b..1b0afb4 100644 --- a/net/http/http_proxy_client_socket_pool.h +++ b/net/http/http_proxy_client_socket_pool.h @@ -161,7 +161,7 @@ class HttpProxyConnectJob : public ConnectJob { scoped_ptr<ProxyClientSocket> transport_socket_; bool using_spdy_; // Protocol negotiated with the server. - SSLClientSocket::NextProto protocol_negotiated_; + NextProto protocol_negotiated_; HttpResponseInfo error_response_info_; diff --git a/net/http/http_proxy_client_socket_pool_spdy21_unittest.cc b/net/http/http_proxy_client_socket_pool_spdy21_unittest.cc index 59bee4f..761cd78 100644 --- a/net/http/http_proxy_client_socket_pool_spdy21_unittest.cc +++ b/net/http/http_proxy_client_socket_pool_spdy21_unittest.cc @@ -175,7 +175,7 @@ class HttpProxyClientSocketPoolSpdy21Test : public TestWithHttpParam { } void InitializeSpdySsl() { - ssl_data_->SetNextProto(SSLClientSocket::kProtoSPDY21); + ssl_data_->SetNextProto(kProtoSPDY21); } HttpNetworkSession* CreateNetworkSession() { diff --git a/net/http/http_proxy_client_socket_pool_spdy2_unittest.cc b/net/http/http_proxy_client_socket_pool_spdy2_unittest.cc index 43da413..5647d33 100644 --- a/net/http/http_proxy_client_socket_pool_spdy2_unittest.cc +++ b/net/http/http_proxy_client_socket_pool_spdy2_unittest.cc @@ -175,7 +175,7 @@ class HttpProxyClientSocketPoolSpdy2Test : public TestWithHttpParam { } void InitializeSpdySsl() { - ssl_data_->SetNextProto(SSLClientSocket::kProtoSPDY2); + ssl_data_->SetNextProto(kProtoSPDY2); } HttpNetworkSession* CreateNetworkSession() { diff --git a/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc b/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc index 6aed8e4..d6c288e 100644 --- a/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc +++ b/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc @@ -176,7 +176,7 @@ class HttpProxyClientSocketPoolSpdy3Test : public TestWithHttpParam { } void InitializeSpdySsl() { - ssl_data_->SetNextProto(SSLClientSocket::kProtoSPDY3); + ssl_data_->SetNextProto(kProtoSPDY3); } HttpNetworkSession* CreateNetworkSession() { diff --git a/net/http/http_stream_factory.h b/net/http/http_stream_factory.h index ce32b14..f767844 100644 --- a/net/http/http_stream_factory.h +++ b/net/http/http_stream_factory.h @@ -147,7 +147,7 @@ class NET_EXPORT_PRIVATE HttpStreamRequest { virtual bool was_npn_negotiated() const = 0; // Protocol negotiated with the server. - virtual SSLClientSocket::NextProto protocol_negotiated() const = 0; + virtual NextProto protocol_negotiated() const = 0; // Returns true if this stream is being fetched over SPDY. virtual bool using_spdy() const = 0; diff --git a/net/http/http_stream_factory_impl.cc b/net/http/http_stream_factory_impl.cc index 7c44c0d..c142224 100644 --- a/net/http/http_stream_factory_impl.cc +++ b/net/http/http_stream_factory_impl.cc @@ -195,7 +195,7 @@ void HttpStreamFactoryImpl::OnSpdySessionReady( const SSLConfig& used_ssl_config, const ProxyInfo& used_proxy_info, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated, + NextProto protocol_negotiated, bool using_spdy, const BoundNetLog& net_log) { const HostPortProxyPair& spdy_session_key = diff --git a/net/http/http_stream_factory_impl.h b/net/http/http_stream_factory_impl.h index 103e2c6..238b435 100644 --- a/net/http/http_stream_factory_impl.h +++ b/net/http/http_stream_factory_impl.h @@ -74,7 +74,7 @@ class NET_EXPORT_PRIVATE HttpStreamFactoryImpl : const SSLConfig& used_ssl_config, const ProxyInfo& used_proxy_info, bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated, + NextProto protocol_negotiated, bool using_spdy, const BoundNetLog& net_log); diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc index e75b376..f3ebf4a 100644 --- a/net/http/http_stream_factory_impl_job.cc +++ b/net/http/http_stream_factory_impl_job.cc @@ -131,7 +131,7 @@ HttpStreamFactoryImpl::Job::Job(HttpStreamFactoryImpl* stream_factory, spdy_certificate_error_(OK), establishing_tunnel_(false), was_npn_negotiated_(false), - protocol_negotiated_(SSLClientSocket::kProtoUnknown), + protocol_negotiated_(kProtoUnknown), num_streams_(0), spdy_session_direct_(false), existing_available_pipeline_(false), @@ -247,7 +247,7 @@ bool HttpStreamFactoryImpl::Job::was_npn_negotiated() const { return was_npn_negotiated_; } -SSLClientSocket::NextProto HttpStreamFactoryImpl::Job::protocol_negotiated() +NextProto HttpStreamFactoryImpl::Job::protocol_negotiated() const { return protocol_negotiated_; } @@ -791,7 +791,7 @@ int HttpStreamFactoryImpl::Job::DoInitConnectionComplete(int result) { std::string server_protos; SSLClientSocket::NextProtoStatus status = ssl_socket->GetNextProto(&proto, &server_protos); - SSLClientSocket::NextProto protocol_negotiated = + NextProto protocol_negotiated = SSLClientSocket::NextProtoFromString(proto); protocol_negotiated_ = protocol_negotiated; net_log_.AddEvent( diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h index 8e167da..f03aab8 100644 --- a/net/http/http_stream_factory_impl_job.h +++ b/net/http/http_stream_factory_impl_job.h @@ -67,7 +67,7 @@ class HttpStreamFactoryImpl::Job { void Orphan(const Request* request); bool was_npn_negotiated() const; - SSLClientSocket::NextProto protocol_negotiated() const; + NextProto protocol_negotiated() const; bool using_spdy() const; const BoundNetLog& net_log() const { return net_log_; } @@ -266,7 +266,7 @@ class HttpStreamFactoryImpl::Job { bool was_npn_negotiated_; // Protocol negotiated with the server. - SSLClientSocket::NextProto protocol_negotiated_; + NextProto protocol_negotiated_; // 0 if we're not preconnecting. Otherwise, the number of streams to // preconnect. diff --git a/net/http/http_stream_factory_impl_request.cc b/net/http/http_stream_factory_impl_request.cc index 9a5e28a..2ac3354 100644 --- a/net/http/http_stream_factory_impl_request.cc +++ b/net/http/http_stream_factory_impl_request.cc @@ -22,7 +22,7 @@ HttpStreamFactoryImpl::Request::Request(const GURL& url, net_log_(net_log), completed_(false), was_npn_negotiated_(false), - protocol_negotiated_(SSLClientSocket::kProtoUnknown), + protocol_negotiated_(kProtoUnknown), using_spdy_(false) { DCHECK(factory_); DCHECK(delegate_); @@ -77,7 +77,7 @@ void HttpStreamFactoryImpl::Request::AttachJob(Job* job) { void HttpStreamFactoryImpl::Request::Complete( bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated, + NextProto protocol_negotiated, bool using_spdy, const BoundNetLog& job_net_log) { DCHECK(!completed_); @@ -233,7 +233,7 @@ bool HttpStreamFactoryImpl::Request::was_npn_negotiated() const { return was_npn_negotiated_; } -SSLClientSocket::NextProto HttpStreamFactoryImpl::Request::protocol_negotiated() +NextProto HttpStreamFactoryImpl::Request::protocol_negotiated() const { DCHECK(completed_); return protocol_negotiated_; @@ -300,7 +300,7 @@ void HttpStreamFactoryImpl::Request::OnSpdySessionReady( const SSLConfig used_ssl_config = job->server_ssl_config(); const ProxyInfo used_proxy_info = job->proxy_info(); const bool was_npn_negotiated = job->was_npn_negotiated(); - const SSLClientSocket::NextProto protocol_negotiated = + const NextProto protocol_negotiated = job->protocol_negotiated(); const bool using_spdy = job->using_spdy(); const BoundNetLog net_log = job->net_log(); diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h index ea05420..ab5ff96 100644 --- a/net/http/http_stream_factory_impl_request.h +++ b/net/http/http_stream_factory_impl_request.h @@ -44,7 +44,7 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest { // Marks completion of the request. Must be called before OnStreamReady(). // |job_net_log| is the BoundNetLog of the Job that fulfilled this request. void Complete(bool was_npn_negotiated, - SSLClientSocket::NextProto protocol_negotiated, + NextProto protocol_negotiated, bool using_spdy, const BoundNetLog& job_net_log); @@ -94,7 +94,7 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest { const AuthCredentials& credentials) OVERRIDE; virtual LoadState GetLoadState() const OVERRIDE; virtual bool was_npn_negotiated() const OVERRIDE; - virtual SSLClientSocket::NextProto protocol_negotiated() const OVERRIDE; + virtual NextProto protocol_negotiated() const OVERRIDE; virtual bool using_spdy() const OVERRIDE; private: @@ -119,7 +119,7 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest { bool completed_; bool was_npn_negotiated_; // Protocol negotiated with the server. - SSLClientSocket::NextProto protocol_negotiated_; + NextProto protocol_negotiated_; bool using_spdy_; DISALLOW_COPY_AND_ASSIGN(Request); diff --git a/net/http/proxy_client_socket.h b/net/http/proxy_client_socket.h index 476e478..7a17a01 100644 --- a/net/http/proxy_client_socket.h +++ b/net/http/proxy_client_socket.h @@ -50,7 +50,7 @@ class NET_EXPORT_PRIVATE ProxyClientSocket : public StreamSocket { virtual bool IsUsingSpdy() const = 0; // Returns the protocol negotiated with the proxy. - virtual SSLClientSocket::NextProto GetProtocolNegotiated() const = 0; + virtual NextProto GetProtocolNegotiated() const = 0; protected: // The HTTP CONNECT method for establishing a tunnel connection is documented |