diff options
author | ricea@chromium.org <ricea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-25 04:16:24 +0000 |
---|---|---|
committer | ricea@chromium.org <ricea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-25 04:16:24 +0000 |
commit | ca14da58979adab3c8e59459609a3175e77c47cb (patch) | |
tree | 6e005a6564176e36c183a56d782615bb06da74b0 /net/http | |
parent | 55bcca954d218ea9f7c3cd6bb5b431b01a612dbf (diff) | |
download | chromium_src-ca14da58979adab3c8e59459609a3175e77c47cb.zip chromium_src-ca14da58979adab3c8e59459609a3175e77c47cb.tar.gz chromium_src-ca14da58979adab3c8e59459609a3175e77c47cb.tar.bz2 |
Remove unused HttpStreamParser parameter
HttpBasicStream had an unused HttpStreamParser parameter. It is unchanged since
2010, so it is unlikely that a user will appear. Remove it.
BUG=311024
TEST=net_unittests, layout tests
Review URL: https://codereview.chromium.org/39833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230948 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http')
-rw-r--r-- | net/http/http_basic_stream.cc | 7 | ||||
-rw-r--r-- | net/http/http_basic_stream.h | 7 | ||||
-rw-r--r-- | net/http/http_stream_factory_impl_job.cc | 3 |
3 files changed, 5 insertions, 12 deletions
diff --git a/net/http/http_basic_stream.cc b/net/http/http_basic_stream.cc index c30e17d..d7501d5 100644 --- a/net/http/http_basic_stream.cc +++ b/net/http/http_basic_stream.cc @@ -17,14 +17,11 @@ namespace net { HttpBasicStream::HttpBasicStream(ClientSocketHandle* connection, - HttpStreamParser* parser, bool using_proxy) : read_buf_(new GrowableIOBuffer()), - parser_(parser), connection_(connection), using_proxy_(using_proxy), - request_info_(NULL) { -} + request_info_(NULL) {} HttpBasicStream::~HttpBasicStream() {} @@ -80,7 +77,7 @@ HttpStream* HttpBasicStream::RenewStreamForAuth() { DCHECK(IsResponseBodyComplete()); DCHECK(!parser_->IsMoreDataBuffered()); parser_.reset(); - return new HttpBasicStream(connection_.release(), NULL, using_proxy_); + return new HttpBasicStream(connection_.release(), using_proxy_); } bool HttpBasicStream::IsResponseBodyComplete() const { diff --git a/net/http/http_basic_stream.h b/net/http/http_basic_stream.h index 2057837e..93d120c 100644 --- a/net/http/http_basic_stream.h +++ b/net/http/http_basic_stream.h @@ -27,12 +27,9 @@ class IOBuffer; class HttpBasicStream : public HttpStream { public: - // Constructs a new HttpBasicStream. If |parser| is NULL, then - // InitializeStream should be called to initialize it correctly. If - // |parser| is non-null, then InitializeStream should not be called, - // as the stream is already initialized. + // Constructs a new HttpBasicStream. InitializeStream must be called to + // initialize it correctly. HttpBasicStream(ClientSocketHandle* connection, - HttpStreamParser* parser, bool using_proxy); virtual ~HttpBasicStream(); diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc index 9528200..cd04339 100644 --- a/net/http/http_stream_factory_impl_job.cc +++ b/net/http/http_stream_factory_impl_job.cc @@ -1082,8 +1082,7 @@ int HttpStreamFactoryImpl::Job::DoCreateStream() { protocol_negotiated_)); CHECK(stream_.get()); } else { - stream_.reset(new HttpBasicStream(connection_.release(), NULL, - using_proxy)); + stream_.reset(new HttpBasicStream(connection_.release(), using_proxy)); } return OK; } |