diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-05 09:24:56 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-05 09:24:56 +0000 |
commit | 0672752c1c1e433b2d1bc4e4f487f528aec25f5c (patch) | |
tree | 456076af3b7794f085aa9f444b1808f115116307 /net/http | |
parent | f9644ccd38835611b68adfaab7071366a3aaf208 (diff) | |
download | chromium_src-0672752c1c1e433b2d1bc4e4f487f528aec25f5c.zip chromium_src-0672752c1c1e433b2d1bc4e4f487f528aec25f5c.tar.gz chromium_src-0672752c1c1e433b2d1bc4e4f487f528aec25f5c.tar.bz2 |
GTTF: Add missing virtual destructors.
R=jar
TBR=darin,satorux,fischman,jamesr,sky
BUG=45135
Review URL: https://codereview.chromium.org/12086018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http')
-rw-r--r-- | net/http/http_pipelined_connection.h | 2 | ||||
-rw-r--r-- | net/http/http_pipelined_host.h | 2 | ||||
-rw-r--r-- | net/http/http_pipelined_host_forced.h | 2 | ||||
-rw-r--r-- | net/http/http_pipelined_host_impl.h | 2 | ||||
-rw-r--r-- | net/http/http_pipelined_host_pool.h | 4 | ||||
-rw-r--r-- | net/http/http_stream_factory_impl.h | 2 |
6 files changed, 10 insertions, 4 deletions
diff --git a/net/http/http_pipelined_connection.h b/net/http/http_pipelined_connection.h index d0d3599..2f856b0 100644 --- a/net/http/http_pipelined_connection.h +++ b/net/http/http_pipelined_connection.h @@ -30,6 +30,8 @@ class NET_EXPORT_PRIVATE HttpPipelinedConnection { class Delegate { public: + virtual ~Delegate() {} + // Called when a pipeline has newly available capacity. This may be because // the first request has been sent and the pipeline is now active. Or, it // may be because a request successfully completed. diff --git a/net/http/http_pipelined_host.h b/net/http/http_pipelined_host.h index b7732e6..bb5ce4d 100644 --- a/net/http/http_pipelined_host.h +++ b/net/http/http_pipelined_host.h @@ -43,6 +43,8 @@ class NET_EXPORT_PRIVATE HttpPipelinedHost { class Delegate { public: + virtual ~Delegate() {} + // Called when a pipelined host has no outstanding requests on any of its // pipelined connections. virtual void OnHostIdle(HttpPipelinedHost* host) = 0; diff --git a/net/http/http_pipelined_host_forced.h b/net/http/http_pipelined_host_forced.h index 2c3c915..94a27f0 100644 --- a/net/http/http_pipelined_host_forced.h +++ b/net/http/http_pipelined_host_forced.h @@ -32,7 +32,7 @@ struct SSLConfig; // test the user's connection for pipelining compatibility. class NET_EXPORT_PRIVATE HttpPipelinedHostForced : public HttpPipelinedHost, - public HttpPipelinedConnection::Delegate { + public NON_EXPORTED_BASE(HttpPipelinedConnection::Delegate) { public: HttpPipelinedHostForced(HttpPipelinedHost::Delegate* delegate, const Key& key, diff --git a/net/http/http_pipelined_host_impl.h b/net/http/http_pipelined_host_impl.h index e2e53c9..9b7a1c7 100644 --- a/net/http/http_pipelined_host_impl.h +++ b/net/http/http_pipelined_host_impl.h @@ -33,7 +33,7 @@ struct SSLConfig; // assigns requests to the least loaded pipelined connection. class NET_EXPORT_PRIVATE HttpPipelinedHostImpl : public HttpPipelinedHost, - public HttpPipelinedConnection::Delegate { + public NON_EXPORTED_BASE(HttpPipelinedConnection::Delegate) { public: HttpPipelinedHostImpl(HttpPipelinedHost::Delegate* delegate, const HttpPipelinedHost::Key& key, diff --git a/net/http/http_pipelined_host_pool.h b/net/http/http_pipelined_host_pool.h index 3ab9418..d729325 100644 --- a/net/http/http_pipelined_host_pool.h +++ b/net/http/http_pipelined_host_pool.h @@ -27,10 +27,12 @@ class HttpServerProperties; // HTTP requests. Manages connection jobs, constructs pipelined streams, and // assigns requests to the least loaded pipelined connection. class NET_EXPORT_PRIVATE HttpPipelinedHostPool - : public HttpPipelinedHost::Delegate { + : public NON_EXPORTED_BASE(HttpPipelinedHost::Delegate) { public: class Delegate { public: + virtual ~Delegate() {} + // Called when a HttpPipelinedHost has new capacity. Attempts to allocate // any pending pipeline-capable requests to pipelines. virtual void OnHttpPipelinedHostHasAdditionalCapacity( diff --git a/net/http/http_stream_factory_impl.h b/net/http/http_stream_factory_impl.h index 213d96a..5918981 100644 --- a/net/http/http_stream_factory_impl.h +++ b/net/http/http_stream_factory_impl.h @@ -25,7 +25,7 @@ class SpdySession; class NET_EXPORT_PRIVATE HttpStreamFactoryImpl : public HttpStreamFactory, - public HttpPipelinedHostPool::Delegate { + public NON_EXPORTED_BASE(HttpPipelinedHostPool::Delegate) { public: explicit HttpStreamFactoryImpl(HttpNetworkSession* session); virtual ~HttpStreamFactoryImpl(); |