summaryrefslogtreecommitdiffstats
path: root/net/http
diff options
context:
space:
mode:
authorwtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-05 00:43:32 +0000
committerwtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-05 00:43:32 +0000
commitea9dc9a73e96c97a586c97af2e7a54b851bb1245 (patch)
tree8bcddd03baf76607dc69413bdcb8be127e9db2e9 /net/http
parent3f9a579bfea1c987e9685a9ee59abf03660223af (diff)
downloadchromium_src-ea9dc9a73e96c97a586c97af2e7a54b851bb1245.zip
chromium_src-ea9dc9a73e96c97a586c97af2e7a54b851bb1245.tar.gz
chromium_src-ea9dc9a73e96c97a586c97af2e7a54b851bb1245.tar.bz2
[Second attempt of r25461]
Use SSPI for NTLM authentication on Windows. Add an explicit embedded_identity_used_ boolean member to make sure we use the username/password in the URL only once for the transaction. This allows us to reset auth_identity_[target].source to HttpAuth::IDENT_SRC_NONE after auth failed. Initial patch by Arindam. Original review URL: http://codereview.chromium.org/159656 R=arindam,eroman BUG=19,18009,20560 TEST=1. Open a webpage that requests NTLM authentication on Windows. 2. New unit test for wrong auth identity in URL. Review URL: http://codereview.chromium.org/193022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25564 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http')
-rw-r--r--net/http/http_auth_handler.h5
-rw-r--r--net/http/http_auth_handler_ntlm.cc690
-rw-r--r--net/http/http_auth_handler_ntlm.h41
-rw-r--r--net/http/http_auth_handler_ntlm_portable.cc707
-rw-r--r--net/http/http_auth_handler_ntlm_win.cc188
-rw-r--r--net/http/http_network_transaction.cc35
-rw-r--r--net/http/http_network_transaction.h5
-rw-r--r--net/http/http_network_transaction_unittest.cc124
8 files changed, 1092 insertions, 703 deletions
diff --git a/net/http/http_auth_handler.h b/net/http/http_auth_handler.h
index 3b32e18..5ad96d2 100644
--- a/net/http/http_auth_handler.h
+++ b/net/http/http_auth_handler.h
@@ -68,6 +68,11 @@ class HttpAuthHandler : public base::RefCounted<HttpAuthHandler> {
// sequence used by a connection-based authentication scheme.
virtual bool NeedsIdentity() { return true; }
+ // Returns true if this is the final round of the authentication sequence.
+ // For Basic and Digest, the method always returns true because they are
+ // single-round schemes.
+ virtual bool IsFinalRound() { return true; }
+
// Generate the Authorization header value.
virtual std::string GenerateCredentials(const std::wstring& username,
const std::wstring& password,
diff --git a/net/http/http_auth_handler_ntlm.cc b/net/http/http_auth_handler_ntlm.cc
index f7cadf8..99488ba 100644
--- a/net/http/http_auth_handler_ntlm.cc
+++ b/net/http/http_auth_handler_ntlm.cc
@@ -4,656 +4,12 @@
#include "net/http/http_auth_handler_ntlm.h"
-#include <stdlib.h>
-// For gethostname
-#if defined(OS_POSIX)
-#include <unistd.h>
-#elif defined(OS_WIN)
-#include <winsock2.h>
-#endif
-
-#include "base/md5.h"
-#include "base/rand_util.h"
#include "base/string_util.h"
-#include "base/sys_string_conversions.h"
#include "net/base/base64.h"
#include "net/base/net_errors.h"
-#include "net/base/net_util.h"
-#include "net/http/des.h"
-#include "net/http/md4.h"
namespace net {
-// Based on mozilla/security/manager/ssl/src/nsNTLMAuthModule.cpp,
-// CVS rev. 1.14.
-//
-// TODO(wtc):
-// - The IS_BIG_ENDIAN code is not tested.
-// - Enable the logging code or just delete it.
-// - Delete or comment out the LM code, which hasn't been tested and isn't
-// being used.
-
-/* ***** BEGIN LICENSE BLOCK *****
- * Version: MPL 1.1/GPL 2.0/LGPL 2.1
- *
- * The contents of this file are subject to the Mozilla Public License Version
- * 1.1 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- * http://www.mozilla.org/MPL/
- *
- * Software distributed under the License is distributed on an "AS IS" basis,
- * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
- * for the specific language governing rights and limitations under the
- * License.
- *
- * The Original Code is Mozilla.
- *
- * The Initial Developer of the Original Code is IBM Corporation.
- * Portions created by IBM Corporation are Copyright (C) 2003
- * IBM Corporation. All Rights Reserved.
- *
- * Contributor(s):
- * Darin Fisher <darin@meer.net>
- *
- * Alternatively, the contents of this file may be used under the terms of
- * either the GNU General Public License Version 2 or later (the "GPL"), or
- * the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
- * in which case the provisions of the GPL or the LGPL are applicable instead
- * of those above. If you wish to allow use of your version of this file only
- * under the terms of either the GPL or the LGPL, and not to allow others to
- * use your version of this file under the terms of the MPL, indicate your
- * decision by deleting the provisions above and replace them with the notice
- * and other provisions required by the GPL or the LGPL. If you do not delete
- * the provisions above, a recipient may use your version of this file under
- * the terms of any one of the MPL, the GPL or the LGPL.
- *
- * ***** END LICENSE BLOCK ***** */
-
-// Discover the endianness by testing processor architecture.
-#if defined(ARCH_CPU_X86) || defined(ARCH_CPU_X86_64) || defined(ARCH_CPU_ARMEL)
-#define IS_LITTLE_ENDIAN 1
-#undef IS_BIG_ENDIAN
-#else
-#error "Unknown endianness"
-#endif
-
-#define NTLM_LOG(x) ((void) 0)
-
-//-----------------------------------------------------------------------------
-// This file contains a cross-platform NTLM authentication implementation. It
-// is based on documentation from: http://davenport.sourceforge.net/ntlm.html
-//-----------------------------------------------------------------------------
-
-enum {
- NTLM_NegotiateUnicode = 0x00000001,
- NTLM_NegotiateOEM = 0x00000002,
- NTLM_RequestTarget = 0x00000004,
- NTLM_Unknown1 = 0x00000008,
- NTLM_NegotiateSign = 0x00000010,
- NTLM_NegotiateSeal = 0x00000020,
- NTLM_NegotiateDatagramStyle = 0x00000040,
- NTLM_NegotiateLanManagerKey = 0x00000080,
- NTLM_NegotiateNetware = 0x00000100,
- NTLM_NegotiateNTLMKey = 0x00000200,
- NTLM_Unknown2 = 0x00000400,
- NTLM_Unknown3 = 0x00000800,
- NTLM_NegotiateDomainSupplied = 0x00001000,
- NTLM_NegotiateWorkstationSupplied = 0x00002000,
- NTLM_NegotiateLocalCall = 0x00004000,
- NTLM_NegotiateAlwaysSign = 0x00008000,
- NTLM_TargetTypeDomain = 0x00010000,
- NTLM_TargetTypeServer = 0x00020000,
- NTLM_TargetTypeShare = 0x00040000,
- NTLM_NegotiateNTLM2Key = 0x00080000,
- NTLM_RequestInitResponse = 0x00100000,
- NTLM_RequestAcceptResponse = 0x00200000,
- NTLM_RequestNonNTSessionKey = 0x00400000,
- NTLM_NegotiateTargetInfo = 0x00800000,
- NTLM_Unknown4 = 0x01000000,
- NTLM_Unknown5 = 0x02000000,
- NTLM_Unknown6 = 0x04000000,
- NTLM_Unknown7 = 0x08000000,
- NTLM_Unknown8 = 0x10000000,
- NTLM_Negotiate128 = 0x20000000,
- NTLM_NegotiateKeyExchange = 0x40000000,
- NTLM_Negotiate56 = 0x80000000
-};
-
-// We send these flags with our type 1 message.
-enum {
- NTLM_TYPE1_FLAGS =
- NTLM_NegotiateUnicode |
- NTLM_NegotiateOEM |
- NTLM_RequestTarget |
- NTLM_NegotiateNTLMKey |
- NTLM_NegotiateAlwaysSign |
- NTLM_NegotiateNTLM2Key
-};
-
-static const char NTLM_SIGNATURE[] = "NTLMSSP";
-static const char NTLM_TYPE1_MARKER[] = { 0x01, 0x00, 0x00, 0x00 };
-static const char NTLM_TYPE2_MARKER[] = { 0x02, 0x00, 0x00, 0x00 };
-static const char NTLM_TYPE3_MARKER[] = { 0x03, 0x00, 0x00, 0x00 };
-
-enum {
- NTLM_TYPE1_HEADER_LEN = 32,
- NTLM_TYPE2_HEADER_LEN = 32,
- NTLM_TYPE3_HEADER_LEN = 64,
-
- LM_HASH_LEN = 16,
- LM_RESP_LEN = 24,
-
- NTLM_HASH_LEN = 16,
- NTLM_RESP_LEN = 24
-};
-
-//-----------------------------------------------------------------------------
-
-// The return value of this function controls whether or not the LM hash will
-// be included in response to a NTLM challenge.
-//
-// In Mozilla, this function returns the value of the boolean preference
-// "network.ntlm.send-lm-response". By default, the preference is disabled
-// since servers should almost never need the LM hash, and the LM hash is what
-// makes NTLM authentication less secure. See
-// https://bugzilla.mozilla.org/show_bug.cgi?id=250691 for further details.
-//
-// We just return a hardcoded false.
-static bool SendLM() {
- return false;
-}
-
-//-----------------------------------------------------------------------------
-
-#define LogFlags(x) ((void) 0)
-#define LogBuf(a, b, c) ((void) 0)
-#define LogToken(a, b, c) ((void) 0)
-
-//-----------------------------------------------------------------------------
-
-// Byte order swapping.
-#define SWAP16(x) ((((x) & 0xff) << 8) | (((x) >> 8) & 0xff))
-#define SWAP32(x) ((SWAP16((x) & 0xffff) << 16) | (SWAP16((x) >> 16)))
-
-static void* WriteBytes(void* buf, const void* data, uint32 data_len) {
- memcpy(buf, data, data_len);
- return static_cast<char*>(buf) + data_len;
-}
-
-static void* WriteDWORD(void* buf, uint32 dword) {
-#ifdef IS_BIG_ENDIAN
- // NTLM uses little endian on the wire.
- dword = SWAP32(dword);
-#endif
- return WriteBytes(buf, &dword, sizeof(dword));
-}
-
-static void* WriteSecBuf(void* buf, uint16 length, uint32 offset) {
-#ifdef IS_BIG_ENDIAN
- length = SWAP16(length);
- offset = SWAP32(offset);
-#endif
- buf = WriteBytes(buf, &length, sizeof(length));
- buf = WriteBytes(buf, &length, sizeof(length));
- buf = WriteBytes(buf, &offset, sizeof(offset));
- return buf;
-}
-
-#ifdef IS_BIG_ENDIAN
-/**
- * WriteUnicodeLE copies a unicode string from one buffer to another. The
- * resulting unicode string is in little-endian format. The input string is
- * assumed to be in the native endianness of the local machine. It is safe
- * to pass the same buffer as both input and output, which is a handy way to
- * convert the unicode buffer to little-endian on big-endian platforms.
- */
-static void* WriteUnicodeLE(void* buf, const char16* str, uint32 str_len) {
- // Convert input string from BE to LE.
- uint8* cursor = static_cast<uint8*>(buf);
- const uint8* input = reinterpret_cast<const uint8*>(str);
- for (uint32 i = 0; i < str_len; ++i, input += 2, cursor += 2) {
- // Allow for the case where |buf == str|.
- uint8 temp = input[0];
- cursor[0] = input[1];
- cursor[1] = temp;
- }
- return buf;
-}
-#endif
-
-static uint16 ReadUint16(const uint8*& buf) {
- uint16 x = (static_cast<uint16>(buf[0])) |
- (static_cast<uint16>(buf[1]) << 8);
- buf += sizeof(x);
- return x;
-}
-
-static uint32 ReadUint32(const uint8*& buf) {
- uint32 x = (static_cast<uint32>(buf[0])) |
- (static_cast<uint32>(buf[1]) << 8) |
- (static_cast<uint32>(buf[2]) << 16) |
- (static_cast<uint32>(buf[3]) << 24);
- buf += sizeof(x);
- return x;
-}
-
-//-----------------------------------------------------------------------------
-
-static void ZapBuf(void* buf, size_t buf_len) {
- memset(buf, 0, buf_len);
-}
-
-// TODO(wtc): Can we implement ZapString as
-// s.replace(0, s.size(), s.size(), '\0)?
-static void ZapString(std::string* s) {
- ZapBuf(&(*s)[0], s->length());
-}
-
-static void ZapString(string16* s) {
- ZapBuf(&(*s)[0], s->length() * 2);
-}
-
-// LM_Hash computes the LM hash of the given password.
-//
-// param password
-// unicode password.
-// param hash
-// 16-byte result buffer
-//
-// Note: This function is not being used because our SendLM() function always
-// returns false.
-static void LM_Hash(const string16& password, uint8* hash) {
- static const uint8 LM_MAGIC[] = "KGS!@#$%";
-
- // Convert password to OEM character set. We'll just use the native
- // filesystem charset.
- std::string passbuf = base::SysWideToNativeMB(UTF16ToWide(password));
- StringToUpperASCII(&passbuf);
- passbuf.resize(14, '\0');
-
- uint8 k1[8], k2[8];
- DESMakeKey(reinterpret_cast<const uint8*>(passbuf.data()) , k1);
- DESMakeKey(reinterpret_cast<const uint8*>(passbuf.data()) + 7, k2);
- ZapString(&passbuf);
-
- // Use password keys to hash LM magic string twice.
- DESEncrypt(k1, LM_MAGIC, hash);
- DESEncrypt(k2, LM_MAGIC, hash + 8);
-}
-
-// NTLM_Hash computes the NTLM hash of the given password.
-//
-// param password
-// null-terminated unicode password.
-// param hash
-// 16-byte result buffer
-static void NTLM_Hash(const string16& password, uint8* hash) {
-#ifdef IS_BIG_ENDIAN
- uint32 len = password.length();
- uint8* passbuf;
-
- passbuf = static_cast<uint8*>(malloc(len * 2));
- WriteUnicodeLE(passbuf, password.data(), len);
- weak_crypto::MD4Sum(passbuf, len * 2, hash);
-
- ZapBuf(passbuf, len * 2);
- free(passbuf);
-#else
- weak_crypto::MD4Sum(reinterpret_cast<const uint8*>(password.data()),
- password.length() * 2, hash);
-#endif
-}
-
-//-----------------------------------------------------------------------------
-
-// LM_Response generates the LM response given a 16-byte password hash and the
-// challenge from the Type-2 message.
-//
-// param hash
-// 16-byte password hash
-// param challenge
-// 8-byte challenge from Type-2 message
-// param response
-// 24-byte buffer to contain the LM response upon return
-static void LM_Response(const uint8* hash,
- const uint8* challenge,
- uint8* response) {
- uint8 keybytes[21], k1[8], k2[8], k3[8];
-
- memcpy(keybytes, hash, 16);
- ZapBuf(keybytes + 16, 5);
-
- DESMakeKey(keybytes , k1);
- DESMakeKey(keybytes + 7, k2);
- DESMakeKey(keybytes + 14, k3);
-
- DESEncrypt(k1, challenge, response);
- DESEncrypt(k2, challenge, response + 8);
- DESEncrypt(k3, challenge, response + 16);
-}
-
-//-----------------------------------------------------------------------------
-
-// Returns OK or a network error code.
-static int GenerateType1Msg(void** out_buf, uint32* out_len) {
- //
- // Verify that buf_len is sufficient.
- //
- *out_len = NTLM_TYPE1_HEADER_LEN;
- *out_buf = malloc(*out_len);
- if (!*out_buf)
- return ERR_OUT_OF_MEMORY;
-
- //
- // Write out type 1 message.
- //
- void* cursor = *out_buf;
-
- // 0 : signature
- cursor = WriteBytes(cursor, NTLM_SIGNATURE, sizeof(NTLM_SIGNATURE));
-
- // 8 : marker
- cursor = WriteBytes(cursor, NTLM_TYPE1_MARKER, sizeof(NTLM_TYPE1_MARKER));
-
- // 12 : flags
- cursor = WriteDWORD(cursor, NTLM_TYPE1_FLAGS);
-
- //
- // NOTE: It is common for the domain and workstation fields to be empty.
- // This is true of Win2k clients, and my guess is that there is
- // little utility to sending these strings before the charset has
- // been negotiated. We follow suite -- anyways, it doesn't hurt
- // to save some bytes on the wire ;-)
- //
-
- // 16 : supplied domain security buffer (empty)
- cursor = WriteSecBuf(cursor, 0, 0);
-
- // 24 : supplied workstation security buffer (empty)
- cursor = WriteSecBuf(cursor, 0, 0);
-
- return OK;
-}
-
-struct Type2Msg {
- uint32 flags; // NTLM_Xxx bitwise combination
- uint8 challenge[8]; // 8 byte challenge
- const void* target; // target string (type depends on flags)
- uint32 target_len; // target length in bytes
-};
-
-// Returns OK or a network error code.
-// TODO(wtc): This function returns ERR_UNEXPECTED when the input message is
-// invalid. We should return a better error code.
-static int ParseType2Msg(const void* in_buf, uint32 in_len, Type2Msg* msg) {
- // Make sure in_buf is long enough to contain a meaningful type2 msg.
- //
- // 0 NTLMSSP Signature
- // 8 NTLM Message Type
- // 12 Target Name
- // 20 Flags
- // 24 Challenge
- // 32 end of header, start of optional data blocks
- //
- if (in_len < NTLM_TYPE2_HEADER_LEN)
- return ERR_UNEXPECTED;
-
- const uint8* cursor = (const uint8*) in_buf;
-
- // verify NTLMSSP signature
- if (memcmp(cursor, NTLM_SIGNATURE, sizeof(NTLM_SIGNATURE)) != 0)
- return ERR_UNEXPECTED;
- cursor += sizeof(NTLM_SIGNATURE);
-
- // verify Type-2 marker
- if (memcmp(cursor, NTLM_TYPE2_MARKER, sizeof(NTLM_TYPE2_MARKER)) != 0)
- return ERR_UNEXPECTED;
- cursor += sizeof(NTLM_TYPE2_MARKER);
-
- // read target name security buffer
- uint32 target_len = ReadUint16(cursor);
- ReadUint16(cursor); // discard next 16-bit value
- uint32 offset = ReadUint32(cursor); // get offset from in_buf
- msg->target_len = 0;
- msg->target = NULL;
- // Check the offset / length combo is in range of the input buffer, including
- // integer overflow checking.
- if (offset + target_len > offset && offset + target_len <= in_len) {
- msg->target_len = target_len;
- msg->target = ((const uint8*) in_buf) + offset;
- }
-
- // read flags
- msg->flags = ReadUint32(cursor);
-
- // read challenge
- memcpy(msg->challenge, cursor, sizeof(msg->challenge));
- cursor += sizeof(msg->challenge);
-
- NTLM_LOG(("NTLM type 2 message:\n"));
- LogBuf("target", (const uint8*) msg->target, msg->target_len);
- LogBuf("flags", (const uint8*) &msg->flags, 4);
- LogFlags(msg->flags);
- LogBuf("challenge", msg->challenge, sizeof(msg->challenge));
-
- // We currently do not implement LMv2/NTLMv2 or NTLM2 responses,
- // so we can ignore target information. We may want to enable
- // support for these alternate mechanisms in the future.
- return OK;
-}
-
-static void GenerateRandom(uint8* output, size_t n) {
- for (size_t i = 0; i < n; ++i)
- output[i] = base::RandInt(0, 255);
-}
-
-// Returns OK or a network error code.
-static int GenerateType3Msg(const string16& domain,
- const string16& username,
- const string16& password,
- const std::string& hostname,
- const void* rand_8_bytes,
- const void* in_buf,
- uint32 in_len,
- void** out_buf,
- uint32* out_len) {
- // in_buf contains Type-2 msg (the challenge) from server.
-
- int rv;
- Type2Msg msg;
-
- rv = ParseType2Msg(in_buf, in_len, &msg);
- if (rv != OK)
- return rv;
-
- bool unicode = (msg.flags & NTLM_NegotiateUnicode) != 0;
-
- // Temporary buffers for unicode strings
-#ifdef IS_BIG_ENDIAN
- string16 ucs_domain_buf, ucs_user_buf;
-#endif
- string16 ucs_host_buf;
- // Temporary buffers for oem strings
- std::string oem_domain_buf, oem_user_buf;
- // Pointers and lengths for the string buffers; encoding is unicode if
- // the "negotiate unicode" flag was set in the Type-2 message.
- const void* domain_ptr;
- const void* user_ptr;
- const void* host_ptr;
- uint32 domain_len, user_len, host_len;
-
- //
- // Get domain name.
- //
- if (unicode) {
-#ifdef IS_BIG_ENDIAN
- ucs_domain_buf = domain;
- domain_ptr = ucs_domain_buf.data();
- domain_len = ucs_domain_buf.length() * 2;
- WriteUnicodeLE(const_cast<void*>(domain_ptr), (const char16*) domain_ptr,
- ucs_domain_buf.length());
-#else
- domain_ptr = domain.data();
- domain_len = domain.length() * 2;
-#endif
- } else {
- oem_domain_buf = base::SysWideToNativeMB(UTF16ToWide(domain));
- domain_ptr = oem_domain_buf.data();
- domain_len = oem_domain_buf.length();
- }
-
- //
- // Get user name.
- //
- if (unicode) {
-#ifdef IS_BIG_ENDIAN
- ucs_user_buf = username;
- user_ptr = ucs_user_buf.data();
- user_len = ucs_user_buf.length() * 2;
- WriteUnicodeLE(const_cast<void*>(user_ptr), (const char16*) user_ptr,
- ucs_user_buf.length());
-#else
- user_ptr = username.data();
- user_len = username.length() * 2;
-#endif
- } else {
- oem_user_buf = base::SysWideToNativeMB(UTF16ToWide(username));
- user_ptr = oem_user_buf.data();
- user_len = oem_user_buf.length();
- }
-
- //
- // Get workstation name (use local machine's hostname).
- //
- if (unicode) {
- // hostname is ASCII, so we can do a simple zero-pad expansion:
- ucs_host_buf.assign(hostname.begin(), hostname.end());
- host_ptr = ucs_host_buf.data();
- host_len = ucs_host_buf.length() * 2;
-#ifdef IS_BIG_ENDIAN
- WriteUnicodeLE(const_cast<void*>(host_ptr), (const char16*) host_ptr,
- ucs_host_buf.length());
-#endif
- } else {
- host_ptr = hostname.data();
- host_len = hostname.length();
- }
-
- //
- // Now that we have generated all of the strings, we can allocate out_buf.
- //
- *out_len = NTLM_TYPE3_HEADER_LEN + host_len + domain_len + user_len +
- LM_RESP_LEN + NTLM_RESP_LEN;
- *out_buf = malloc(*out_len);
- if (!*out_buf)
- return ERR_OUT_OF_MEMORY;
-
- //
- // Next, we compute the LM and NTLM responses.
- //
- uint8 lm_resp[LM_RESP_LEN];
- uint8 ntlm_resp[NTLM_RESP_LEN];
- uint8 ntlm_hash[NTLM_HASH_LEN];
- if (msg.flags & NTLM_NegotiateNTLM2Key) {
- // compute NTLM2 session response
- MD5Digest session_hash;
- uint8 temp[16];
-
- memcpy(lm_resp, rand_8_bytes, 8);
- memset(lm_resp + 8, 0, LM_RESP_LEN - 8);
-
- memcpy(temp, msg.challenge, 8);
- memcpy(temp + 8, lm_resp, 8);
- MD5Sum(temp, 16, &session_hash);
-
- NTLM_Hash(password, ntlm_hash);
- LM_Response(ntlm_hash, session_hash.a, ntlm_resp);
- } else {
- NTLM_Hash(password, ntlm_hash);
- LM_Response(ntlm_hash, msg.challenge, ntlm_resp);
-
- if (SendLM()) {
- uint8 lm_hash[LM_HASH_LEN];
- LM_Hash(password, lm_hash);
- LM_Response(lm_hash, msg.challenge, lm_resp);
- } else {
- // According to http://davenport.sourceforge.net/ntlm.html#ntlmVersion2,
- // the correct way to not send the LM hash is to send the NTLM hash twice
- // in both the LM and NTLM response fields.
- LM_Response(ntlm_hash, msg.challenge, lm_resp);
- }
- }
-
- //
- // Finally, we assemble the Type-3 msg :-)
- //
- void* cursor = *out_buf;
- uint32 offset;
-
- // 0 : signature
- cursor = WriteBytes(cursor, NTLM_SIGNATURE, sizeof(NTLM_SIGNATURE));
-
- // 8 : marker
- cursor = WriteBytes(cursor, NTLM_TYPE3_MARKER, sizeof(NTLM_TYPE3_MARKER));
-
- // 12 : LM response sec buf
- offset = NTLM_TYPE3_HEADER_LEN + domain_len + user_len + host_len;
- cursor = WriteSecBuf(cursor, LM_RESP_LEN, offset);
- memcpy(static_cast<uint8*>(*out_buf) + offset, lm_resp, LM_RESP_LEN);
-
- // 20 : NTLM response sec buf
- offset += LM_RESP_LEN;
- cursor = WriteSecBuf(cursor, NTLM_RESP_LEN, offset);
- memcpy(static_cast<uint8*>(*out_buf) + offset, ntlm_resp, NTLM_RESP_LEN);
-
- // 28 : domain name sec buf
- offset = NTLM_TYPE3_HEADER_LEN;
- cursor = WriteSecBuf(cursor, domain_len, offset);
- memcpy(static_cast<uint8*>(*out_buf) + offset, domain_ptr, domain_len);
-
- // 36 : user name sec buf
- offset += domain_len;
- cursor = WriteSecBuf(cursor, user_len, offset);
- memcpy(static_cast<uint8*>(*out_buf) + offset, user_ptr, user_len);
-
- // 44 : workstation (host) name sec buf
- offset += user_len;
- cursor = WriteSecBuf(cursor, host_len, offset);
- memcpy(static_cast<uint8*>(*out_buf) + offset, host_ptr, host_len);
-
- // 52 : session key sec buf (not used)
- cursor = WriteSecBuf(cursor, 0, 0);
-
- // 60 : negotiated flags
- cursor = WriteDWORD(cursor, msg.flags & NTLM_TYPE1_FLAGS);
-
- return OK;
-}
-
-// NTLM authentication is specified in "NTLM Over HTTP Protocol Specification"
-// [MS-NTHT].
-
-// static
-HttpAuthHandlerNTLM::GenerateRandomProc
-HttpAuthHandlerNTLM::generate_random_proc_ = GenerateRandom;
-
-// static
-HttpAuthHandlerNTLM::HostNameProc
-HttpAuthHandlerNTLM::get_host_name_proc_ = GetHostName;
-
-HttpAuthHandlerNTLM::HttpAuthHandlerNTLM() {
-}
-
-HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() {
- // Wipe our copy of the password from memory, to reduce the chance of being
- // written to the paging file on disk.
- ZapString(&password_);
-}
-
-bool HttpAuthHandlerNTLM::NeedsIdentity() {
- return !auth_data_.empty();
-}
-
std::string HttpAuthHandlerNTLM::GenerateCredentials(
const std::wstring& username,
const std::wstring& password,
@@ -686,6 +42,9 @@ std::string HttpAuthHandlerNTLM::GenerateCredentials(
if (auth_data_.empty()) {
in_buf_len = 0;
in_buf = NULL;
+ int rv = InitializeBeforeFirstChallenge();
+ if (rv != OK)
+ return std::string();
} else {
// Decode |auth_data_| into the input buffer.
int len = auth_data_.length();
@@ -719,23 +78,6 @@ std::string HttpAuthHandlerNTLM::GenerateCredentials(
return std::string("NTLM ") + encode_output;
}
-// static
-HttpAuthHandlerNTLM::GenerateRandomProc
-HttpAuthHandlerNTLM::SetGenerateRandomProc(
- GenerateRandomProc proc) {
- GenerateRandomProc old_proc = generate_random_proc_;
- generate_random_proc_ = proc;
- return old_proc;
-}
-
-// static
-HttpAuthHandlerNTLM::HostNameProc HttpAuthHandlerNTLM::SetHostNameProc(
- HostNameProc proc) {
- HostNameProc old_proc = get_host_name_proc_;
- get_host_name_proc_ = proc;
- return old_proc;
-}
-
// The NTLM challenge header looks like:
// WWW-Authenticate: NTLM auth-data
bool HttpAuthHandlerNTLM::ParseChallenge(
@@ -763,30 +105,4 @@ bool HttpAuthHandlerNTLM::ParseChallenge(
return true;
}
-int HttpAuthHandlerNTLM::GetNextToken(const void* in_token,
- uint32 in_token_len,
- void** out_token,
- uint32* out_token_len) {
- int rv;
-
- // If in_token is non-null, then assume it contains a type 2 message...
- if (in_token) {
- LogToken("in-token", in_token, in_token_len);
- std::string hostname = get_host_name_proc_();
- if (hostname.empty())
- return ERR_UNEXPECTED;
- uint8 rand_buf[8];
- generate_random_proc_(rand_buf, 8);
- rv = GenerateType3Msg(domain_, username_, password_, hostname, rand_buf,
- in_token, in_token_len, out_token, out_token_len);
- } else {
- rv = GenerateType1Msg(out_token, out_token_len);
- }
-
- if (rv == OK)
- LogToken("out-token", *out_token, *out_token_len);
-
- return rv;
-}
-
} // namespace net
diff --git a/net/http/http_auth_handler_ntlm.h b/net/http/http_auth_handler_ntlm.h
index 9b8a3b1..27a6666 100644
--- a/net/http/http_auth_handler_ntlm.h
+++ b/net/http/http_auth_handler_ntlm.h
@@ -5,20 +5,34 @@
#ifndef NET_HTTP_HTTP_AUTH_HANDLER_NTLM_H_
#define NET_HTTP_HTTP_AUTH_HANDLER_NTLM_H_
+#include "build/build_config.h"
+
+// This contains the portable and the SSPI implementations for NTLM.
+// We use NTLM_SSPI for Windows, and NTLM_PORTABLE for other platforms.
+#if defined(OS_WIN)
+#define NTLM_SSPI
+#else
+#define NTLM_PORTABLE
+#endif
+
+#if defined(NTLM_SSPI)
+#define SECURITY_WIN32 1
+#include <windows.h>
+#include <security.h>
+#endif
+
#include <string>
#include "base/basictypes.h"
-#include "base/scoped_ptr.h"
#include "base/string16.h"
#include "net/http/http_auth_handler.h"
namespace net {
-class NTLMAuthModule;
-
// Code for handling HTTP NTLM authentication.
class HttpAuthHandlerNTLM : public HttpAuthHandler {
public:
+#if defined(NTLM_PORTABLE)
// A function that generates n random bytes in the output buffer.
typedef void (*GenerateRandomProc)(uint8* output, size_t n);
@@ -45,6 +59,7 @@ class HttpAuthHandlerNTLM : public HttpAuthHandler {
GenerateRandomProc old_random_proc_;
HostNameProc old_host_name_proc_;
};
+#endif
HttpAuthHandlerNTLM();
@@ -52,6 +67,8 @@ class HttpAuthHandlerNTLM : public HttpAuthHandler {
virtual bool NeedsIdentity();
+ virtual bool IsFinalRound();
+
virtual std::string GenerateCredentials(const std::wstring& username,
const std::wstring& password,
const HttpRequestInfo* request,
@@ -63,11 +80,17 @@ class HttpAuthHandlerNTLM : public HttpAuthHandler {
return ParseChallenge(challenge_begin, challenge_end);
}
+ // This function acquires a credentials handle in the SSPI implementation.
+ // It does nothing in the portable implementation.
+ int InitializeBeforeFirstChallenge();
+
private:
+#if defined(NTLM_PORTABLE)
// For unit tests to override the GenerateRandom and GetHostName functions.
// Returns the old function.
static GenerateRandomProc SetGenerateRandomProc(GenerateRandomProc proc);
static HostNameProc SetHostNameProc(HostNameProc proc);
+#endif
// Parse the challenge, saving the results into this instance.
// Returns true on success.
@@ -81,8 +104,14 @@ class HttpAuthHandlerNTLM : public HttpAuthHandler {
void** out_token,
uint32* out_token_len);
+#if defined(NTLM_SSPI)
+ void ResetSecurityContext();
+#endif
+
+#if defined(NTLM_PORTABLE)
static GenerateRandomProc generate_random_proc_;
static HostNameProc get_host_name_proc_;
+#endif
string16 domain_;
string16 username_;
@@ -91,6 +120,12 @@ class HttpAuthHandlerNTLM : public HttpAuthHandler {
// The base64-encoded string following "NTLM" in the "WWW-Authenticate" or
// "Proxy-Authenticate" response header.
std::string auth_data_;
+
+#if defined(NTLM_SSPI)
+ ULONG max_token_len_;
+ CredHandle cred_;
+ CtxtHandle ctxt_;
+#endif
};
} // namespace net
diff --git a/net/http/http_auth_handler_ntlm_portable.cc b/net/http/http_auth_handler_ntlm_portable.cc
new file mode 100644
index 0000000..034fefc
--- /dev/null
+++ b/net/http/http_auth_handler_ntlm_portable.cc
@@ -0,0 +1,707 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/http_auth_handler_ntlm.h"
+
+#include <stdlib.h>
+// For gethostname
+#if defined(OS_POSIX)
+#include <unistd.h>
+#elif defined(OS_WIN)
+#include <winsock2.h>
+#endif
+
+#include "base/md5.h"
+#include "base/rand_util.h"
+#include "base/string_util.h"
+#include "base/sys_string_conversions.h"
+#include "net/base/net_errors.h"
+#include "net/base/net_util.h"
+#include "net/http/des.h"
+#include "net/http/md4.h"
+
+namespace net {
+
+// Based on mozilla/security/manager/ssl/src/nsNTLMAuthModule.cpp,
+// CVS rev. 1.14.
+//
+// TODO(wtc):
+// - The IS_BIG_ENDIAN code is not tested.
+// - Enable the logging code or just delete it.
+// - Delete or comment out the LM code, which hasn't been tested and isn't
+// being used.
+
+/* ***** BEGIN LICENSE BLOCK *****
+ * Version: MPL 1.1/GPL 2.0/LGPL 2.1
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * The Original Code is Mozilla.
+ *
+ * The Initial Developer of the Original Code is IBM Corporation.
+ * Portions created by IBM Corporation are Copyright (C) 2003
+ * IBM Corporation. All Rights Reserved.
+ *
+ * Contributor(s):
+ * Darin Fisher <darin@meer.net>
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either the GNU General Public License Version 2 or later (the "GPL"), or
+ * the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
+ * in which case the provisions of the GPL or the LGPL are applicable instead
+ * of those above. If you wish to allow use of your version of this file only
+ * under the terms of either the GPL or the LGPL, and not to allow others to
+ * use your version of this file under the terms of the MPL, indicate your
+ * decision by deleting the provisions above and replace them with the notice
+ * and other provisions required by the GPL or the LGPL. If you do not delete
+ * the provisions above, a recipient may use your version of this file under
+ * the terms of any one of the MPL, the GPL or the LGPL.
+ *
+ * ***** END LICENSE BLOCK ***** */
+
+// Discover the endianness by testing processor architecture.
+#if defined(ARCH_CPU_X86) || defined(ARCH_CPU_X86_64) || defined(ARCH_CPU_ARMEL)
+#define IS_LITTLE_ENDIAN 1
+#undef IS_BIG_ENDIAN
+#else
+#error "Unknown endianness"
+#endif
+
+#define NTLM_LOG(x) ((void) 0)
+
+//-----------------------------------------------------------------------------
+// This file contains a cross-platform NTLM authentication implementation. It
+// is based on documentation from: http://davenport.sourceforge.net/ntlm.html
+//-----------------------------------------------------------------------------
+
+enum {
+ NTLM_NegotiateUnicode = 0x00000001,
+ NTLM_NegotiateOEM = 0x00000002,
+ NTLM_RequestTarget = 0x00000004,
+ NTLM_Unknown1 = 0x00000008,
+ NTLM_NegotiateSign = 0x00000010,
+ NTLM_NegotiateSeal = 0x00000020,
+ NTLM_NegotiateDatagramStyle = 0x00000040,
+ NTLM_NegotiateLanManagerKey = 0x00000080,
+ NTLM_NegotiateNetware = 0x00000100,
+ NTLM_NegotiateNTLMKey = 0x00000200,
+ NTLM_Unknown2 = 0x00000400,
+ NTLM_Unknown3 = 0x00000800,
+ NTLM_NegotiateDomainSupplied = 0x00001000,
+ NTLM_NegotiateWorkstationSupplied = 0x00002000,
+ NTLM_NegotiateLocalCall = 0x00004000,
+ NTLM_NegotiateAlwaysSign = 0x00008000,
+ NTLM_TargetTypeDomain = 0x00010000,
+ NTLM_TargetTypeServer = 0x00020000,
+ NTLM_TargetTypeShare = 0x00040000,
+ NTLM_NegotiateNTLM2Key = 0x00080000,
+ NTLM_RequestInitResponse = 0x00100000,
+ NTLM_RequestAcceptResponse = 0x00200000,
+ NTLM_RequestNonNTSessionKey = 0x00400000,
+ NTLM_NegotiateTargetInfo = 0x00800000,
+ NTLM_Unknown4 = 0x01000000,
+ NTLM_Unknown5 = 0x02000000,
+ NTLM_Unknown6 = 0x04000000,
+ NTLM_Unknown7 = 0x08000000,
+ NTLM_Unknown8 = 0x10000000,
+ NTLM_Negotiate128 = 0x20000000,
+ NTLM_NegotiateKeyExchange = 0x40000000,
+ NTLM_Negotiate56 = 0x80000000
+};
+
+// We send these flags with our type 1 message.
+enum {
+ NTLM_TYPE1_FLAGS =
+ NTLM_NegotiateUnicode |
+ NTLM_NegotiateOEM |
+ NTLM_RequestTarget |
+ NTLM_NegotiateNTLMKey |
+ NTLM_NegotiateAlwaysSign |
+ NTLM_NegotiateNTLM2Key
+};
+
+static const char NTLM_SIGNATURE[] = "NTLMSSP";
+static const char NTLM_TYPE1_MARKER[] = { 0x01, 0x00, 0x00, 0x00 };
+static const char NTLM_TYPE2_MARKER[] = { 0x02, 0x00, 0x00, 0x00 };
+static const char NTLM_TYPE3_MARKER[] = { 0x03, 0x00, 0x00, 0x00 };
+
+enum {
+ NTLM_TYPE1_HEADER_LEN = 32,
+ NTLM_TYPE2_HEADER_LEN = 32,
+ NTLM_TYPE3_HEADER_LEN = 64,
+
+ LM_HASH_LEN = 16,
+ LM_RESP_LEN = 24,
+
+ NTLM_HASH_LEN = 16,
+ NTLM_RESP_LEN = 24
+};
+
+//-----------------------------------------------------------------------------
+
+// The return value of this function controls whether or not the LM hash will
+// be included in response to a NTLM challenge.
+//
+// In Mozilla, this function returns the value of the boolean preference
+// "network.ntlm.send-lm-response". By default, the preference is disabled
+// since servers should almost never need the LM hash, and the LM hash is what
+// makes NTLM authentication less secure. See
+// https://bugzilla.mozilla.org/show_bug.cgi?id=250691 for further details.
+//
+// We just return a hardcoded false.
+static bool SendLM() {
+ return false;
+}
+
+//-----------------------------------------------------------------------------
+
+#define LogFlags(x) ((void) 0)
+#define LogBuf(a, b, c) ((void) 0)
+#define LogToken(a, b, c) ((void) 0)
+
+//-----------------------------------------------------------------------------
+
+// Byte order swapping.
+#define SWAP16(x) ((((x) & 0xff) << 8) | (((x) >> 8) & 0xff))
+#define SWAP32(x) ((SWAP16((x) & 0xffff) << 16) | (SWAP16((x) >> 16)))
+
+static void* WriteBytes(void* buf, const void* data, uint32 data_len) {
+ memcpy(buf, data, data_len);
+ return static_cast<char*>(buf) + data_len;
+}
+
+static void* WriteDWORD(void* buf, uint32 dword) {
+#ifdef IS_BIG_ENDIAN
+ // NTLM uses little endian on the wire.
+ dword = SWAP32(dword);
+#endif
+ return WriteBytes(buf, &dword, sizeof(dword));
+}
+
+static void* WriteSecBuf(void* buf, uint16 length, uint32 offset) {
+#ifdef IS_BIG_ENDIAN
+ length = SWAP16(length);
+ offset = SWAP32(offset);
+#endif
+ buf = WriteBytes(buf, &length, sizeof(length));
+ buf = WriteBytes(buf, &length, sizeof(length));
+ buf = WriteBytes(buf, &offset, sizeof(offset));
+ return buf;
+}
+
+#ifdef IS_BIG_ENDIAN
+/**
+ * WriteUnicodeLE copies a unicode string from one buffer to another. The
+ * resulting unicode string is in little-endian format. The input string is
+ * assumed to be in the native endianness of the local machine. It is safe
+ * to pass the same buffer as both input and output, which is a handy way to
+ * convert the unicode buffer to little-endian on big-endian platforms.
+ */
+static void* WriteUnicodeLE(void* buf, const char16* str, uint32 str_len) {
+ // Convert input string from BE to LE.
+ uint8* cursor = static_cast<uint8*>(buf);
+ const uint8* input = reinterpret_cast<const uint8*>(str);
+ for (uint32 i = 0; i < str_len; ++i, input += 2, cursor += 2) {
+ // Allow for the case where |buf == str|.
+ uint8 temp = input[0];
+ cursor[0] = input[1];
+ cursor[1] = temp;
+ }
+ return buf;
+}
+#endif
+
+static uint16 ReadUint16(const uint8*& buf) {
+ uint16 x = (static_cast<uint16>(buf[0])) |
+ (static_cast<uint16>(buf[1]) << 8);
+ buf += sizeof(x);
+ return x;
+}
+
+static uint32 ReadUint32(const uint8*& buf) {
+ uint32 x = (static_cast<uint32>(buf[0])) |
+ (static_cast<uint32>(buf[1]) << 8) |
+ (static_cast<uint32>(buf[2]) << 16) |
+ (static_cast<uint32>(buf[3]) << 24);
+ buf += sizeof(x);
+ return x;
+}
+
+//-----------------------------------------------------------------------------
+
+static void ZapBuf(void* buf, size_t buf_len) {
+ memset(buf, 0, buf_len);
+}
+
+// TODO(wtc): Can we implement ZapString as
+// s.replace(0, s.size(), s.size(), '\0)?
+static void ZapString(std::string* s) {
+ ZapBuf(&(*s)[0], s->length());
+}
+
+static void ZapString(string16* s) {
+ ZapBuf(&(*s)[0], s->length() * 2);
+}
+
+// LM_Hash computes the LM hash of the given password.
+//
+// param password
+// unicode password.
+// param hash
+// 16-byte result buffer
+//
+// Note: This function is not being used because our SendLM() function always
+// returns false.
+static void LM_Hash(const string16& password, uint8* hash) {
+ static const uint8 LM_MAGIC[] = "KGS!@#$%";
+
+ // Convert password to OEM character set. We'll just use the native
+ // filesystem charset.
+ std::string passbuf = base::SysWideToNativeMB(UTF16ToWide(password));
+ StringToUpperASCII(&passbuf);
+ passbuf.resize(14, '\0');
+
+ uint8 k1[8], k2[8];
+ DESMakeKey(reinterpret_cast<const uint8*>(passbuf.data()) , k1);
+ DESMakeKey(reinterpret_cast<const uint8*>(passbuf.data()) + 7, k2);
+ ZapString(&passbuf);
+
+ // Use password keys to hash LM magic string twice.
+ DESEncrypt(k1, LM_MAGIC, hash);
+ DESEncrypt(k2, LM_MAGIC, hash + 8);
+}
+
+// NTLM_Hash computes the NTLM hash of the given password.
+//
+// param password
+// null-terminated unicode password.
+// param hash
+// 16-byte result buffer
+static void NTLM_Hash(const string16& password, uint8* hash) {
+#ifdef IS_BIG_ENDIAN
+ uint32 len = password.length();
+ uint8* passbuf;
+
+ passbuf = static_cast<uint8*>(malloc(len * 2));
+ WriteUnicodeLE(passbuf, password.data(), len);
+ weak_crypto::MD4Sum(passbuf, len * 2, hash);
+
+ ZapBuf(passbuf, len * 2);
+ free(passbuf);
+#else
+ weak_crypto::MD4Sum(reinterpret_cast<const uint8*>(password.data()),
+ password.length() * 2, hash);
+#endif
+}
+
+//-----------------------------------------------------------------------------
+
+// LM_Response generates the LM response given a 16-byte password hash and the
+// challenge from the Type-2 message.
+//
+// param hash
+// 16-byte password hash
+// param challenge
+// 8-byte challenge from Type-2 message
+// param response
+// 24-byte buffer to contain the LM response upon return
+static void LM_Response(const uint8* hash,
+ const uint8* challenge,
+ uint8* response) {
+ uint8 keybytes[21], k1[8], k2[8], k3[8];
+
+ memcpy(keybytes, hash, 16);
+ ZapBuf(keybytes + 16, 5);
+
+ DESMakeKey(keybytes , k1);
+ DESMakeKey(keybytes + 7, k2);
+ DESMakeKey(keybytes + 14, k3);
+
+ DESEncrypt(k1, challenge, response);
+ DESEncrypt(k2, challenge, response + 8);
+ DESEncrypt(k3, challenge, response + 16);
+}
+
+//-----------------------------------------------------------------------------
+
+// Returns OK or a network error code.
+static int GenerateType1Msg(void** out_buf, uint32* out_len) {
+ //
+ // Verify that buf_len is sufficient.
+ //
+ *out_len = NTLM_TYPE1_HEADER_LEN;
+ *out_buf = malloc(*out_len);
+ if (!*out_buf)
+ return ERR_OUT_OF_MEMORY;
+
+ //
+ // Write out type 1 message.
+ //
+ void* cursor = *out_buf;
+
+ // 0 : signature
+ cursor = WriteBytes(cursor, NTLM_SIGNATURE, sizeof(NTLM_SIGNATURE));
+
+ // 8 : marker
+ cursor = WriteBytes(cursor, NTLM_TYPE1_MARKER, sizeof(NTLM_TYPE1_MARKER));
+
+ // 12 : flags
+ cursor = WriteDWORD(cursor, NTLM_TYPE1_FLAGS);
+
+ //
+ // NOTE: It is common for the domain and workstation fields to be empty.
+ // This is true of Win2k clients, and my guess is that there is
+ // little utility to sending these strings before the charset has
+ // been negotiated. We follow suite -- anyways, it doesn't hurt
+ // to save some bytes on the wire ;-)
+ //
+
+ // 16 : supplied domain security buffer (empty)
+ cursor = WriteSecBuf(cursor, 0, 0);
+
+ // 24 : supplied workstation security buffer (empty)
+ cursor = WriteSecBuf(cursor, 0, 0);
+
+ return OK;
+}
+
+struct Type2Msg {
+ uint32 flags; // NTLM_Xxx bitwise combination
+ uint8 challenge[8]; // 8 byte challenge
+ const void* target; // target string (type depends on flags)
+ uint32 target_len; // target length in bytes
+};
+
+// Returns OK or a network error code.
+// TODO(wtc): This function returns ERR_UNEXPECTED when the input message is
+// invalid. We should return a better error code.
+static int ParseType2Msg(const void* in_buf, uint32 in_len, Type2Msg* msg) {
+ // Make sure in_buf is long enough to contain a meaningful type2 msg.
+ //
+ // 0 NTLMSSP Signature
+ // 8 NTLM Message Type
+ // 12 Target Name
+ // 20 Flags
+ // 24 Challenge
+ // 32 end of header, start of optional data blocks
+ //
+ if (in_len < NTLM_TYPE2_HEADER_LEN)
+ return ERR_UNEXPECTED;
+
+ const uint8* cursor = (const uint8*) in_buf;
+
+ // verify NTLMSSP signature
+ if (memcmp(cursor, NTLM_SIGNATURE, sizeof(NTLM_SIGNATURE)) != 0)
+ return ERR_UNEXPECTED;
+ cursor += sizeof(NTLM_SIGNATURE);
+
+ // verify Type-2 marker
+ if (memcmp(cursor, NTLM_TYPE2_MARKER, sizeof(NTLM_TYPE2_MARKER)) != 0)
+ return ERR_UNEXPECTED;
+ cursor += sizeof(NTLM_TYPE2_MARKER);
+
+ // read target name security buffer
+ uint32 target_len = ReadUint16(cursor);
+ ReadUint16(cursor); // discard next 16-bit value
+ uint32 offset = ReadUint32(cursor); // get offset from in_buf
+ msg->target_len = 0;
+ msg->target = NULL;
+ // Check the offset / length combo is in range of the input buffer, including
+ // integer overflow checking.
+ if (offset + target_len > offset && offset + target_len <= in_len) {
+ msg->target_len = target_len;
+ msg->target = ((const uint8*) in_buf) + offset;
+ }
+
+ // read flags
+ msg->flags = ReadUint32(cursor);
+
+ // read challenge
+ memcpy(msg->challenge, cursor, sizeof(msg->challenge));
+ cursor += sizeof(msg->challenge);
+
+ NTLM_LOG(("NTLM type 2 message:\n"));
+ LogBuf("target", (const uint8*) msg->target, msg->target_len);
+ LogBuf("flags", (const uint8*) &msg->flags, 4);
+ LogFlags(msg->flags);
+ LogBuf("challenge", msg->challenge, sizeof(msg->challenge));
+
+ // We currently do not implement LMv2/NTLMv2 or NTLM2 responses,
+ // so we can ignore target information. We may want to enable
+ // support for these alternate mechanisms in the future.
+ return OK;
+}
+
+static void GenerateRandom(uint8* output, size_t n) {
+ for (size_t i = 0; i < n; ++i)
+ output[i] = base::RandInt(0, 255);
+}
+
+// Returns OK or a network error code.
+static int GenerateType3Msg(const string16& domain,
+ const string16& username,
+ const string16& password,
+ const std::string& hostname,
+ const void* rand_8_bytes,
+ const void* in_buf,
+ uint32 in_len,
+ void** out_buf,
+ uint32* out_len) {
+ // in_buf contains Type-2 msg (the challenge) from server.
+
+ int rv;
+ Type2Msg msg;
+
+ rv = ParseType2Msg(in_buf, in_len, &msg);
+ if (rv != OK)
+ return rv;
+
+ bool unicode = (msg.flags & NTLM_NegotiateUnicode) != 0;
+
+ // Temporary buffers for unicode strings
+#ifdef IS_BIG_ENDIAN
+ string16 ucs_domain_buf, ucs_user_buf;
+#endif
+ string16 ucs_host_buf;
+ // Temporary buffers for oem strings
+ std::string oem_domain_buf, oem_user_buf;
+ // Pointers and lengths for the string buffers; encoding is unicode if
+ // the "negotiate unicode" flag was set in the Type-2 message.
+ const void* domain_ptr;
+ const void* user_ptr;
+ const void* host_ptr;
+ uint32 domain_len, user_len, host_len;
+
+ //
+ // Get domain name.
+ //
+ if (unicode) {
+#ifdef IS_BIG_ENDIAN
+ ucs_domain_buf = domain;
+ domain_ptr = ucs_domain_buf.data();
+ domain_len = ucs_domain_buf.length() * 2;
+ WriteUnicodeLE(const_cast<void*>(domain_ptr), (const char16*) domain_ptr,
+ ucs_domain_buf.length());
+#else
+ domain_ptr = domain.data();
+ domain_len = domain.length() * 2;
+#endif
+ } else {
+ oem_domain_buf = base::SysWideToNativeMB(UTF16ToWide(domain));
+ domain_ptr = oem_domain_buf.data();
+ domain_len = oem_domain_buf.length();
+ }
+
+ //
+ // Get user name.
+ //
+ if (unicode) {
+#ifdef IS_BIG_ENDIAN
+ ucs_user_buf = username;
+ user_ptr = ucs_user_buf.data();
+ user_len = ucs_user_buf.length() * 2;
+ WriteUnicodeLE(const_cast<void*>(user_ptr), (const char16*) user_ptr,
+ ucs_user_buf.length());
+#else
+ user_ptr = username.data();
+ user_len = username.length() * 2;
+#endif
+ } else {
+ oem_user_buf = base::SysWideToNativeMB(UTF16ToWide(username));
+ user_ptr = oem_user_buf.data();
+ user_len = oem_user_buf.length();
+ }
+
+ //
+ // Get workstation name (use local machine's hostname).
+ //
+ if (unicode) {
+ // hostname is ASCII, so we can do a simple zero-pad expansion:
+ ucs_host_buf.assign(hostname.begin(), hostname.end());
+ host_ptr = ucs_host_buf.data();
+ host_len = ucs_host_buf.length() * 2;
+#ifdef IS_BIG_ENDIAN
+ WriteUnicodeLE(const_cast<void*>(host_ptr), (const char16*) host_ptr,
+ ucs_host_buf.length());
+#endif
+ } else {
+ host_ptr = hostname.data();
+ host_len = hostname.length();
+ }
+
+ //
+ // Now that we have generated all of the strings, we can allocate out_buf.
+ //
+ *out_len = NTLM_TYPE3_HEADER_LEN + host_len + domain_len + user_len +
+ LM_RESP_LEN + NTLM_RESP_LEN;
+ *out_buf = malloc(*out_len);
+ if (!*out_buf)
+ return ERR_OUT_OF_MEMORY;
+
+ //
+ // Next, we compute the LM and NTLM responses.
+ //
+ uint8 lm_resp[LM_RESP_LEN];
+ uint8 ntlm_resp[NTLM_RESP_LEN];
+ uint8 ntlm_hash[NTLM_HASH_LEN];
+ if (msg.flags & NTLM_NegotiateNTLM2Key) {
+ // compute NTLM2 session response
+ MD5Digest session_hash;
+ uint8 temp[16];
+
+ memcpy(lm_resp, rand_8_bytes, 8);
+ memset(lm_resp + 8, 0, LM_RESP_LEN - 8);
+
+ memcpy(temp, msg.challenge, 8);
+ memcpy(temp + 8, lm_resp, 8);
+ MD5Sum(temp, 16, &session_hash);
+
+ NTLM_Hash(password, ntlm_hash);
+ LM_Response(ntlm_hash, session_hash.a, ntlm_resp);
+ } else {
+ NTLM_Hash(password, ntlm_hash);
+ LM_Response(ntlm_hash, msg.challenge, ntlm_resp);
+
+ if (SendLM()) {
+ uint8 lm_hash[LM_HASH_LEN];
+ LM_Hash(password, lm_hash);
+ LM_Response(lm_hash, msg.challenge, lm_resp);
+ } else {
+ // According to http://davenport.sourceforge.net/ntlm.html#ntlmVersion2,
+ // the correct way to not send the LM hash is to send the NTLM hash twice
+ // in both the LM and NTLM response fields.
+ LM_Response(ntlm_hash, msg.challenge, lm_resp);
+ }
+ }
+
+ //
+ // Finally, we assemble the Type-3 msg :-)
+ //
+ void* cursor = *out_buf;
+ uint32 offset;
+
+ // 0 : signature
+ cursor = WriteBytes(cursor, NTLM_SIGNATURE, sizeof(NTLM_SIGNATURE));
+
+ // 8 : marker
+ cursor = WriteBytes(cursor, NTLM_TYPE3_MARKER, sizeof(NTLM_TYPE3_MARKER));
+
+ // 12 : LM response sec buf
+ offset = NTLM_TYPE3_HEADER_LEN + domain_len + user_len + host_len;
+ cursor = WriteSecBuf(cursor, LM_RESP_LEN, offset);
+ memcpy(static_cast<uint8*>(*out_buf) + offset, lm_resp, LM_RESP_LEN);
+
+ // 20 : NTLM response sec buf
+ offset += LM_RESP_LEN;
+ cursor = WriteSecBuf(cursor, NTLM_RESP_LEN, offset);
+ memcpy(static_cast<uint8*>(*out_buf) + offset, ntlm_resp, NTLM_RESP_LEN);
+
+ // 28 : domain name sec buf
+ offset = NTLM_TYPE3_HEADER_LEN;
+ cursor = WriteSecBuf(cursor, domain_len, offset);
+ memcpy(static_cast<uint8*>(*out_buf) + offset, domain_ptr, domain_len);
+
+ // 36 : user name sec buf
+ offset += domain_len;
+ cursor = WriteSecBuf(cursor, user_len, offset);
+ memcpy(static_cast<uint8*>(*out_buf) + offset, user_ptr, user_len);
+
+ // 44 : workstation (host) name sec buf
+ offset += user_len;
+ cursor = WriteSecBuf(cursor, host_len, offset);
+ memcpy(static_cast<uint8*>(*out_buf) + offset, host_ptr, host_len);
+
+ // 52 : session key sec buf (not used)
+ cursor = WriteSecBuf(cursor, 0, 0);
+
+ // 60 : negotiated flags
+ cursor = WriteDWORD(cursor, msg.flags & NTLM_TYPE1_FLAGS);
+
+ return OK;
+}
+
+// NTLM authentication is specified in "NTLM Over HTTP Protocol Specification"
+// [MS-NTHT].
+
+// static
+HttpAuthHandlerNTLM::GenerateRandomProc
+HttpAuthHandlerNTLM::generate_random_proc_ = GenerateRandom;
+
+// static
+HttpAuthHandlerNTLM::HostNameProc
+HttpAuthHandlerNTLM::get_host_name_proc_ = GetHostName;
+
+HttpAuthHandlerNTLM::HttpAuthHandlerNTLM() {
+}
+
+HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() {
+ // Wipe our copy of the password from memory, to reduce the chance of being
+ // written to the paging file on disk.
+ ZapString(&password_);
+}
+
+bool HttpAuthHandlerNTLM::NeedsIdentity() {
+ return !auth_data_.empty();
+}
+
+bool HttpAuthHandlerNTLM::IsFinalRound() {
+ return !auth_data_.empty();
+}
+
+// static
+HttpAuthHandlerNTLM::GenerateRandomProc
+HttpAuthHandlerNTLM::SetGenerateRandomProc(
+ GenerateRandomProc proc) {
+ GenerateRandomProc old_proc = generate_random_proc_;
+ generate_random_proc_ = proc;
+ return old_proc;
+}
+
+// static
+HttpAuthHandlerNTLM::HostNameProc HttpAuthHandlerNTLM::SetHostNameProc(
+ HostNameProc proc) {
+ HostNameProc old_proc = get_host_name_proc_;
+ get_host_name_proc_ = proc;
+ return old_proc;
+}
+
+int HttpAuthHandlerNTLM::GetNextToken(const void* in_token,
+ uint32 in_token_len,
+ void** out_token,
+ uint32* out_token_len) {
+ int rv;
+
+ // If in_token is non-null, then assume it contains a type 2 message...
+ if (in_token) {
+ LogToken("in-token", in_token, in_token_len);
+ std::string hostname = get_host_name_proc_();
+ if (hostname.empty())
+ return ERR_UNEXPECTED;
+ uint8 rand_buf[8];
+ generate_random_proc_(rand_buf, 8);
+ rv = GenerateType3Msg(domain_, username_, password_, hostname, rand_buf,
+ in_token, in_token_len, out_token, out_token_len);
+ } else {
+ rv = GenerateType1Msg(out_token, out_token_len);
+ }
+
+ if (rv == OK)
+ LogToken("out-token", *out_token, *out_token_len);
+
+ return rv;
+}
+
+int HttpAuthHandlerNTLM::InitializeBeforeFirstChallenge() {
+ return OK;
+}
+
+} // namespace net
diff --git a/net/http/http_auth_handler_ntlm_win.cc b/net/http/http_auth_handler_ntlm_win.cc
new file mode 100644
index 0000000..d638e8a
--- /dev/null
+++ b/net/http/http_auth_handler_ntlm_win.cc
@@ -0,0 +1,188 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// See "SSPI Sample Application" at
+// http://msdn.microsoft.com/en-us/library/aa918273.aspx
+// and "NTLM Security Support Provider" at
+// http://msdn.microsoft.com/en-us/library/aa923611.aspx.
+
+#include "net/http/http_auth_handler_ntlm.h"
+
+#include "base/logging.h"
+#include "net/base/net_errors.h"
+
+#pragma comment(lib, "secur32.lib")
+
+namespace {
+
+void ZapString(string16* s) {
+ memset(&(*s)[0], 0, s->length() * 2);
+}
+
+} // namespace
+
+namespace net {
+
+HttpAuthHandlerNTLM::HttpAuthHandlerNTLM() : max_token_len_(0) {
+ SecInvalidateHandle(&cred_);
+ SecInvalidateHandle(&ctxt_);
+}
+
+HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() {
+ ResetSecurityContext();
+ if (SecIsValidHandle(&cred_)) {
+ FreeCredentialsHandle(&cred_);
+ SecInvalidateHandle(&cred_);
+ }
+ ZapString(&password_);
+}
+
+int HttpAuthHandlerNTLM::InitializeBeforeFirstChallenge() {
+ DCHECK_EQ("ntlm", scheme_) << "This is not ntlm scheme";
+
+ SEC_WCHAR* package = NTLMSP_NAME;
+ PSecPkgInfo pkg_info;
+ SECURITY_STATUS status;
+
+ // The following API call is required to get the maximum token length
+ // for the scheme.
+ // TODO(arindam): Move this (PSecPkgInfo) to a static function.
+ status = QuerySecurityPackageInfo(package, &pkg_info);
+ if (status != SEC_E_OK) {
+ LOG(ERROR) << "Security package " << package << " not found";
+ return ERR_UNEXPECTED;
+ }
+ max_token_len_ = pkg_info->cbMaxToken;
+ FreeContextBuffer(pkg_info);
+
+ SEC_WINNT_AUTH_IDENTITY identity;
+ identity.Flags = SEC_WINNT_AUTH_IDENTITY_UNICODE;
+ identity.User =
+ reinterpret_cast<USHORT*>(const_cast<wchar_t*>(username_.c_str()));
+ identity.UserLength = username_.size();
+ identity.Domain =
+ reinterpret_cast<USHORT*>(const_cast<wchar_t*>(domain_.c_str()));
+ identity.DomainLength = domain_.size();
+ identity.Password =
+ reinterpret_cast<USHORT*>(const_cast<wchar_t*>(password_.c_str()));
+ identity.PasswordLength = password_.size();
+
+ TimeStamp expiry; // Since the credentials handle doesn't expire, ignore
+ // the expiration time.
+
+ // Pass the username/password to get the credentials handle.
+ // Note: If the 5th argument is NULL, it uses the default cached credentials
+ // for the logged in user, which can be used for single sign-on.
+ status = AcquireCredentialsHandle(NULL, // pszPrincipal
+ package, // pszPackage
+ SECPKG_CRED_OUTBOUND, // fCredentialUse
+ NULL, // pvLogonID
+ &identity, // pAuthData
+ NULL, // pGetKeyFn (not used)
+ NULL, // pvGetKeyArgument (not used)
+ &cred_, // phCredential
+ &expiry); // ptsExpiry
+ if (status != SEC_E_OK)
+ return ERR_UNEXPECTED;
+
+ return OK;
+}
+
+int HttpAuthHandlerNTLM::GetNextToken(const void* in_token,
+ uint32 in_token_len,
+ void** out_token,
+ uint32* out_token_len) {
+ SECURITY_STATUS status;
+ TimeStamp expiry;
+
+ DWORD ctxt_attr;
+ CtxtHandle* ctxt_ptr;
+ SecBufferDesc in_buffer_desc, out_buffer_desc;
+ SecBufferDesc* in_buffer_desc_ptr;
+ SecBuffer in_buffer, out_buffer;
+
+ if (in_token) {
+ // Prepare input buffer.
+ in_buffer_desc.ulVersion = SECBUFFER_VERSION;
+ in_buffer_desc.cBuffers = 1;
+ in_buffer_desc.pBuffers = &in_buffer;
+ in_buffer.BufferType = SECBUFFER_TOKEN;
+ in_buffer.cbBuffer = in_token_len;
+ in_buffer.pvBuffer = const_cast<void*>(in_token);
+ ctxt_ptr = &ctxt_;
+ in_buffer_desc_ptr = &in_buffer_desc;
+ } else {
+ // If there is no input token, then we are starting a new authentication
+ // sequence. If we have already initialized our security context, then
+ // we're incorrectly reusing the auth handler for a new sequence.
+ if (SecIsValidHandle(&ctxt_)) {
+ LOG(ERROR) << "Cannot restart authentication sequence";
+ return ERR_UNEXPECTED;
+ }
+ ctxt_ptr = NULL;
+ in_buffer_desc_ptr = NULL;
+ }
+
+ // Prepare output buffer.
+ out_buffer_desc.ulVersion = SECBUFFER_VERSION;
+ out_buffer_desc.cBuffers = 1;
+ out_buffer_desc.pBuffers = &out_buffer;
+ out_buffer.BufferType = SECBUFFER_TOKEN;
+ out_buffer.cbBuffer = max_token_len_;
+ out_buffer.pvBuffer = malloc(out_buffer.cbBuffer);
+ if (!out_buffer.pvBuffer)
+ return ERR_OUT_OF_MEMORY;
+
+ // Name of the destination server. NULL for NTLM.
+ SEC_WCHAR* target = NULL;
+
+ // This returns a token that is passed to the remote server.
+ status = InitializeSecurityContext(&cred_, // phCredential
+ ctxt_ptr, // phContext
+ target, // pszTargetName
+ 0, // fContextReq
+ 0, // Reserved1 (must be 0)
+ SECURITY_NATIVE_DREP, // TargetDataRep
+ in_buffer_desc_ptr, // pInput
+ 0, // Reserved2 (must be 0)
+ &ctxt_, // phNewContext
+ &out_buffer_desc, // pOutput
+ &ctxt_attr, // pfContextAttr
+ &expiry); // ptsExpiry
+ // On success, the function returns SEC_I_CONTINUE_NEEDED on the first call
+ // and SEC_E_OK on the second call. On failure, the function returns an
+ // error code.
+ if (status != SEC_I_CONTINUE_NEEDED && status != SEC_E_OK) {
+ LOG(ERROR) << "InitializeSecurityContext failed: " << status;
+ ResetSecurityContext();
+ free(out_buffer.pvBuffer);
+ return ERR_UNEXPECTED; // TODO(wtc): map error code.
+ }
+ if (!out_buffer.cbBuffer) {
+ free(out_buffer.pvBuffer);
+ out_buffer.pvBuffer = NULL;
+ }
+ *out_token = out_buffer.pvBuffer;
+ *out_token_len = out_buffer.cbBuffer;
+ return OK;
+}
+
+// Require identity on first pass instead of second.
+bool HttpAuthHandlerNTLM::NeedsIdentity() {
+ return auth_data_.empty();
+}
+
+bool HttpAuthHandlerNTLM::IsFinalRound() {
+ return !auth_data_.empty();
+}
+
+void HttpAuthHandlerNTLM::ResetSecurityContext() {
+ if (SecIsValidHandle(&ctxt_)) {
+ DeleteSecurityContext(&ctxt_);
+ SecInvalidateHandle(&ctxt_);
+ }
+}
+
+} // namespace net
+
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index f81b9e2..7f1495d 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -144,6 +144,7 @@ HttpNetworkTransaction::HttpNetworkTransaction(HttpNetworkSession* session,
proxy_mode_(kDirectConnection),
establishing_tunnel_(false),
reading_body_from_socket_(false),
+ embedded_identity_used_(false),
request_headers_(new RequestHeaders()),
request_headers_bytes_sent_(0),
header_buf_(new ResponseHeaders()),
@@ -253,6 +254,11 @@ void HttpNetworkTransaction::PrepareForAuthRestart(HttpAuth::Target target) {
// If auth_identity_[target].source is HttpAuth::IDENT_SRC_NONE,
// auth_identity_[target] contains no identity because identity is not
// required yet.
+ //
+ // TODO(wtc): For NTLM_SSPI, we add the same auth entry to the cache in
+ // round 1 and round 2, which is redundant but correct. It would be nice
+ // to add an auth entry to the cache only once, preferrably in round 1.
+ // See http://crbug.com/21015.
bool has_auth_identity =
auth_identity_[target].source != HttpAuth::IDENT_SRC_NONE;
if (has_auth_identity) {
@@ -280,6 +286,9 @@ void HttpNetworkTransaction::PrepareForAuthRestart(HttpAuth::Target target) {
// If the auth scheme is connection-based but the proxy/server mistakenly
// marks the connection as non-keep-alive, the auth is going to fail, so log
// an error message.
+ //
+ // TODO(wtc): has_auth_identity is not the right condition. We should
+ // be testing for "not round 1" here. See http://crbug.com/21015.
if (!keep_alive && auth_handler_[target]->is_connection_based() &&
has_auth_identity) {
LOG(ERROR) << "Can't perform " << auth_handler_[target]->scheme()
@@ -742,6 +751,9 @@ int HttpNetworkTransaction::DoWriteHeaders() {
std::string authorization_headers;
+ // TODO(wtc): If BuildAuthorizationHeader fails (returns an authorization
+ // header with no credentials), we should return an error to prevent
+ // entering an infinite auth restart loop. See http://crbug.com/21050.
if (have_proxy_auth)
authorization_headers.append(
BuildAuthorizationHeader(HttpAuth::AUTH_PROXY));
@@ -1779,16 +1791,15 @@ bool HttpNetworkTransaction::SelectNextAuthIdentityToTry(
DCHECK(auth_identity_[target].invalid);
// Try to use the username/password encoded into the URL first.
- // (By checking source == IDENT_SRC_NONE, we make sure that this
- // is only done once for the transaction.)
if (target == HttpAuth::AUTH_SERVER && request_->url.has_username() &&
- auth_identity_[target].source == HttpAuth::IDENT_SRC_NONE) {
+ !embedded_identity_used_) {
auth_identity_[target].source = HttpAuth::IDENT_SRC_URL;
auth_identity_[target].invalid = false;
// Extract the username:password from the URL.
GetIdentifyFromUrl(request_->url,
&auth_identity_[target].username,
&auth_identity_[target].password);
+ embedded_identity_used_ = true;
// TODO(eroman): If the password is blank, should we also try combining
// with a password from the cache?
return true;
@@ -1881,10 +1892,17 @@ int HttpNetworkTransaction::HandleAuthChallenge() {
return ERR_UNEXPECTED_PROXY_AUTH;
// The auth we tried just failed, hence it can't be valid. Remove it from
- // the cache so it won't be used again, unless it's a null identity.
- if (HaveAuth(target) &&
- auth_identity_[target].source != HttpAuth::IDENT_SRC_NONE)
+ // the cache so it won't be used again.
+ // TODO(wtc): IsFinalRound is not the right condition. In a multi-round
+ // auth sequence, the server may fail the auth in round 1 if our first
+ // authorization header is broken. We should inspect response_.headers to
+ // determine if the server already failed the auth or wants us to continue.
+ // See http://crbug.com/21015.
+ if (HaveAuth(target) && auth_handler_[target]->IsFinalRound()) {
InvalidateRejectedAuthFromCache(target);
+ auth_handler_[target] = NULL;
+ auth_identity_[target] = HttpAuth::Identity();
+ }
auth_identity_[target].invalid = true;
@@ -1919,14 +1937,11 @@ int HttpNetworkTransaction::HandleAuthChallenge() {
// If an identity to try is found, it is saved to auth_identity_[target].
SelectNextAuthIdentityToTry(target);
} else {
- // Proceed with a null identity.
+ // Proceed with the existing identity or a null identity.
//
// TODO(wtc): Add a safeguard against infinite transaction restarts, if
// the server keeps returning "NTLM".
- auth_identity_[target].source = HttpAuth::IDENT_SRC_NONE;
auth_identity_[target].invalid = false;
- auth_identity_[target].username.clear();
- auth_identity_[target].password.clear();
}
// Make a note that we are waiting for auth. This variable is inspected
diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h
index 86946f4..3ffad74 100644
--- a/net/http/http_network_transaction.h
+++ b/net/http/http_network_transaction.h
@@ -352,6 +352,11 @@ class HttpNetworkTransaction : public HttpTransaction {
// but it isn't really being used.
bool reading_body_from_socket_;
+ // True if we've used the username/password embedded in the URL. This
+ // makes sure we use the embedded identity only once for the transaction,
+ // preventing an infinite auth restart loop.
+ bool embedded_identity_used_;
+
SSLConfig ssl_config_;
scoped_refptr<RequestHeaders> request_headers_;
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index d63546d..dbe14e7 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -1501,6 +1501,10 @@ TEST_F(HttpNetworkTransactionTest, BasicAuthProxyThenServer) {
EXPECT_EQ(100, response->headers->GetContentLength());
}
+// For the NTLM implementation using SSPI, we skip the NTLM tests since we
+// can't hook into its internals to cause it to generate predictable NTLM
+// authorization headers.
+#if defined(NTLM_PORTABLE)
// The NTLM authentication unit tests were generated by capturing the HTTP
// requests and responses using Fiddler 2 and inspecting the generated random
// bytes in the debugger.
@@ -1829,6 +1833,7 @@ TEST_F(HttpNetworkTransactionTest, NTLMAuth2) {
EXPECT_TRUE(response->auth_challenge.get() == NULL);
EXPECT_EQ(13, response->headers->GetContentLength());
}
+#endif // NTLM_PORTABLE
// Test reading a server response which has only headers, and no body.
// After some maximum number of bytes is consumed, the transaction should
@@ -2132,7 +2137,7 @@ TEST_F(HttpNetworkTransactionTest, ResendRequestOnWriteBodyError) {
// Test the request-challenge-retry sequence for basic auth when there is
// an identity in the URL. The request should be sent as normal, but when
// it fails the identity from the URL is used to answer the challenge.
-TEST_F(HttpNetworkTransactionTest, AuthIdentityInUrl) {
+TEST_F(HttpNetworkTransactionTest, AuthIdentityInURL) {
SessionDependencies session_deps;
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(
@@ -2148,7 +2153,7 @@ TEST_F(HttpNetworkTransactionTest, AuthIdentityInUrl) {
// will need to be unescaped by HttpNetworkTransaction.
EXPECT_EQ("b%40r", request.url.password());
- request.load_flags = 0;
+ request.load_flags = LOAD_NORMAL;
MockWrite data_writes1[] = {
MockWrite("GET / HTTP/1.1\r\n"
@@ -2164,7 +2169,7 @@ TEST_F(HttpNetworkTransactionTest, AuthIdentityInUrl) {
};
// After the challenge above, the transaction will be restarted using the
- // identity from the url (foo, bar) to answer the challenge.
+ // identity from the url (foo, b@r) to answer the challenge.
MockWrite data_writes2[] = {
MockWrite("GET / HTTP/1.1\r\n"
"Host: www.google.com\r\n"
@@ -2211,6 +2216,119 @@ TEST_F(HttpNetworkTransactionTest, AuthIdentityInUrl) {
MessageLoop::current()->RunAllPending();
}
+// Test the request-challenge-retry sequence for basic auth when there is
+// an incorrect identity in the URL. The identity from the URL should be used
+// only once.
+TEST_F(HttpNetworkTransactionTest, WrongAuthIdentityInURL) {
+ SessionDependencies session_deps;
+ scoped_ptr<HttpTransaction> trans(
+ new HttpNetworkTransaction(
+ CreateSession(&session_deps),
+ &session_deps.socket_factory));
+
+ HttpRequestInfo request;
+ request.method = "GET";
+ // Note: the URL has a username:password in it. The password "baz" is
+ // wrong (should be "bar").
+ request.url = GURL("http://foo:baz@www.google.com/");
+
+ request.load_flags = LOAD_NORMAL;
+
+ MockWrite data_writes1[] = {
+ MockWrite("GET / HTTP/1.1\r\n"
+ "Host: www.google.com\r\n"
+ "Connection: keep-alive\r\n\r\n"),
+ };
+
+ MockRead data_reads1[] = {
+ MockRead("HTTP/1.0 401 Unauthorized\r\n"),
+ MockRead("WWW-Authenticate: Basic realm=\"MyRealm1\"\r\n"),
+ MockRead("Content-Length: 10\r\n\r\n"),
+ MockRead(false, ERR_FAILED),
+ };
+
+ // After the challenge above, the transaction will be restarted using the
+ // identity from the url (foo, baz) to answer the challenge.
+ MockWrite data_writes2[] = {
+ MockWrite("GET / HTTP/1.1\r\n"
+ "Host: www.google.com\r\n"
+ "Connection: keep-alive\r\n"
+ "Authorization: Basic Zm9vOmJheg==\r\n\r\n"),
+ };
+
+ MockRead data_reads2[] = {
+ MockRead("HTTP/1.0 401 Unauthorized\r\n"),
+ MockRead("WWW-Authenticate: Basic realm=\"MyRealm1\"\r\n"),
+ MockRead("Content-Length: 10\r\n\r\n"),
+ MockRead(false, ERR_FAILED),
+ };
+
+ // After the challenge above, the transaction will be restarted using the
+ // identity supplied by the user (foo, bar) to answer the challenge.
+ MockWrite data_writes3[] = {
+ MockWrite("GET / HTTP/1.1\r\n"
+ "Host: www.google.com\r\n"
+ "Connection: keep-alive\r\n"
+ "Authorization: Basic Zm9vOmJhcg==\r\n\r\n"),
+ };
+
+ MockRead data_reads3[] = {
+ MockRead("HTTP/1.0 200 OK\r\n"),
+ MockRead("Content-Length: 100\r\n\r\n"),
+ MockRead(false, OK),
+ };
+
+ StaticMockSocket data1(data_reads1, data_writes1);
+ StaticMockSocket data2(data_reads2, data_writes2);
+ StaticMockSocket data3(data_reads3, data_writes3);
+ session_deps.socket_factory.AddMockSocket(&data1);
+ session_deps.socket_factory.AddMockSocket(&data2);
+ session_deps.socket_factory.AddMockSocket(&data3);
+
+ TestCompletionCallback callback1;
+
+ int rv = trans->Start(&request, &callback1, NULL);
+ EXPECT_EQ(ERR_IO_PENDING, rv);
+
+ rv = callback1.WaitForResult();
+ EXPECT_EQ(OK, rv);
+
+ EXPECT_TRUE(trans->IsReadyToRestartForAuth());
+ TestCompletionCallback callback2;
+ rv = trans->RestartWithAuth(std::wstring(), std::wstring(), &callback2);
+ EXPECT_EQ(ERR_IO_PENDING, rv);
+ rv = callback2.WaitForResult();
+ EXPECT_EQ(OK, rv);
+ EXPECT_FALSE(trans->IsReadyToRestartForAuth());
+
+ const HttpResponseInfo* response = trans->GetResponseInfo();
+ EXPECT_FALSE(response == NULL);
+ // The password prompt info should have been set in response->auth_challenge.
+ EXPECT_FALSE(response->auth_challenge.get() == NULL);
+
+ EXPECT_EQ(L"www.google.com:80", response->auth_challenge->host_and_port);
+ EXPECT_EQ(L"MyRealm1", response->auth_challenge->realm);
+ EXPECT_EQ(L"basic", response->auth_challenge->scheme);
+
+ TestCompletionCallback callback3;
+ rv = trans->RestartWithAuth(L"foo", L"bar", &callback3);
+ EXPECT_EQ(ERR_IO_PENDING, rv);
+ rv = callback3.WaitForResult();
+ EXPECT_EQ(OK, rv);
+ EXPECT_FALSE(trans->IsReadyToRestartForAuth());
+
+ response = trans->GetResponseInfo();
+ EXPECT_FALSE(response == NULL);
+
+ // There is no challenge info, since the identity worked.
+ EXPECT_TRUE(response->auth_challenge.get() == NULL);
+
+ EXPECT_EQ(100, response->headers->GetContentLength());
+
+ // Empty the current queue.
+ MessageLoop::current()->RunAllPending();
+}
+
// Test that previously tried username/passwords for a realm get re-used.
TEST_F(HttpNetworkTransactionTest, BasicAuthCacheAndPreauth) {
SessionDependencies session_deps;