diff options
| author | vandebo@google.com <vandebo@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-04 21:25:33 +0000 |
|---|---|---|
| committer | vandebo@google.com <vandebo@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-04 21:25:33 +0000 |
| commit | 95d88ffe2faa5ccceb1c4619f4e316fb7ad4d70f (patch) | |
| tree | db13d8ae72b1e28783fa0571b08e31b4b65c8358 /net/net.gyp | |
| parent | 268b02fa13ca56e7b32f0b6a445ce5758a1dfc3c (diff) | |
| download | chromium_src-95d88ffe2faa5ccceb1c4619f4e316fb7ad4d70f.zip chromium_src-95d88ffe2faa5ccceb1c4619f4e316fb7ad4d70f.tar.gz chromium_src-95d88ffe2faa5ccceb1c4619f4e316fb7ad4d70f.tar.bz2 | |
Add a notion of 'eof' to UploadDataStream, replacing the use of its size property for detecting when an upload is finished.
While this does prevent the crash described in the bug from occurring, this doesn't fully solve the problem as now the affected uploads don't complete. Fully resolving the issue will require implementing the chunked transfer encoding for requests.
Patch from Vernon Tang <vt@foilhead.net>, original review: http://codereview.chromium.org/555194
BUG=33501
TEST=Create a file with a non-zero size and select that file in an HTML-based uploader. Before starting the upload, remove read permissions from that file. Check that the upload doesn't cause the browser to crash or hang. net_unittests: HttpNetworkTransactionTest.UploadFileSmallerThanLength, UploadDataStreamTest.*
Review URL: http://codereview.chromium.org/578004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38129 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/net.gyp')
| -rwxr-xr-x | net/net.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/net.gyp b/net/net.gyp index b1645d5..3f63d82 100755 --- a/net/net.gyp +++ b/net/net.gyp @@ -611,6 +611,7 @@ 'base/telnet_server_unittest.cc', 'base/test_certificate_data.h', 'base/test_completion_callback_unittest.cc', + 'base/upload_data_stream_unittest.cc', 'base/x509_certificate_unittest.cc', 'disk_cache/addr_unittest.cc', 'disk_cache/backend_unittest.cc', |