diff options
| author | gavinp@chromium.org <gavinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-13 20:45:21 +0000 |
|---|---|---|
| committer | gavinp@chromium.org <gavinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-13 20:45:21 +0000 |
| commit | 9d337bc7383bef4366f949b08867ba4fa9b874a9 (patch) | |
| tree | 86e5c8130aa9d9b7c71138f4ce3d39f18d0a5076 /net/net.gyp | |
| parent | 1477ef4c522c910b5f1933f6ebf095e8d9f4d8d7 (diff) | |
| download | chromium_src-9d337bc7383bef4366f949b08867ba4fa9b874a9.zip chromium_src-9d337bc7383bef4366f949b08867ba4fa9b874a9.tar.gz chromium_src-9d337bc7383bef4366f949b08867ba4fa9b874a9.tar.bz2 | |
Clean up dependencies for disk_cache histogram_macros.h.
The current mechanism by which these convenience macros find their
backend is confusing, at best; the macro has the form of our include
guard macros, but describes a CC file. Embedded within the
histogram_macros.h then is an abstraction violation: it just knows
which object has backend information depending on which file it was
included from.
Some downstream reviews have made this even more confusing; rather
than continue this, let's parameterize the backend object to the
convenience macros, so each translation unit is responsible for
knowing its own context.
R=mmenke@chromium.org, rvargas@chromium.org
TBR=mmenke@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/140893013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251116 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/net.gyp')
| -rw-r--r-- | net/net.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/net.gyp b/net/net.gyp index 308c98d..348c134 100644 --- a/net/net.gyp +++ b/net/net.gyp @@ -457,6 +457,7 @@ 'disk_cache/v3/entry_impl_v3.h', 'disk_cache/v3/eviction_v3.cc', 'disk_cache/v3/eviction_v3.h', + 'disk_cache/v3/histogram_macros.h', 'disk_cache/v3/index_table.cc', 'disk_cache/v3/index_table.h', 'dns/address_sorter.h', |