diff options
| author | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-18 23:26:29 +0000 |
|---|---|---|
| committer | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-18 23:26:29 +0000 |
| commit | b96fc5dc177d311db220dc4039e74a9c0d871558 (patch) | |
| tree | 9bbc6ea3af7c0da75d4b6025d4b475dd62eec0b2 /net/net.scons | |
| parent | db8635032b1f83436a072be14e425076a7bd8164 (diff) | |
| download | chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.zip chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.gz chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.bz2 | |
Convert from using env['PLATFORM'] directly to using the more flexible
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/net.scons')
| -rw-r--r-- | net/net.scons | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/net.scons b/net/net.scons index cc22d36..7f5f115b 100644 --- a/net/net.scons +++ b/net/net.scons @@ -23,7 +23,7 @@ sconscript_files = [ 'stress_cache.scons', ] -if env['PLATFORM'] in ('posix', 'darwin'): +if env.Bit('posix'): # Remove *.scons files whose targets still need to be ported. # TODO(port): delete files from this list as they get ported. to_be_ported = [ @@ -32,7 +32,7 @@ if env['PLATFORM'] in ('posix', 'darwin'): for remove in to_be_ported: sconscript_files.remove(remove) -if env['PLATFORM'] == 'win32': +if env.Bit('windows'): # TODO: We need to port tld_cleanup before this will work on other # platforms. sconscript_files.extend([ |