diff options
author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-17 04:10:29 +0000 |
---|---|---|
committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-17 04:10:29 +0000 |
commit | e9b8d0afc364a922a064ac88ad656fcec6c703de (patch) | |
tree | 80df5497880f9155d700ab5acd7b0dd5ff2008f1 /net/proxy/polling_proxy_config_service.h | |
parent | 754cf1378f28f3a5787bbb856b39d9fb64365a50 (diff) | |
download | chromium_src-e9b8d0afc364a922a064ac88ad656fcec6c703de.zip chromium_src-e9b8d0afc364a922a064ac88ad656fcec6c703de.tar.gz chromium_src-e9b8d0afc364a922a064ac88ad656fcec6c703de.tar.bz2 |
Watch the Internet Explorer registry keys so we can detect proxy settings changes faster.
Previously we would poll on a background thread every 5 seconds (triggered by network activity) to check for changes. This meant there was a 5 second window during which new requests might still be using the old settings.
With this CL, the settings are noticed almost immediately and the continuous polling is de-emphasized.
(We still poll, but less often. This is a precaution since we are relying on implementation details of a winhttp function, and can't be sure it won't change in the future, or is even completely accurate right now).
BUG=52120
TEST=Open chrome://net-internals/#requests. Request some webpage. Now make changes to the Internet explorer proxy settinsg. You should see a PROXY_CONFIG_CHANGED event emitted immediately after saving each change in the dialog box.
Review URL: http://codereview.chromium.org/3161016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56305 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy/polling_proxy_config_service.h')
-rw-r--r-- | net/proxy/polling_proxy_config_service.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/proxy/polling_proxy_config_service.h b/net/proxy/polling_proxy_config_service.h index 455359a..b4295ec 100644 --- a/net/proxy/polling_proxy_config_service.h +++ b/net/proxy/polling_proxy_config_service.h @@ -40,6 +40,9 @@ class PollingProxyConfigService : public ProxyConfigService { virtual ~PollingProxyConfigService(); + // Polls for changes by posting a task to the worker pool. + void CheckForChangesNow(); + private: class Core; scoped_refptr<Core> core_; |