diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-28 19:28:09 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-28 19:28:09 +0000 |
| commit | ec11be60eaf6e832219328ea18656c558dec3040 (patch) | |
| tree | 1d8a6710f277a55b4743fbc54c8554abf3164669 /net/proxy/proxy_resolver_v8.cc | |
| parent | 9bb75ccc56cdb94a9778dcef26be3de97808f3ce (diff) | |
| download | chromium_src-ec11be60eaf6e832219328ea18656c558dec3040.zip chromium_src-ec11be60eaf6e832219328ea18656c558dec3040.tar.gz chromium_src-ec11be60eaf6e832219328ea18656c558dec3040.tar.bz2 | |
More cleanup to address TODOs in net_log.h.
* Removes 9 methods: AddEventWithParameters, BeginEventWithParameters, EndEventWithParameters, BeginEventWithString, BeginEventWithInteger, AddEventWithString, AddEventWithInteger, EndEventWithParameters, EndEventWithInteger. This was becoming ridiculous, instead made the EventParameters* a required parameter.
* Moves CapturingBoundNetLog / CapturingNetLog to its own file.
BUG=37421
Review URL: http://codereview.chromium.org/1746012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45843 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy/proxy_resolver_v8.cc')
| -rw-r--r-- | net/proxy/proxy_resolver_v8.cc | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc index 8734dff..17916e6 100644 --- a/net/proxy/proxy_resolver_v8.cc +++ b/net/proxy/proxy_resolver_v8.cc @@ -294,14 +294,14 @@ class ProxyResolverV8::Context { static_cast<Context*>(v8::External::Cast(*args.Data())->Value()); context->current_request_net_log_.BeginEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS); + NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS, NULL); // We shouldn't be called with any arguments, but will not complain if // we are. std::string result = context->js_bindings_->MyIpAddress(); context->current_request_net_log_.EndEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS); + NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS, NULL); if (result.empty()) result = "127.0.0.1"; @@ -315,14 +315,14 @@ class ProxyResolverV8::Context { static_cast<Context*>(v8::External::Cast(*args.Data())->Value()); context->current_request_net_log_.BeginEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS_EX); + NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS_EX, NULL); // We shouldn't be called with any arguments, but will not complain if // we are. std::string result = context->js_bindings_->MyIpAddressEx(); context->current_request_net_log_.EndEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS_EX); + NetLog::TYPE_PROXY_RESOLVER_V8_MY_IP_ADDRESS_EX, NULL); return StdStringToV8String(result); } @@ -342,12 +342,12 @@ class ProxyResolverV8::Context { } context->current_request_net_log_.BeginEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE); + NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE, NULL); std::string result = context->js_bindings_->DnsResolve(host); context->current_request_net_log_.EndEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE); + NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE, NULL); // DnsResolve() returns empty string on failure. return result.empty() ? v8::Null() : StdStringToV8String(result); @@ -368,12 +368,12 @@ class ProxyResolverV8::Context { } context->current_request_net_log_.BeginEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE_EX); + NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE_EX, NULL); std::string result = context->js_bindings_->DnsResolveEx(host); context->current_request_net_log_.EndEvent( - NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE_EX); + NetLog::TYPE_PROXY_RESOLVER_V8_DNS_RESOLVE_EX, NULL); return StdStringToV8String(result); } |