diff options
author | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-21 22:03:00 +0000 |
---|---|---|
committer | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-21 22:03:00 +0000 |
commit | 71e4573a9ff241416f5cfc375dabec8b72c85e3c (patch) | |
tree | d6e52e21cd940aef48dc37e9094ba9d66bd6431f /net/proxy/proxy_service.cc | |
parent | b360895e1e4ba2db735f82d85563a631e1cc0c5b (diff) | |
download | chromium_src-71e4573a9ff241416f5cfc375dabec8b72c85e3c.zip chromium_src-71e4573a9ff241416f5cfc375dabec8b72c85e3c.tar.gz chromium_src-71e4573a9ff241416f5cfc375dabec8b72c85e3c.tar.bz2 |
Changes the UI for HTTP/FTP auth challenges to include the server's port. So instead of "www.foo.com" it will say "www.foo.com:80". We need to include the port number since otherwise it can be ambiguous what the actual target server is.
This change also introduces utility function "GetHostAnd[Optional]Port()" to help with forming <host> [":" <port>] strings.
BUG=12073
Review URL: http://codereview.chromium.org/112041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16672 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy/proxy_service.cc')
-rw-r--r-- | net/proxy/proxy_service.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc index d172f92..0c2828b 100644 --- a/net/proxy/proxy_service.cc +++ b/net/proxy/proxy_service.cc @@ -609,6 +609,7 @@ bool ProxyService::ShouldBypassProxyForURL(const GURL& url) { // percent-encoded characters. StringToLowerASCII(&url_domain); + // TODO(eroman): use GetHostAndPort(). std::string url_domain_and_port = url_domain + ":" + IntToString(url.EffectiveIntPort()); |