Add a command line flag --v8-proxy-resolver, to select the new PAC implementation.

When running in single process mode, this flag has no effect (since we can't run side by side with the renderer's V8).

In regular mode, the v8 resolver is currently running in the browser process.
This means it has to share with the v8 debugger shell.
Added locking around the debugger shell so they can peacefully co-exist.

When this flag is enabled, PAC scripts are downloaded through the browser.

BUG=74,2764

Review URL: http://codereview.chromium.org/27365

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10827 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 18 insertions, 3 deletions

diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h
index 21b0e07..cb1fc91 100644
--- a/net/proxy/proxy_service.h
+++ b/net/proxy/proxy_service.h
@@ -17,6 +17,7 @@
 #include "net/proxy/proxy_info.h"
 
 class GURL;
+class URLRequestContext;
 
 namespace net {
 
@@ -80,17 +81,31 @@ class ProxyService {
   // Call this method with a non-null |pac_request| to cancel the PAC request.
   void CancelPacRequest(PacRequest* pac_request);
 
-  // Set the ProxyScriptFetcher dependency. This is needed if the ProxyResolver
+  // Sets the ProxyScriptFetcher dependency. This is needed if the ProxyResolver
   // is of type ProxyResolverWithoutFetch. ProxyService takes ownership of
   // |proxy_script_fetcher|.
   void SetProxyScriptFetcher(ProxyScriptFetcher* proxy_script_fetcher);
 
-  // Create a proxy service using the specified settings. If |pi| is NULL then
+  // Creates a proxy service using the specified settings. If |pi| is NULL then
   // the system's default proxy settings will be used (on Windows this will
   // use IE's settings).
   static ProxyService* Create(const ProxyInfo* pi);
 
-  // Create a proxy service that always fails to fetch the proxy configuration,
+  // Creates a proxy service using the specified settings. If |pi| is NULL then
+  // the system's default proxy settings will be used. This is basically the
+  // same as Create(const ProxyInfo*), however under the hood it uses a
+  // different implementation (V8). |url_request_context| is the URL request
+  // context that will be used if a PAC script needs to be fetched.
+  // ##########################################################################
+  // # See the warnings in net/proxy/proxy_resolver_v8.h describing the
+  // # multi-threading model. In order for this to be safe to use, *ALL* the
+  // # other V8's running in the process must use v8::Locker.
+  // ##########################################################################
+  static ProxyService* CreateUsingV8Resolver(
+      const ProxyInfo* pi,
+      URLRequestContext* url_request_context);
+
+  // Creates a proxy service that always fails to fetch the proxy configuration,
   // so it falls back to direct connect.
   static ProxyService* CreateNull();