diff options
author | iyengar@google.com <iyengar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-23 00:57:19 +0000 |
---|---|---|
committer | iyengar@google.com <iyengar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-23 00:57:19 +0000 |
commit | b8afeda43b66094543efe04ae727bf619c1f5cf3 (patch) | |
tree | 0e928237955d260c42c95ed89eaec69866548b0d /net/proxy/proxy_service_unittest.cc | |
parent | d78c52db36b559b0860334cd39d7637ed348f87a (diff) | |
download | chromium_src-b8afeda43b66094543efe04ae727bf619c1f5cf3.zip chromium_src-b8afeda43b66094543efe04ae727bf619c1f5cf3.tar.gz chromium_src-b8afeda43b66094543efe04ae727bf619c1f5cf3.tar.bz2 |
This fixes http://code.google.com/p/chromium/issues/detail?id=541, which is an
issue with the proxy exception list not being honored if individual rules had
uppercase characters in them.
The code to match the url with the exceptions was converting both to lowercase.
However there was an error in the way the StringToLowerASCII function was used.
Bug=541
Review URL: http://codereview.chromium.org/4019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2466 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy/proxy_service_unittest.cc')
-rw-r--r-- | net/proxy/proxy_service_unittest.cc | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/net/proxy/proxy_service_unittest.cc b/net/proxy/proxy_service_unittest.cc index 5731955..d33ac6d 100644 --- a/net/proxy/proxy_service_unittest.cc +++ b/net/proxy/proxy_service_unittest.cc @@ -341,6 +341,22 @@ TEST(ProxyServiceTest, ProxyBypassList) { rv = service4.ResolveProxy(test_url4, &info4, NULL, NULL); EXPECT_EQ(rv, net::OK); EXPECT_FALSE(info4.is_direct()); + + resolver.config->proxy_bypass = "<local>;*.MSN.COM;"; + net::ProxyService service5(&resolver); + GURL test_url5("http://www.msnbc.msn.com"); + net::ProxyInfo info5; + rv = service5.ResolveProxy(test_url5, &info5, NULL, NULL); + EXPECT_EQ(rv, net::OK); + EXPECT_TRUE(info5.is_direct()); + + resolver.config->proxy_bypass = "<local>;*.msn.com;"; + net::ProxyService service6(&resolver); + GURL test_url6("HTTP://WWW.MSNBC.MSN.COM"); + net::ProxyInfo info6; + rv = service6.ResolveProxy(test_url6, &info6, NULL, NULL); + EXPECT_EQ(rv, net::OK); + EXPECT_TRUE(info6.is_direct()); } TEST(ProxyServiceTest, PerProtocolProxyTests) { |