summaryrefslogtreecommitdiffstats
path: root/net/proxy
diff options
context:
space:
mode:
authordarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-23 19:10:23 +0000
committerdarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-23 19:10:23 +0000
commit195e77d6f2d2f615c2a5138750db124853c0a093 (patch)
treee1ea14d75832faa10ca8951e82c44a1e4b1a03ab /net/proxy
parent35350e871b173b3daa1e6e9921e1930ecc9331c4 (diff)
downloadchromium_src-195e77d6f2d2f615c2a5138750db124853c0a093.zip
chromium_src-195e77d6f2d2f615c2a5138750db124853c0a093.tar.gz
chromium_src-195e77d6f2d2f615c2a5138750db124853c0a093.tar.bz2
Add support to URLRequest for deferring redirects.
I chose to add an out parameter to OnReceivedRedirect because it allows for the default behavior to remain the same. I considered adding a ContinueAfterRedirect method that all OnReceivedRedirect implementations would need to call, but this caused one annoying problem: In the case of a ChromePlugin, it is possible for the URLRequest to get deleted inside the handler for the redirect. This would make it hard to subsequently call a method on the URLRequest since I would need to have a way to determine if the URLRequest had been deleted. TEST=covered by unit tests BUG=16413,6442 R=eroman,wtc Review URL: http://codereview.chromium.org/155897 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21417 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
-rw-r--r--net/proxy/proxy_script_fetcher.cc7
1 files changed, 0 insertions, 7 deletions
diff --git a/net/proxy/proxy_script_fetcher.cc b/net/proxy/proxy_script_fetcher.cc
index ec0c8b1..eecff19 100644
--- a/net/proxy/proxy_script_fetcher.cc
+++ b/net/proxy/proxy_script_fetcher.cc
@@ -67,7 +67,6 @@ class ProxyScriptFetcherImpl : public ProxyScriptFetcher,
AuthChallengeInfo* auth_info);
virtual void OnSSLCertificateError(URLRequest* request, int cert_error,
X509Certificate* cert);
- virtual void OnReceivedRedirect(URLRequest* request, const GURL& to_url);
virtual void OnResponseStarted(URLRequest* request);
virtual void OnReadCompleted(URLRequest* request, int num_bytes);
virtual void OnResponseCompleted(URLRequest* request);
@@ -199,12 +198,6 @@ void ProxyScriptFetcherImpl::OnSSLCertificateError(URLRequest* request,
request->Cancel();
}
-void ProxyScriptFetcherImpl::OnReceivedRedirect(URLRequest* request,
- const GURL& to_url) {
- DCHECK(request == cur_request_.get());
- // OK, thanks for telling.
-}
-
void ProxyScriptFetcherImpl::OnResponseStarted(URLRequest* request) {
DCHECK(request == cur_request_.get());