diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-25 02:25:06 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-25 02:25:06 +0000 |
commit | d8eb842474ce559113a9b0ead0610973985bf693 (patch) | |
tree | 817d637b7bfffa8bebe3d1de0af0aea05d72a8a7 /net/proxy | |
parent | 928930d76cb018b8a496dbdf7166178ef8fab1bf (diff) | |
download | chromium_src-d8eb842474ce559113a9b0ead0610973985bf693.zip chromium_src-d8eb842474ce559113a9b0ead0610973985bf693.tar.gz chromium_src-d8eb842474ce559113a9b0ead0610973985bf693.tar.bz2 |
net: Append base:: in the StringPrintf calls.
(Note: This is a TODO in string_util.h)
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3390026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60555 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
-rw-r--r-- | net/proxy/multi_threaded_proxy_resolver.cc | 3 | ||||
-rw-r--r-- | net/proxy/multi_threaded_proxy_resolver_unittest.cc | 9 | ||||
-rw-r--r-- | net/proxy/proxy_bypass_rules_unittest.cc | 3 | ||||
-rw-r--r-- | net/proxy/proxy_config_service_linux_unittest.cc | 15 | ||||
-rw-r--r-- | net/proxy/proxy_resolver_v8_unittest.cc | 5 |
5 files changed, 20 insertions, 15 deletions
diff --git a/net/proxy/multi_threaded_proxy_resolver.cc b/net/proxy/multi_threaded_proxy_resolver.cc index 69e9ef7..95071b1 100644 --- a/net/proxy/multi_threaded_proxy_resolver.cc +++ b/net/proxy/multi_threaded_proxy_resolver.cc @@ -6,6 +6,7 @@ #include "base/message_loop.h" #include "base/string_util.h" +#include "base/stringprintf.h" #include "base/thread.h" #include "net/base/capturing_net_log.h" #include "net/base/net_errors.h" @@ -315,7 +316,7 @@ MultiThreadedProxyResolver::Executor::Executor( // Note that it is safe to pass a temporary C-String to Thread(), as it will // make a copy. std::string thread_name = - StringPrintf("PAC thread #%d", thread_number); + base::StringPrintf("PAC thread #%d", thread_number); thread_.reset(new base::Thread(thread_name.c_str())); thread_->Start(); } diff --git a/net/proxy/multi_threaded_proxy_resolver_unittest.cc b/net/proxy/multi_threaded_proxy_resolver_unittest.cc index f06fdea..7027161 100644 --- a/net/proxy/multi_threaded_proxy_resolver_unittest.cc +++ b/net/proxy/multi_threaded_proxy_resolver_unittest.cc @@ -6,12 +6,13 @@ #include "base/stl_util-inl.h" #include "base/string_util.h" +#include "base/stringprintf.h" #include "base/utf_string_conversions.h" #include "base/waitable_event.h" #include "googleurl/src/gurl.h" +#include "net/base/net_errors.h" #include "net/base/net_log.h" #include "net/base/net_log_unittest.h" -#include "net/base/net_errors.h" #include "net/base/test_completion_callback.h" #include "net/proxy/proxy_info.h" #include "testing/gtest/include/gtest/gtest.h" @@ -619,8 +620,8 @@ TEST(MultiThreadedProxyResolverTest, ThreeThreads_Basic) { for (int i = 1; i < kNumRequests; ++i) { rv = resolver.GetProxyForURL( - GURL(StringPrintf("http://request%d", i)), &results[i], &callback[i], - &request[i], BoundNetLog()); + GURL(base::StringPrintf("http://request%d", i)), &results[i], + &callback[i], &request[i], BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); } @@ -725,7 +726,7 @@ TEST(MultiThreadedProxyResolverTest, OneThreadBlocked) { for (int i = 1; i < kNumRequests; ++i) { rv = resolver.GetProxyForURL( - GURL(StringPrintf("http://request%d", i)), + GURL(base::StringPrintf("http://request%d", i)), &results[i], &callback[i], &request[i], BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); } diff --git a/net/proxy/proxy_bypass_rules_unittest.cc b/net/proxy/proxy_bypass_rules_unittest.cc index 208f9cd..5b6ce04 100644 --- a/net/proxy/proxy_bypass_rules_unittest.cc +++ b/net/proxy/proxy_bypass_rules_unittest.cc @@ -5,6 +5,7 @@ #include "net/proxy/proxy_bypass_rules.h" #include "base/string_util.h" +#include "base/stringprintf.h" #include "net/proxy/proxy_config_service_common_unittest.h" #include "testing/gtest/include/gtest/gtest.h" @@ -275,7 +276,7 @@ TEST(ProxyBypassRulesTest, BypassLocalNames) { rules.ParseFromString("<local>"); for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) { - SCOPED_TRACE(StringPrintf( + SCOPED_TRACE(base::StringPrintf( "Test[%d]: %s", static_cast<int>(i), tests[i].url)); EXPECT_EQ(tests[i].expected_is_local, rules.Matches(GURL(tests[i].url))); } diff --git a/net/proxy/proxy_config_service_linux_unittest.cc b/net/proxy/proxy_config_service_linux_unittest.cc index 0a541c1..41fe7d2 100644 --- a/net/proxy/proxy_config_service_linux_unittest.cc +++ b/net/proxy/proxy_config_service_linux_unittest.cc @@ -13,6 +13,7 @@ #include "base/format_macros.h" #include "base/logging.h" #include "base/string_util.h" +#include "base/stringprintf.h" #include "base/task.h" #include "base/thread.h" #include "base/waitable_event.h" @@ -376,7 +377,7 @@ class ProxyConfigServiceLinuxTest : public PlatformTest { }; // Builds an identifier for each test in an array. -#define TEST_DESC(desc) StringPrintf("at line %d <%s>", __LINE__, desc) +#define TEST_DESC(desc) base::StringPrintf("at line %d <%s>", __LINE__, desc) TEST_F(ProxyConfigServiceLinuxTest, BasicGConfTest) { std::vector<std::string> empty_ignores; @@ -605,8 +606,8 @@ TEST_F(ProxyConfigServiceLinuxTest, BasicGConfTest) { }; for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) { - SCOPED_TRACE(StringPrintf("Test[%" PRIuS "] %s", i, - tests[i].description.c_str())); + SCOPED_TRACE(base::StringPrintf("Test[%" PRIuS "] %s", i, + tests[i].description.c_str())); MockEnvironment* env = new MockEnvironment; MockGConfSettingGetter* gconf_getter = new MockGConfSettingGetter; SynchConfigGetter sync_config_getter( @@ -895,8 +896,8 @@ TEST_F(ProxyConfigServiceLinuxTest, BasicEnvTest) { }; for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) { - SCOPED_TRACE(StringPrintf("Test[%" PRIuS "] %s", i, - tests[i].description.c_str())); + SCOPED_TRACE(base::StringPrintf("Test[%" PRIuS "] %s", i, + tests[i].description.c_str())); MockEnvironment* env = new MockEnvironment; MockGConfSettingGetter* gconf_getter = new MockGConfSettingGetter; SynchConfigGetter sync_config_getter( @@ -1292,8 +1293,8 @@ TEST_F(ProxyConfigServiceLinuxTest, KDEConfigParser) { }; for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) { - SCOPED_TRACE(StringPrintf("Test[%" PRIuS "] %s", i, - tests[i].description.c_str())); + SCOPED_TRACE(base::StringPrintf("Test[%" PRIuS "] %s", i, + tests[i].description.c_str())); MockEnvironment* env = new MockEnvironment; env->values = tests[i].env_values; // Force the KDE getter to be used and tell it where the test is. diff --git a/net/proxy/proxy_resolver_v8_unittest.cc b/net/proxy/proxy_resolver_v8_unittest.cc index f0bfa1d..9e4a5d7 100644 --- a/net/proxy/proxy_resolver_v8_unittest.cc +++ b/net/proxy/proxy_resolver_v8_unittest.cc @@ -5,6 +5,7 @@ #include "base/file_util.h" #include "base/path_service.h" #include "base/string_util.h" +#include "base/stringprintf.h" #include "base/utf_string_conversions.h" #include "googleurl/src/gurl.h" #include "net/base/net_errors.h" @@ -276,7 +277,7 @@ TEST(ProxyResolverV8Test, SideEffects) { result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, BoundNetLog()); EXPECT_EQ(OK, result); - EXPECT_EQ(StringPrintf("sideffect_%d:80", i), + EXPECT_EQ(base::StringPrintf("sideffect_%d:80", i), proxy_info.proxy_server().ToURI()); } @@ -290,7 +291,7 @@ TEST(ProxyResolverV8Test, SideEffects) { result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, BoundNetLog()); EXPECT_EQ(OK, result); - EXPECT_EQ(StringPrintf("sideffect_%d:80", i), + EXPECT_EQ(base::StringPrintf("sideffect_%d:80", i), proxy_info.proxy_server().ToURI()); } } |