diff options
| author | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-19 07:28:46 +0000 |
|---|---|---|
| committer | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-19 07:28:46 +0000 |
| commit | e06f4d5c6bd7bad162c45784e39cd0114635eb42 (patch) | |
| tree | e53d6b4188af6e49393babc92a797ed5734a1026 /net/proxy | |
| parent | 2b107a348f2b27934fe38680ec8010d743f61765 (diff) | |
| download | chromium_src-e06f4d5c6bd7bad162c45784e39cd0114635eb42.zip chromium_src-e06f4d5c6bd7bad162c45784e39cd0114635eb42.tar.gz chromium_src-e06f4d5c6bd7bad162c45784e39cd0114635eb42.tar.bz2 | |
Regkey functions return error code instead of bool
Change the Regkey helper to consistently use and return LONG
instead of bool. Fix RegKey usage all over the code base and
get rid of workarounds due to lack of return value.
Reviewers:
brettw: everything (skip parts for other reviewers if you wish)
robertshield,grt: chrome_frame, installer
siggi: ceee
BUG=none
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/6090006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
| -rw-r--r-- | net/proxy/proxy_config_service_win.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/proxy/proxy_config_service_win.cc b/net/proxy/proxy_config_service_win.cc index 849fc24..3c2fbff 100644 --- a/net/proxy/proxy_config_service_win.cc +++ b/net/proxy/proxy_config_service_win.cc @@ -42,7 +42,7 @@ class ProxyConfigServiceWin::KeyEntry { bool StartWatching(base::win::ObjectWatcher::Delegate* delegate) { // Try to create a watch event for the registry key (which watches the // sibling tree as well). - if (!key_.StartWatching()) + if (key_.StartWatching() != ERROR_SUCCESS) return false; // Now setup an ObjectWatcher for this event, so we get OnObjectSignaled() @@ -54,7 +54,7 @@ class ProxyConfigServiceWin::KeyEntry { } bool CreateRegKey(HKEY rootkey, const wchar_t* subkey) { - return key_.Create(rootkey, subkey, KEY_NOTIFY); + return key_.Create(rootkey, subkey, KEY_NOTIFY) == ERROR_SUCCESS; } HANDLE watch_event() const { |