diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 03:34:25 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 03:34:25 +0000 |
| commit | e9032c6a2ea03e4a5081e0234eff857cf190e3e4 (patch) | |
| tree | a9e6ec385829730bc9442579c2fef525d1caf71e /net/proxy | |
| parent | 3e108342206210d64d81368044d9503445a1a1f3 (diff) | |
| download | chromium_src-e9032c6a2ea03e4a5081e0234eff857cf190e3e4.zip chromium_src-e9032c6a2ea03e4a5081e0234eff857cf190e3e4.tar.gz chromium_src-e9032c6a2ea03e4a5081e0234eff857cf190e3e4.tar.bz2 | |
base: Return bool instead of void in EnvVarGetter::SetEnv.
Returning bool instead of void in this function is better, because with that
we can know if we had succeeded when tried to set an environment variable or not.
Also it makes this function more testable.
BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.*
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2891024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52602 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
| -rw-r--r-- | net/proxy/proxy_config_service_linux_unittest.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/proxy/proxy_config_service_linux_unittest.cc b/net/proxy/proxy_config_service_linux_unittest.cc index ca9835b..0a84548 100644 --- a/net/proxy/proxy_config_service_linux_unittest.cc +++ b/net/proxy/proxy_config_service_linux_unittest.cc @@ -114,9 +114,11 @@ class MockEnvVarGetter : public base::EnvVarGetter { return false; } - virtual void SetEnv(const char* variable_name, const std::string& new_value) { + virtual bool SetEnv(const char* variable_name, const std::string& new_value) { NOTIMPLEMENTED(); + return false; } + // Intentionally public, for convenience when setting up a test. EnvVarValues values; |