diff options
| author | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-04 16:11:14 +0000 |
|---|---|---|
| committer | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-04 16:11:14 +0000 |
| commit | e1907b43c884de50be2c55e19831c9028703b7b5 (patch) | |
| tree | 463c1d53213b27ff4d4f66def23a7acf6104353b /net/proxy | |
| parent | 5d8e0f506ebbd0f0c80f880488d054d75e7cc844 (diff) | |
| download | chromium_src-e1907b43c884de50be2c55e19831c9028703b7b5.zip chromium_src-e1907b43c884de50be2c55e19831c9028703b7b5.tar.gz chromium_src-e1907b43c884de50be2c55e19831c9028703b7b5.tar.bz2 | |
Remove calls to HandleScope default ctor.
It's replaced by a version which takes an isolate. The default ctor will be removed soon.
BUG=
R=jamesr@chromium.org, sky@chromium.org, szym@chromium.org
Review URL: https://codereview.chromium.org/23861002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221193 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
| -rw-r--r-- | net/proxy/proxy_resolver_v8.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc index 0c51d5d..190a4c0 100644 --- a/net/proxy/proxy_resolver_v8.cc +++ b/net/proxy/proxy_resolver_v8.cc @@ -184,11 +184,12 @@ v8::Local<v8::String> ASCIILiteralToV8String(const char* ascii) { // Stringizes a V8 object by calling its toString() method. Returns true // on success. This may fail if the toString() throws an exception. bool V8ObjectToUTF16String(v8::Handle<v8::Value> object, - base::string16* utf16_result) { + base::string16* utf16_result, + v8::Isolate* isolate) { if (object.IsEmpty()) return false; - v8::HandleScope scope; + v8::HandleScope scope(isolate); v8::Local<v8::String> str_object = object->ToString(); if (str_object.IsEmpty()) return false; @@ -507,7 +508,7 @@ class ProxyResolverV8::Context { if (!message.IsEmpty()) { line_number = message->GetLineNumber(); - V8ObjectToUTF16String(message->Get(), &error_message); + V8ObjectToUTF16String(message->Get(), &error_message, isolate_); } js_bindings()->OnError(line_number, error_message); @@ -547,7 +548,7 @@ class ProxyResolverV8::Context { if (args.Length() == 0) { message = ASCIIToUTF16("undefined"); } else { - if (!V8ObjectToUTF16String(args[0], &message)) + if (!V8ObjectToUTF16String(args[0], &message, args.GetIsolate())) return; // toString() threw an exception. } |