diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-17 21:59:52 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-17 21:59:52 +0000 |
| commit | 9e0bfe7d419774de2f4deee72018dd69121b475c (patch) | |
| tree | 9b20bf1c3f3238ec9a9b40c1277fb989d198f5aa /net/proxy | |
| parent | 31d5661563a8dafc0409cf677a4e149c08ddb770 (diff) | |
| download | chromium_src-9e0bfe7d419774de2f4deee72018dd69121b475c.zip chromium_src-9e0bfe7d419774de2f4deee72018dd69121b475c.tar.gz chromium_src-9e0bfe7d419774de2f4deee72018dd69121b475c.tar.bz2 | |
Revert 114929 - Standardize StringToInt{,64} interface.
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8984007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
| -rw-r--r-- | net/proxy/proxy_bypass_rules.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/proxy/proxy_bypass_rules.cc b/net/proxy/proxy_bypass_rules.cc index 1c0fd61..3d622a8 100644 --- a/net/proxy/proxy_bypass_rules.cc +++ b/net/proxy/proxy_bypass_rules.cc @@ -7,7 +7,6 @@ #include "base/stl_util.h" #include "base/stringprintf.h" #include "base/string_number_conversions.h" -#include "base/string_piece.h" #include "base/string_tokenizer.h" #include "base/string_util.h" #include "net/base/net_util.h" @@ -316,9 +315,7 @@ bool ProxyBypassRules::AddRuleFromStringInternal( host = raw; port = -1; if (pos_colon != std::string::npos) { - if (!base::StringToInt(base::StringPiece(raw.begin() + pos_colon + 1, - raw.end()), - &port) || + if (!base::StringToInt(raw.begin() + pos_colon + 1, raw.end(), &port) || (port < 0 || port > 0xFFFF)) { return false; // Port was invalid. } |