diff options
author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-28 20:12:27 +0000 |
---|---|---|
committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-28 20:12:27 +0000 |
commit | 5a1d7ca44e2d11095828ec35d63fc87bd2c3dbef (patch) | |
tree | 2f8ce83b395dee893febd751f95ee4b85422c6b2 /net/proxy | |
parent | 3f4a48393754bd0bb8dcf6bb73241154a695dae3 (diff) | |
download | chromium_src-5a1d7ca44e2d11095828ec35d63fc87bd2c3dbef.zip chromium_src-5a1d7ca44e2d11095828ec35d63fc87bd2c3dbef.tar.gz chromium_src-5a1d7ca44e2d11095828ec35d63fc87bd2c3dbef.tar.bz2 |
Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing NULL in place of a const BoundNetLog&.
BUG=37421
Review URL: http://codereview.chromium.org/1783008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45851 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
-rw-r--r-- | net/proxy/init_proxy_resolver.cc | 13 | ||||
-rw-r--r-- | net/proxy/init_proxy_resolver.h | 9 | ||||
-rw-r--r-- | net/proxy/init_proxy_resolver_unittest.cc | 46 | ||||
-rw-r--r-- | net/proxy/proxy_resolver_perftest.cc | 6 | ||||
-rw-r--r-- | net/proxy/proxy_resolver_v8.cc | 2 | ||||
-rw-r--r-- | net/proxy/proxy_resolver_v8_unittest.cc | 53 | ||||
-rw-r--r-- | net/proxy/proxy_service.cc | 18 | ||||
-rw-r--r-- | net/proxy/proxy_service.h | 9 | ||||
-rw-r--r-- | net/proxy/proxy_service_unittest.cc | 228 | ||||
-rw-r--r-- | net/proxy/single_threaded_proxy_resolver_unittest.cc | 24 |
10 files changed, 226 insertions, 182 deletions
diff --git a/net/proxy/init_proxy_resolver.cc b/net/proxy/init_proxy_resolver.cc index 2c27dcb..ea1e475 100644 --- a/net/proxy/init_proxy_resolver.cc +++ b/net/proxy/init_proxy_resolver.cc @@ -17,14 +17,17 @@ namespace net { InitProxyResolver::InitProxyResolver(ProxyResolver* resolver, - ProxyScriptFetcher* proxy_script_fetcher) + ProxyScriptFetcher* proxy_script_fetcher, + NetLog* net_log) : resolver_(resolver), proxy_script_fetcher_(proxy_script_fetcher), ALLOW_THIS_IN_INITIALIZER_LIST(io_callback_( this, &InitProxyResolver::OnIOCompletion)), user_callback_(NULL), current_pac_url_index_(0u), - next_state_(STATE_NONE) { + next_state_(STATE_NONE), + net_log_(BoundNetLog::Make( + net_log, NetLog::SOURCE_INIT_PROXY_RESOLVER)) { } InitProxyResolver::~InitProxyResolver() { @@ -33,14 +36,10 @@ InitProxyResolver::~InitProxyResolver() { } int InitProxyResolver::Init(const ProxyConfig& config, - CompletionCallback* callback, - const BoundNetLog& net_log) { + CompletionCallback* callback) { DCHECK_EQ(STATE_NONE, next_state_); DCHECK(callback); DCHECK(config.MayRequirePACResolver()); - DCHECK(!net_log_.net_log()); - - net_log_ = net_log; net_log_.BeginEvent(NetLog::TYPE_INIT_PROXY_RESOLVER, NULL); diff --git a/net/proxy/init_proxy_resolver.h b/net/proxy/init_proxy_resolver.h index 031fef3..e8d4ab2 100644 --- a/net/proxy/init_proxy_resolver.h +++ b/net/proxy/init_proxy_resolver.h @@ -14,7 +14,6 @@ namespace net { -class BoundNetLog; class ProxyConfig; class ProxyResolver; class ProxyScriptFetcher; @@ -37,18 +36,18 @@ class ProxyScriptFetcher; // class InitProxyResolver { public: - // |resolver| and |proxy_script_fetcher| must remain valid for + // |resolver|, |proxy_script_fetcher| and |net_log| must remain valid for // the lifespan of InitProxyResolver. InitProxyResolver(ProxyResolver* resolver, - ProxyScriptFetcher* proxy_script_fetcher); + ProxyScriptFetcher* proxy_script_fetcher, + NetLog* net_log); // Aborts any in-progress request. ~InitProxyResolver(); // Apply the PAC settings of |config| to |resolver_|. int Init(const ProxyConfig& config, - CompletionCallback* callback, - const BoundNetLog& net_log); + CompletionCallback* callback); private: enum State { diff --git a/net/proxy/init_proxy_resolver_unittest.cc b/net/proxy/init_proxy_resolver_unittest.cc index 234e5b0..6610d4c 100644 --- a/net/proxy/init_proxy_resolver_unittest.cc +++ b/net/proxy/init_proxy_resolver_unittest.cc @@ -171,9 +171,9 @@ TEST(InitProxyResolverTest, CustomPacSucceeds) { Rules::Rule rule = rules.AddSuccessRule("http://custom/proxy.pac"); TestCompletionCallback callback; - CapturingBoundNetLog log(CapturingNetLog::kUnbounded); - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(OK, init.Init(config, &callback, log.bound())); + CapturingNetLog log(CapturingNetLog::kUnbounded); + InitProxyResolver init(&resolver, &fetcher, &log); + EXPECT_EQ(OK, init.Init(config, &callback)); EXPECT_EQ(rule.bytes(), resolver.pac_bytes()); // Check the NetLog was filled correctly. @@ -204,9 +204,9 @@ TEST(InitProxyResolverTest, CustomPacFails1) { rules.AddFailDownloadRule("http://custom/proxy.pac"); TestCompletionCallback callback; - CapturingBoundNetLog log(CapturingNetLog::kUnbounded); - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(kFailedDownloading, init.Init(config, &callback, log.bound())); + CapturingNetLog log(CapturingNetLog::kUnbounded); + InitProxyResolver init(&resolver, &fetcher, &log); + EXPECT_EQ(kFailedDownloading, init.Init(config, &callback)); EXPECT_EQ("", resolver.pac_bytes()); // Check the NetLog was filled correctly. @@ -233,8 +233,8 @@ TEST(InitProxyResolverTest, CustomPacFails2) { rules.AddFailParsingRule("http://custom/proxy.pac"); TestCompletionCallback callback; - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(kFailedParsing, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, &fetcher, NULL); + EXPECT_EQ(kFailedParsing, init.Init(config, &callback)); EXPECT_EQ("", resolver.pac_bytes()); } @@ -247,8 +247,8 @@ TEST(InitProxyResolverTest, HasNullProxyScriptFetcher) { config.set_pac_url(GURL("http://custom/proxy.pac")); TestCompletionCallback callback; - InitProxyResolver init(&resolver, NULL); - EXPECT_EQ(ERR_UNEXPECTED, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, NULL, NULL); + EXPECT_EQ(ERR_UNEXPECTED, init.Init(config, &callback)); EXPECT_EQ("", resolver.pac_bytes()); } @@ -264,8 +264,8 @@ TEST(InitProxyResolverTest, AutodetectSuccess) { Rules::Rule rule = rules.AddSuccessRule("http://wpad/wpad.dat"); TestCompletionCallback callback; - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(OK, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, &fetcher, NULL); + EXPECT_EQ(OK, init.Init(config, &callback)); EXPECT_EQ(rule.bytes(), resolver.pac_bytes()); } @@ -283,8 +283,8 @@ TEST(InitProxyResolverTest, AutodetectFailCustomSuccess1) { Rules::Rule rule = rules.AddSuccessRule("http://custom/proxy.pac"); TestCompletionCallback callback; - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(OK, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, &fetcher, NULL); + EXPECT_EQ(OK, init.Init(config, &callback)); EXPECT_EQ(rule.bytes(), resolver.pac_bytes()); } @@ -302,9 +302,9 @@ TEST(InitProxyResolverTest, AutodetectFailCustomSuccess2) { Rules::Rule rule = rules.AddSuccessRule("http://custom/proxy.pac"); TestCompletionCallback callback; - CapturingBoundNetLog log(CapturingNetLog::kUnbounded); - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(OK, init.Init(config, &callback, log.bound())); + CapturingNetLog log(CapturingNetLog::kUnbounded); + InitProxyResolver init(&resolver, &fetcher, &log); + EXPECT_EQ(OK, init.Init(config, &callback)); EXPECT_EQ(rule.bytes(), resolver.pac_bytes()); // Check the NetLog was filled correctly. @@ -351,8 +351,8 @@ TEST(InitProxyResolverTest, AutodetectFailCustomFails1) { rules.AddFailDownloadRule("http://custom/proxy.pac"); TestCompletionCallback callback; - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(kFailedDownloading, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, &fetcher, NULL); + EXPECT_EQ(kFailedDownloading, init.Init(config, &callback)); EXPECT_EQ("", resolver.pac_bytes()); } @@ -370,8 +370,8 @@ TEST(InitProxyResolverTest, AutodetectFailCustomFails2) { rules.AddFailParsingRule("http://custom/proxy.pac"); TestCompletionCallback callback; - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(kFailedParsing, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, &fetcher, NULL); + EXPECT_EQ(kFailedParsing, init.Init(config, &callback)); EXPECT_EQ("", resolver.pac_bytes()); } @@ -391,8 +391,8 @@ TEST(InitProxyResolverTest, AutodetectFailCustomSuccess2_NoFetch) { Rules::Rule rule = rules.AddSuccessRule("http://custom/proxy.pac"); TestCompletionCallback callback; - InitProxyResolver init(&resolver, &fetcher); - EXPECT_EQ(OK, init.Init(config, &callback, NULL)); + InitProxyResolver init(&resolver, &fetcher, NULL); + EXPECT_EQ(OK, init.Init(config, &callback)); EXPECT_EQ(rule.url, resolver.pac_url()); } diff --git a/net/proxy/proxy_resolver_perftest.cc b/net/proxy/proxy_resolver_perftest.cc index 7650be4..c093506 100644 --- a/net/proxy/proxy_resolver_perftest.cc +++ b/net/proxy/proxy_resolver_perftest.cc @@ -109,7 +109,8 @@ class PacPerfSuiteRunner { { net::ProxyInfo proxy_info; int result = resolver_->GetProxyForURL( - GURL("http://www.warmup.com"), &proxy_info, NULL, NULL, NULL); + GURL("http://www.warmup.com"), &proxy_info, NULL, NULL, + net::BoundNetLog()); ASSERT_EQ(net::OK, result); } @@ -124,7 +125,8 @@ class PacPerfSuiteRunner { // Resolve. net::ProxyInfo proxy_info; int result = resolver_->GetProxyForURL(GURL(query.query_url), - &proxy_info, NULL, NULL, NULL); + &proxy_info, NULL, NULL, + net::BoundNetLog()); // Check that the result was correct. Note that ToPacString() and // ASSERT_EQ() are fast, so they won't skew the results. diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc index 17916e6..3fb01c2b 100644 --- a/net/proxy/proxy_resolver_v8.cc +++ b/net/proxy/proxy_resolver_v8.cc @@ -102,7 +102,7 @@ bool V8ObjectToString(v8::Handle<v8::Value> object, std::string* result) { class ProxyResolverV8::Context { public: explicit Context(ProxyResolverJSBindings* js_bindings) - : js_bindings_(js_bindings), current_request_net_log_(NULL) { + : js_bindings_(js_bindings) { DCHECK(js_bindings != NULL); } diff --git a/net/proxy/proxy_resolver_v8_unittest.cc b/net/proxy/proxy_resolver_v8_unittest.cc index b124c66..e46b1cb 100644 --- a/net/proxy/proxy_resolver_v8_unittest.cc +++ b/net/proxy/proxy_resolver_v8_unittest.cc @@ -138,7 +138,8 @@ TEST(ProxyResolverV8Test, ReturnEmptyString) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_TRUE(proxy_info.is_direct()); @@ -158,7 +159,7 @@ TEST(ProxyResolverV8Test, Basic) { { ProxyInfo proxy_info; result = resolver.GetProxyForURL(GURL("http://query.com/path"), - &proxy_info, NULL, NULL, NULL); + &proxy_info, NULL, NULL, BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_EQ("http.query.com.path.query.com:80", proxy_info.proxy_server().ToURI()); @@ -166,7 +167,8 @@ TEST(ProxyResolverV8Test, Basic) { { ProxyInfo proxy_info; int result = resolver.GetProxyForURL(GURL("ftp://query.com:90/path"), - &proxy_info, NULL, NULL, NULL); + &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); // Note that FindProxyForURL(url, host) does not expect |host| to contain // the port number. @@ -204,7 +206,8 @@ TEST(ProxyResolverV8Test, BadReturnType) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result); @@ -224,7 +227,8 @@ TEST(ProxyResolverV8Test, NoEntryPoint) { EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(ERR_FAILED, result); } @@ -236,7 +240,8 @@ TEST(ProxyResolverV8Test, ParseError) { EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(ERR_FAILED, result); @@ -259,7 +264,8 @@ TEST(ProxyResolverV8Test, SideEffects) { // The PAC script increments a counter each time we invoke it. for (int i = 0; i < 3; ++i) { ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_EQ(StringPrintf("sideffect_%d:80", i), proxy_info.proxy_server().ToURI()); @@ -272,7 +278,8 @@ TEST(ProxyResolverV8Test, SideEffects) { for (int i = 0; i < 3; ++i) { ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_EQ(StringPrintf("sideffect_%d:80", i), proxy_info.proxy_server().ToURI()); @@ -286,7 +293,8 @@ TEST(ProxyResolverV8Test, UnhandledException) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result); @@ -306,7 +314,8 @@ TEST(ProxyResolverV8Test, DISABLED_ReturnUnicode) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); // The result from this resolve was unparseable, because it // wasn't ascii. @@ -320,7 +329,8 @@ TEST(ProxyResolverV8Test, JavascriptLibrary) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); // If the javascript side of this unit-test fails, it will throw a javascript // exception. Otherwise it will return "PROXY success:80". @@ -338,7 +348,8 @@ TEST(ProxyResolverV8Test, NoSetPacScript) { ProxyInfo proxy_info; // Resolve should fail, as we are not yet initialized with a script. - int result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + int result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(ERR_FAILED, result); // Initialize it. @@ -346,20 +357,23 @@ TEST(ProxyResolverV8Test, NoSetPacScript) { EXPECT_EQ(OK, result); // Resolve should now succeed. - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); // Clear it, by initializing with an empty string. resolver.SetPacScriptByData(std::string(), NULL); // Resolve should fail again now. - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(ERR_FAILED, result); // Load a good script once more. result = resolver.SetPacScriptFromDisk("direct.js"); EXPECT_EQ(OK, result); - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_EQ(0U, resolver.mock_js_bindings()->alerts.size()); @@ -373,7 +387,8 @@ TEST(ProxyResolverV8Test, V8Bindings) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_TRUE(proxy_info.is_direct()); @@ -430,7 +445,8 @@ TEST(ProxyResolverV8Test, BindingCalledDuringInitialization) { EXPECT_EQ(1, bindings->my_ip_address_count); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_FALSE(proxy_info.is_direct()); @@ -528,7 +544,8 @@ TEST(ProxyResolverV8Test, DNSResolutionFailure) { EXPECT_EQ(OK, result); ProxyInfo proxy_info; - result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, NULL); + result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, NULL, NULL, + BoundNetLog()); EXPECT_EQ(OK, result); EXPECT_FALSE(proxy_info.is_direct()); diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc index 2c68cf4..002c514 100644 --- a/net/proxy/proxy_service.cc +++ b/net/proxy/proxy_service.cc @@ -201,14 +201,14 @@ class ProxyService::PacRequest ProxyService::ProxyService(ProxyConfigService* config_service, ProxyResolver* resolver, NetworkChangeNotifier* network_change_notifier, - const BoundNetLog& init_proxy_resolver_log) + NetLog* net_log) : config_service_(config_service), resolver_(resolver), next_config_id_(1), should_use_proxy_resolver_(false), ALLOW_THIS_IN_INITIALIZER_LIST(init_proxy_resolver_callback_( this, &ProxyService::OnInitProxyResolverComplete)), - init_proxy_resolver_log_(init_proxy_resolver_log), + net_log_(net_log), network_change_notifier_(network_change_notifier) { // Register to receive network change notifications. if (network_change_notifier_) @@ -251,7 +251,7 @@ ProxyService* ProxyService::Create( ProxyService* proxy_service = new ProxyService( proxy_config_service, proxy_resolver, network_change_notifier, - BoundNetLog::Make(net_log, NetLog::SOURCE_INIT_PROXY_RESOLVER)); + net_log); if (proxy_resolver->expects_pac_bytes()) { // Configure PAC script downloads to be issued using |url_request_context|. @@ -275,7 +275,7 @@ ProxyService* ProxyService::CreateNull() { return new ProxyService(new ProxyConfigServiceNull, new ProxyResolverNull, NULL, - BoundNetLog()); + NULL); } int ProxyService::ResolveProxy(const GURL& raw_url, @@ -520,7 +520,7 @@ ProxyScriptFetcher* ProxyService::GetProxyScriptFetcher() const { void ProxyService::ResetConfigService( ProxyConfigService* new_proxy_config_service) { config_service_.reset(new_proxy_config_service); - UpdateConfig(NULL); + UpdateConfig(BoundNetLog()); } void ProxyService::PurgeMemory() { @@ -533,7 +533,7 @@ void ProxyService::ForceReloadProxyConfig() { // start updating (normally this would happen lazily during the next // call to ResolveProxy()). config_.set_id(ProxyConfig::INVALID_ID); - UpdateConfig(NULL); + UpdateConfig(BoundNetLog()); } // static @@ -653,11 +653,11 @@ void ProxyService::StartInitProxyResolver() { DCHECK(!init_proxy_resolver_.get()); init_proxy_resolver_.reset( - new InitProxyResolver(resolver_.get(), proxy_script_fetcher_.get())); + new InitProxyResolver(resolver_.get(), proxy_script_fetcher_.get(), + net_log_)); int rv = init_proxy_resolver_->Init( - config_, &init_proxy_resolver_callback_, - init_proxy_resolver_log_); + config_, &init_proxy_resolver_callback_); if (rv != ERR_IO_PENDING) OnInitProxyResolverComplete(rv); diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h index bf176c8..49c7979 100644 --- a/net/proxy/proxy_service.h +++ b/net/proxy/proxy_service.h @@ -39,9 +39,11 @@ class ProxyService : public base::RefCountedThreadSafe<ProxyService>, // If |network_change_notifier| is non-NULL, the proxy service will register // with it to detect when the network setup has changed. This is used to // decide when to re-configure the proxy discovery. + // |net_log| is a possibly NULL destination to send log events to. It must + // remain alive for the lifetime of this ProxyService. ProxyService(ProxyConfigService* config_service, ProxyResolver* resolver, NetworkChangeNotifier* network_change_notifier, - const BoundNetLog& init_proxy_resolver_log); + NetLog* net_log); // Used internally to handle PAC queries. // TODO(eroman): consider naming this simply "Request". @@ -281,8 +283,9 @@ class ProxyService : public base::RefCountedThreadSafe<ProxyService>, // |proxy_resolver_| must outlive |init_proxy_resolver_|. scoped_ptr<InitProxyResolver> init_proxy_resolver_; - // Log for events generated by |init_proxy_resolver_|. - BoundNetLog init_proxy_resolver_log_; + // This is the log where any events generated by |init_proxy_resolver_| are + // sent to. + NetLog* net_log_; // The (possibly NULL) network change notifier that we use to decide when // to refetch PAC scripts or re-run WPAD. diff --git a/net/proxy/proxy_service_unittest.cc b/net/proxy/proxy_service_unittest.cc index d608a44..f5e76d9 100644 --- a/net/proxy/proxy_service_unittest.cc +++ b/net/proxy/proxy_service_unittest.cc @@ -92,8 +92,7 @@ class MockProxyScriptFetcher : public ProxyScriptFetcher { TEST(ProxyServiceTest, Direct) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(new MockProxyConfigService, resolver, NULL, - BoundNetLog())); + new ProxyService(new MockProxyConfigService, resolver, NULL, NULL)); GURL url("http://www.google.com/"); @@ -121,7 +120,7 @@ TEST(ProxyServiceTest, PAC) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); @@ -168,13 +167,13 @@ TEST(ProxyServiceTest, PAC_NoIdentityOrHash) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://username:password@www.google.com/?ref#hash#hash"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -196,13 +195,13 @@ TEST(ProxyServiceTest, PAC_FailoverWithoutDirect) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -224,7 +223,8 @@ TEST(ProxyServiceTest, PAC_FailoverWithoutDirect) { // left to fallback to, since our proxy list was NOT terminated by // DIRECT. TestCompletionCallback callback2; - rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, + BoundNetLog()); // ReconsiderProxyAfterError returns error indicating nothing left. EXPECT_EQ(ERR_FAILED, rv); EXPECT_TRUE(info.is_empty()); @@ -253,13 +253,13 @@ TEST(ProxyServiceTest, PAC_FailoverAfterDirect) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -279,27 +279,31 @@ TEST(ProxyServiceTest, PAC_FailoverAfterDirect) { // Fallback 1. TestCompletionCallback callback2; - rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("foobar:10", info.proxy_server().ToURI()); // Fallback 2. TestCompletionCallback callback3; - rv = service->ReconsiderProxyAfterError(url, &info, &callback3, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback3, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_TRUE(info.is_direct()); // Fallback 3. TestCompletionCallback callback4; - rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("foobar:20", info.proxy_server().ToURI()); // Fallback 4 -- Nothing to fall back to! TestCompletionCallback callback5; - rv = service->ReconsiderProxyAfterError(url, &info, &callback5, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback5, NULL, + BoundNetLog()); EXPECT_EQ(ERR_FAILED, rv); EXPECT_TRUE(info.is_empty()); } @@ -315,13 +319,13 @@ TEST(ProxyServiceTest, ProxyResolverFails) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); // Start first resolve request. GURL url("http://www.google.com/"); ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -342,7 +346,7 @@ TEST(ProxyServiceTest, ProxyResolverFails) { // The second resolve request will try to run through the proxy resolver, // regardless of whether the first request failed in it. TestCompletionCallback callback2; - rv = service->ResolveProxy(url, &info, &callback2, NULL, NULL); + rv = service->ResolveProxy(url, &info, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(1u, resolver->pending_requests().size()); @@ -368,14 +372,14 @@ TEST(ProxyServiceTest, ProxyFallback) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); // Get the proxy information. ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -397,14 +401,15 @@ TEST(ProxyServiceTest, ProxyFallback) { // Fake an error on the proxy. TestCompletionCallback callback2; - rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); // The second proxy should be specified. EXPECT_EQ("foopy2:9090", info.proxy_server().ToURI()); TestCompletionCallback callback3; - rv = service->ResolveProxy(url, &info, &callback3, NULL, NULL); + rv = service->ResolveProxy(url, &info, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(1u, resolver->pending_requests().size()); @@ -422,7 +427,8 @@ TEST(ProxyServiceTest, ProxyFallback) { // We fake another error. It should now try the third one. TestCompletionCallback callback4; - rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_EQ("foopy2:9090", info.proxy_server().ToURI()); @@ -430,14 +436,16 @@ TEST(ProxyServiceTest, ProxyFallback) { // proxy servers we thought were valid; next we try the proxy server // that was in our bad proxies map (foopy1:8080). TestCompletionCallback callback5; - rv = service->ReconsiderProxyAfterError(url, &info, &callback5, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback5, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_EQ("foopy1:8080", info.proxy_server().ToURI()); // Fake another error, the last proxy is gone, the list should now be empty, // so there is nothing left to try. TestCompletionCallback callback6; - rv = service->ReconsiderProxyAfterError(url, &info, &callback6, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback6, NULL, + BoundNetLog()); EXPECT_EQ(ERR_FAILED, rv); EXPECT_FALSE(info.is_direct()); EXPECT_TRUE(info.is_empty()); @@ -454,14 +462,14 @@ TEST(ProxyServiceTest, ProxyFallbackToDirect) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); // Get the proxy information. ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -483,7 +491,8 @@ TEST(ProxyServiceTest, ProxyFallbackToDirect) { // Fake an error on the proxy. TestCompletionCallback callback2; - rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); // Now we get back the second proxy. @@ -491,7 +500,8 @@ TEST(ProxyServiceTest, ProxyFallbackToDirect) { // Fake an error on this proxy as well. TestCompletionCallback callback3; - rv = service->ReconsiderProxyAfterError(url, &info, &callback3, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback3, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); // Finally, we get back DIRECT. @@ -499,7 +509,8 @@ TEST(ProxyServiceTest, ProxyFallbackToDirect) { // Now we tell the proxy service that even DIRECT failed. TestCompletionCallback callback4; - rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, + BoundNetLog()); // There was nothing left to try after DIRECT, so we are out of // choices. EXPECT_EQ(ERR_FAILED, rv); @@ -514,14 +525,14 @@ TEST(ProxyServiceTest, ProxyFallback_NewSettings) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); // Get the proxy information. ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -546,7 +557,8 @@ TEST(ProxyServiceTest, ProxyFallback_NewSettings) { config_service->config.set_pac_url(GURL("http://foopy-new/proxy.pac")); TestCompletionCallback callback2; - rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, + BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy-new/proxy.pac"), @@ -566,7 +578,8 @@ TEST(ProxyServiceTest, ProxyFallback_NewSettings) { // We fake another error. It should now ignore the first one. TestCompletionCallback callback3; - rv = service->ReconsiderProxyAfterError(url, &info, &callback3, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback3, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_EQ("foopy2:9090", info.proxy_server().ToURI()); @@ -576,7 +589,8 @@ TEST(ProxyServiceTest, ProxyFallback_NewSettings) { // We fake another error. It should go back to the first proxy. TestCompletionCallback callback4; - rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback4, NULL, + BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy-new2/proxy.pac"), @@ -603,14 +617,14 @@ TEST(ProxyServiceTest, ProxyFallback_BadConfig) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); // Get the proxy information. ProxyInfo info; TestCompletionCallback callback1; - int rv = service->ResolveProxy(url, &info, &callback1, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -630,7 +644,8 @@ TEST(ProxyServiceTest, ProxyFallback_BadConfig) { // Fake a proxy error. TestCompletionCallback callback2; - rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info, &callback2, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); // The first proxy is ignored, and the second one is selected. @@ -640,7 +655,7 @@ TEST(ProxyServiceTest, ProxyFallback_BadConfig) { // Fake a PAC failure. ProxyInfo info2; TestCompletionCallback callback3; - rv = service->ResolveProxy(url, &info2, &callback3, NULL, NULL); + rv = service->ResolveProxy(url, &info2, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(1u, resolver->pending_requests().size()); @@ -660,7 +675,8 @@ TEST(ProxyServiceTest, ProxyFallback_BadConfig) { // "just work" the next time we call it. ProxyInfo info3; TestCompletionCallback callback4; - rv = service->ReconsiderProxyAfterError(url, &info3, &callback4, NULL, NULL); + rv = service->ReconsiderProxyAfterError(url, &info3, &callback4, NULL, + BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(1u, resolver->pending_requests().size()); @@ -689,19 +705,19 @@ TEST(ProxyServiceTest, ProxyBypassList) { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); int rv; GURL url1("http://www.webkit.org"); GURL url2("http://www.webkit.com"); // Request for a .org domain should bypass proxy. - rv = service->ResolveProxy(url1, &info[0], &callback[0], NULL, NULL); + rv = service->ResolveProxy(url1, &info[0], &callback[0], NULL, BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_TRUE(info[0].is_direct()); // Request for a .com domain hits the proxy. - rv = service->ResolveProxy(url2, &info[1], &callback[1], NULL, NULL); + rv = service->ResolveProxy(url2, &info[1], &callback[1], NULL, BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_EQ("foopy1:8080", info[1].proxy_server().ToURI()); } @@ -714,11 +730,12 @@ TEST(ProxyServiceTest, PerProtocolProxyTests) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("http://www.msn.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("foopy1:8080", info.proxy_server().ToURI()); @@ -726,11 +743,12 @@ TEST(ProxyServiceTest, PerProtocolProxyTests) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("ftp://ftp.google.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_TRUE(info.is_direct()); EXPECT_EQ("direct://", info.proxy_server().ToURI()); @@ -738,11 +756,12 @@ TEST(ProxyServiceTest, PerProtocolProxyTests) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("https://webbranch.techcu.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("foopy2:8080", info.proxy_server().ToURI()); @@ -751,11 +770,12 @@ TEST(ProxyServiceTest, PerProtocolProxyTests) { config.proxy_rules().ParseFromString("foopy1:8080"); scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("http://www.microsoft.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("foopy1:8080", info.proxy_server().ToURI()); @@ -774,11 +794,12 @@ TEST(ProxyServiceTest, DefaultProxyFallbackToSOCKS) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("http://www.msn.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("foopy1:8080", info.proxy_server().ToURI()); @@ -786,11 +807,12 @@ TEST(ProxyServiceTest, DefaultProxyFallbackToSOCKS) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("ftp://ftp.google.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("socks4://foopy2:1080", info.proxy_server().ToURI()); @@ -798,11 +820,12 @@ TEST(ProxyServiceTest, DefaultProxyFallbackToSOCKS) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("https://webbranch.techcu.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("socks4://foopy2:1080", info.proxy_server().ToURI()); @@ -810,11 +833,12 @@ TEST(ProxyServiceTest, DefaultProxyFallbackToSOCKS) { { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config), new MockAsyncProxyResolver, NULL, - BoundNetLog())); + NULL)); GURL test_url("unknown://www.microsoft.com"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(test_url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(test_url, &info, &callback, NULL, + BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_FALSE(info.is_direct()); EXPECT_EQ("socks4://foopy2:1080", info.proxy_server().ToURI()); @@ -829,14 +853,14 @@ TEST(ProxyServiceTest, CancelInProgressRequest) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); // Start 3 requests. ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Nothing has been sent to the proxy resolver yet, since the proxy @@ -855,7 +879,7 @@ TEST(ProxyServiceTest, CancelInProgressRequest) { TestCompletionCallback callback2; ProxyService::PacRequest* request2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, &request2, NULL); + GURL("http://request2"), &info2, &callback2, &request2, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(2u, resolver->pending_requests().size()); EXPECT_EQ(GURL("http://request2"), resolver->pending_requests()[1]->url()); @@ -863,7 +887,7 @@ TEST(ProxyServiceTest, CancelInProgressRequest) { ProxyInfo info3; TestCompletionCallback callback3; rv = service->ResolveProxy( - GURL("http://request3"), &info3, &callback3, NULL, NULL); + GURL("http://request3"), &info3, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(3u, resolver->pending_requests().size()); EXPECT_EQ(GURL("http://request3"), resolver->pending_requests()[2]->url()); @@ -904,7 +928,7 @@ TEST(ProxyServiceTest, InitialPACScriptDownload) { new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -914,7 +938,7 @@ TEST(ProxyServiceTest, InitialPACScriptDownload) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // The first request should have triggered download of PAC script. @@ -924,13 +948,13 @@ TEST(ProxyServiceTest, InitialPACScriptDownload) { ProxyInfo info2; TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, NULL, NULL); + GURL("http://request2"), &info2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ProxyInfo info3; TestCompletionCallback callback3; rv = service->ResolveProxy( - GURL("http://request3"), &info3, &callback3, NULL, NULL); + GURL("http://request3"), &info3, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Nothing has been sent to the resolver yet. @@ -983,7 +1007,7 @@ TEST(ProxyServiceTest, ChangeScriptFetcherWhilePACDownloadInProgress) { new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -993,7 +1017,7 @@ TEST(ProxyServiceTest, ChangeScriptFetcherWhilePACDownloadInProgress) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // The first request should have triggered download of PAC script. @@ -1003,7 +1027,7 @@ TEST(ProxyServiceTest, ChangeScriptFetcherWhilePACDownloadInProgress) { ProxyInfo info2; TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, NULL, NULL); + GURL("http://request2"), &info2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // At this point the ProxyService should be waiting for the @@ -1040,7 +1064,7 @@ TEST(ProxyServiceTest, CancelWhilePACFetching) { new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1062,13 +1086,13 @@ TEST(ProxyServiceTest, CancelWhilePACFetching) { TestCompletionCallback callback2; ProxyService::PacRequest* request2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, &request2, NULL); + GURL("http://request2"), &info2, &callback2, &request2, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ProxyInfo info3; TestCompletionCallback callback3; rv = service->ResolveProxy( - GURL("http://request3"), &info3, &callback3, NULL, NULL); + GURL("http://request3"), &info3, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Nothing has been sent to the resolver yet. @@ -1128,7 +1152,7 @@ TEST(ProxyServiceTest, FallbackFromAutodetectToCustomPac) { MockAsyncProxyResolverExpectsBytes* resolver = new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1138,14 +1162,14 @@ TEST(ProxyServiceTest, FallbackFromAutodetectToCustomPac) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ProxyInfo info2; TestCompletionCallback callback2; ProxyService::PacRequest* request2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, &request2, NULL); + GURL("http://request2"), &info2, &callback2, &request2, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1199,7 +1223,7 @@ TEST(ProxyServiceTest, FallbackFromAutodetectToCustomPac2) { MockAsyncProxyResolverExpectsBytes* resolver = new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1209,14 +1233,14 @@ TEST(ProxyServiceTest, FallbackFromAutodetectToCustomPac2) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ProxyInfo info2; TestCompletionCallback callback2; ProxyService::PacRequest* request2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, &request2, NULL); + GURL("http://request2"), &info2, &callback2, &request2, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1275,7 +1299,7 @@ TEST(ProxyServiceTest, FallbackFromAutodetectToCustomToManual) { MockAsyncProxyResolverExpectsBytes* resolver = new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1285,14 +1309,14 @@ TEST(ProxyServiceTest, FallbackFromAutodetectToCustomToManual) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ProxyInfo info2; TestCompletionCallback callback2; ProxyService::PacRequest* request2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, &request2, NULL); + GURL("http://request2"), &info2, &callback2, &request2, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1333,7 +1357,7 @@ TEST(ProxyServiceTest, BypassDoesntApplyToPac) { MockAsyncProxyResolverExpectsBytes* resolver = new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1343,7 +1367,7 @@ TEST(ProxyServiceTest, BypassDoesntApplyToPac) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://www.google.com"), &info1, &callback1, NULL, NULL); + GURL("http://www.google.com"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1374,7 +1398,7 @@ TEST(ProxyServiceTest, BypassDoesntApplyToPac) { ProxyInfo info2; TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://www.google.com"), &info2, &callback2, NULL, NULL); + GURL("http://www.google.com"), &info2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ASSERT_EQ(1u, resolver->pending_requests().size()); @@ -1401,7 +1425,7 @@ TEST(ProxyServiceTest, DeleteWhileInitProxyResolverHasOutstandingFetch) { MockAsyncProxyResolverExpectsBytes* resolver = new MockAsyncProxyResolverExpectsBytes; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1411,7 +1435,7 @@ TEST(ProxyServiceTest, DeleteWhileInitProxyResolverHasOutstandingFetch) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://www.google.com"), &info1, &callback1, NULL, NULL); + GURL("http://www.google.com"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1437,13 +1461,13 @@ TEST(ProxyServiceTest, DeleteWhileInitProxyResolverHasOutstandingSet) { MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); GURL url("http://www.google.com/"); ProxyInfo info; TestCompletionCallback callback; - int rv = service->ResolveProxy(url, &info, &callback, NULL, NULL); + int rv = service->ResolveProxy(url, &info, &callback, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_EQ(GURL("http://foopy/proxy.pac"), @@ -1460,12 +1484,12 @@ TEST(ProxyServiceTest, ResetProxyConfigService) { scoped_refptr<ProxyService> service(new ProxyService( new MockProxyConfigService(config1), new MockAsyncProxyResolverExpectsBytes, - NULL, BoundNetLog())); + NULL, NULL)); ProxyInfo info; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info, &callback1, NULL, NULL); + GURL("http://request1"), &info, &callback1, NULL, BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_EQ("foopy1:8080", info.proxy_server().ToURI()); @@ -1475,7 +1499,7 @@ TEST(ProxyServiceTest, ResetProxyConfigService) { service->ResetConfigService(new MockProxyConfigService(config2)); TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://request2"), &info, &callback2, NULL, NULL); + GURL("http://request2"), &info, &callback2, NULL, BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_EQ("foopy2:8080", info.proxy_server().ToURI()); } @@ -1492,14 +1516,14 @@ TEST(ProxyServiceTest, UpdateConfigAfterFailedAutodetect) { MockProxyConfigService* config_service = new MockProxyConfigService(config); MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); // Start 1 requests. ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://www.google.com"), &info1, &callback1, NULL, NULL); + GURL("http://www.google.com"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1515,7 +1539,7 @@ TEST(ProxyServiceTest, UpdateConfigAfterFailedAutodetect) { // Force the ProxyService to pull down a new proxy configuration. // (Even though the configuration isn't old/bad). - service->UpdateConfig(NULL); + service->UpdateConfig(BoundNetLog()); // Start another request -- the effective configuration has not // changed, so we shouldn't re-run the autodetect step. @@ -1523,7 +1547,7 @@ TEST(ProxyServiceTest, UpdateConfigAfterFailedAutodetect) { ProxyInfo info2; TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://www.google.com"), &info2, &callback2, NULL, NULL); + GURL("http://www.google.com"), &info2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_TRUE(info2.is_direct()); @@ -1538,14 +1562,14 @@ TEST(ProxyServiceTest, UpdateConfigFromPACToDirect) { MockProxyConfigService* config_service = new MockProxyConfigService(config); MockAsyncProxyResolver* resolver = new MockAsyncProxyResolver; scoped_refptr<ProxyService> service( - new ProxyService(config_service, resolver, NULL, BoundNetLog())); + new ProxyService(config_service, resolver, NULL, NULL)); // Start 1 request. ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://www.google.com"), &info1, &callback1, NULL, NULL); + GURL("http://www.google.com"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Check that nothing has been sent to the proxy resolver yet. @@ -1571,13 +1595,13 @@ TEST(ProxyServiceTest, UpdateConfigFromPACToDirect) { // requests should complete synchronously now as direct-connect. config.set_auto_detect(false); config_service->config = config; - service->UpdateConfig(NULL); + service->UpdateConfig(BoundNetLog()); // Start another request -- the effective configuration has changed. ProxyInfo info2; TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://www.google.com"), &info2, &callback2, NULL, NULL); + GURL("http://www.google.com"), &info2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(OK, rv); EXPECT_TRUE(info2.is_direct()); @@ -1594,7 +1618,7 @@ TEST(ProxyServiceTest, NetworkChangeTriggersPacRefetch) { scoped_refptr<ProxyService> service( new ProxyService(config_service, resolver, &network_change_notifier, - BoundNetLog())); + NULL)); MockProxyScriptFetcher* fetcher = new MockProxyScriptFetcher; service->SetProxyScriptFetcher(fetcher); @@ -1604,7 +1628,7 @@ TEST(ProxyServiceTest, NetworkChangeTriggersPacRefetch) { ProxyInfo info1; TestCompletionCallback callback1; int rv = service->ResolveProxy( - GURL("http://request1"), &info1, &callback1, NULL, NULL); + GURL("http://request1"), &info1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // The first request should have triggered initial download of PAC script. @@ -1645,7 +1669,7 @@ TEST(ProxyServiceTest, NetworkChangeTriggersPacRefetch) { ProxyInfo info2; TestCompletionCallback callback2; rv = service->ResolveProxy( - GURL("http://request2"), &info2, &callback2, NULL, NULL); + GURL("http://request2"), &info2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // This second request should have triggered the re-download of the PAC diff --git a/net/proxy/single_threaded_proxy_resolver_unittest.cc b/net/proxy/single_threaded_proxy_resolver_unittest.cc index b6029ee..753fcdd 100644 --- a/net/proxy/single_threaded_proxy_resolver_unittest.cc +++ b/net/proxy/single_threaded_proxy_resolver_unittest.cc @@ -178,19 +178,19 @@ TEST(SingleThreadedProxyResolverTest, Basic) { TestCompletionCallback callback1; ProxyInfo results1; rv = resolver.GetProxyForURL( - GURL("http://request1"), &results1, &callback1, NULL, NULL); + GURL("http://request1"), &results1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); TestCompletionCallback callback2; ProxyInfo results2; rv = resolver.GetProxyForURL( - GURL("http://request2"), &results2, &callback2, NULL, NULL); + GURL("http://request2"), &results2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); TestCompletionCallback callback3; ProxyInfo results3; rv = resolver.GetProxyForURL( - GURL("http://request3"), &results3, &callback3, NULL, NULL); + GURL("http://request3"), &results3, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Wait for the requests to finish (they must finish in the order they were @@ -307,7 +307,7 @@ TEST(SingleThreadedProxyResolverTest, CancelRequest) { TestCompletionCallback callback0; ProxyInfo results0; rv = resolver.GetProxyForURL( - GURL("http://request0"), &results0, &callback0, &request0, NULL); + GURL("http://request0"), &results0, &callback0, &request0, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Wait until requests 0 reaches the worker thread. @@ -318,20 +318,20 @@ TEST(SingleThreadedProxyResolverTest, CancelRequest) { TestCompletionCallback callback1; ProxyInfo results1; rv = resolver.GetProxyForURL( - GURL("http://request1"), &results1, &callback1, NULL, NULL); + GURL("http://request1"), &results1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); ProxyResolver::RequestHandle request2; TestCompletionCallback callback2; ProxyInfo results2; rv = resolver.GetProxyForURL( - GURL("http://request2"), &results2, &callback2, &request2, NULL); + GURL("http://request2"), &results2, &callback2, &request2, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); TestCompletionCallback callback3; ProxyInfo results3; rv = resolver.GetProxyForURL( - GURL("http://request3"), &results3, &callback3, NULL, NULL); + GURL("http://request3"), &results3, &callback3, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Cancel request0 (inprogress) and request2 (pending). @@ -376,19 +376,19 @@ TEST(SingleThreadedProxyResolverTest, CancelRequestByDeleting) { TestCompletionCallback callback0; ProxyInfo results0; rv = resolver->GetProxyForURL( - GURL("http://request0"), &results0, &callback0, NULL, NULL); + GURL("http://request0"), &results0, &callback0, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); TestCompletionCallback callback1; ProxyInfo results1; rv = resolver->GetProxyForURL( - GURL("http://request1"), &results1, &callback1, NULL, NULL); + GURL("http://request1"), &results1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); TestCompletionCallback callback2; ProxyInfo results2; rv = resolver->GetProxyForURL( - GURL("http://request2"), &results2, &callback2, NULL, NULL); + GURL("http://request2"), &results2, &callback2, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Wait until request 0 reaches the worker thread. @@ -430,7 +430,7 @@ TEST(SingleThreadedProxyResolverTest, CancelSetPacScript) { TestCompletionCallback callback0; ProxyInfo results0; rv = resolver.GetProxyForURL( - GURL("http://request0"), &results0, &callback0, &request0, NULL); + GURL("http://request0"), &results0, &callback0, &request0, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Wait until requests 0 reaches the worker thread. @@ -449,7 +449,7 @@ TEST(SingleThreadedProxyResolverTest, CancelSetPacScript) { TestCompletionCallback callback1; ProxyInfo results1; rv = resolver.GetProxyForURL( - GURL("http://request1"), &results1, &callback1, NULL, NULL); + GURL("http://request1"), &results1, &callback1, NULL, BoundNetLog()); EXPECT_EQ(ERR_IO_PENDING, rv); // Unblock the worker thread so the requests can continue running. |