diff options
| author | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 19:42:24 +0000 |
|---|---|---|
| committer | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 19:42:24 +0000 |
| commit | 48697d8a33d2b98f7401a3b1e657c86cf3dba981 (patch) | |
| tree | 254ea035abc7758a85ec4328d68ae8b7d7a9ea29 /net/quic/quic_framer.h | |
| parent | 018c9908c69c8e5ab04a0f7878da276b27f6fc2d (diff) | |
| download | chromium_src-48697d8a33d2b98f7401a3b1e657c86cf3dba981.zip chromium_src-48697d8a33d2b98f7401a3b1e657c86cf3dba981.tar.gz chromium_src-48697d8a33d2b98f7401a3b1e657c86cf3dba981.tar.bz2 | |
Largest received -> largest observed.
This fixes a bug in our QUIC ack/nack logic where if we got a truncated ack with large contiguous blocks, we'd likely never resend-due-to-nacks because we used largest_received as an upper bound and it could be lower than all the missing packets.
Merge internal change: 40678081
TBR=jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11820005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176955 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/quic/quic_framer.h')
| -rw-r--r-- | net/quic/quic_framer.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h index 4cda9dc..f403e14 100644 --- a/net/quic/quic_framer.h +++ b/net/quic/quic_framer.h @@ -95,10 +95,10 @@ class NET_EXPORT_PRIVATE QuicFramer { virtual ~QuicFramer(); - // Calculates the largest received packet to advertise in the case an Ack + // Calculates the largest observed packet to advertise in the case an Ack // Frame was truncated. last_written in this case is the iterator for the // last missing packet which fit in the outgoing ack. - static QuicPacketSequenceNumber CalculateLargestReceived( + static QuicPacketSequenceNumber CalculateLargestObserved( const SequenceSet& missing_packets, SequenceSet::const_iterator last_written); |