diff options
| author | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-24 21:30:26 +0000 |
|---|---|---|
| committer | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-24 21:30:26 +0000 |
| commit | b55bf4f27234a29c023da906769d171874778c81 (patch) | |
| tree | 27c860c5a1676a033bcee4c08d160e87de8f7016 /net/quic/reliable_quic_stream.cc | |
| parent | d6ac9a7f8ad82fcf3239c65d38099ed9f10e4f5c (diff) | |
| download | chromium_src-b55bf4f27234a29c023da906769d171874778c81.zip chromium_src-b55bf4f27234a29c023da906769d171874778c81.tar.gz chromium_src-b55bf4f27234a29c023da906769d171874778c81.tar.bz2 | |
Replace all EXPECT_DEBUG_DEATH tests with EXPECT_DFATAL in QUIC code.
Switch associated DCHECKS to LOG(DFATAL).
Merge internal change: 60160485
Review URL: https://codereview.chromium.org/146823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246971 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/quic/reliable_quic_stream.cc')
| -rw-r--r-- | net/quic/reliable_quic_stream.cc | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc index fc11f0b..b9c3a77 100644 --- a/net/quic/reliable_quic_stream.cc +++ b/net/quic/reliable_quic_stream.cc @@ -118,8 +118,15 @@ QuicVersion ReliableQuicStream::version() { } void ReliableQuicStream::WriteOrBufferData(StringPiece data, bool fin) { - DCHECK(data.size() > 0 || fin); - DCHECK(!fin_buffered_); + if (data.empty() && !fin) { + LOG(DFATAL) << "data.empty() && !fin"; + return; + } + + if (fin_buffered_) { + LOG(DFATAL) << "Fin already buffered"; + return; + } QuicConsumedData consumed_data(0, false); fin_buffered_ = fin; |