diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
| commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
| tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /net/server | |
| parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
| download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 | |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/server')
| -rw-r--r-- | net/server/http_server.cc | 2 | ||||
| -rw-r--r-- | net/server/http_server_request_info.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/server/http_server.cc b/net/server/http_server.cc index 4f1fb08..a0c9a3a 100644 --- a/net/server/http_server.cc +++ b/net/server/http_server.cc @@ -62,7 +62,7 @@ void HttpServer::Send200(int connection_id, } void HttpServer::Send404(int connection_id) { - Send(connection_id, HTTP_NOT_FOUND, "", "text/html"); + Send(connection_id, HTTP_NOT_FOUND, std::string(), "text/html"); } void HttpServer::Send500(int connection_id, const std::string& message) { diff --git a/net/server/http_server_request_info.cc b/net/server/http_server_request_info.cc index eda597a..08b925f 100644 --- a/net/server/http_server_request_info.cc +++ b/net/server/http_server_request_info.cc @@ -16,7 +16,7 @@ std::string HttpServerRequestInfo::GetHeaderValue( headers.find(header_name); if (it != headers.end()) return it->second; - return ""; + return std::string(); } } // namespace net |