diff options
| author | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-20 15:01:16 +0000 |
|---|---|---|
| committer | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-20 15:01:16 +0000 |
| commit | 9f864b3e9d0650004a957035d08357c2bde81b99 (patch) | |
| tree | c373f03088eae4d9688285165877660b814c5b87 /net/socket/client_socket.cc | |
| parent | 5f9a7f97780db19175a8549d39b97f62fa6c9afb (diff) | |
| download | chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.zip chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.tar.gz chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.tar.bz2 | |
Turn GetPeerName into a pure virtual and provide local impls, this way any future bugs like the one referenced are compile time and not runtime so they won't wide waiting to be found.
BUG=32595
TEST=everything builds and tests pass
Review URL: http://codereview.chromium.org/552048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36629 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/client_socket.cc')
| -rw-r--r-- | net/socket/client_socket.cc | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/net/socket/client_socket.cc b/net/socket/client_socket.cc deleted file mode 100644 index a3f204a..0000000 --- a/net/socket/client_socket.cc +++ /dev/null @@ -1,20 +0,0 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "net/socket/client_socket.h" - -#include "base/logging.h" -#include "net/base/net_errors.h" - -namespace net { - -// Identical to BSD socket call getpeername(). -// Needed by ssl_client_socket_nss and ssl_client_socket_mac. -int ClientSocket::GetPeerName(struct sockaddr* name, socklen_t* namelen) { - // Default implementation just permits some unit tests to link. - NOTREACHED(); - return ERR_UNEXPECTED; -} - -} // namespace net |