diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 02:22:52 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 02:22:52 +0000 |
| commit | d5a30959562915bfefe907265ca17174c7aedfc6 (patch) | |
| tree | fe90d9bf4e893aa2451f63b2d82c625734293834 /net/socket/socks5_client_socket_unittest.cc | |
| parent | 39cd64ed4d4cf04df49c1f64e40019e9675dbba7 (diff) | |
| download | chromium_src-d5a30959562915bfefe907265ca17174c7aedfc6.zip chromium_src-d5a30959562915bfefe907265ca17174c7aedfc6.tar.gz chromium_src-d5a30959562915bfefe907265ca17174c7aedfc6.tar.bz2 | |
Add specific error codes for when SOCKS connect fails.
This also fixes HttpNetworkTransaction to fallback to the next proxy after a failure is encountered using a SOCKS proxy server.
Note that I decided against using finer granularity error codes, since it just adds a higher maintenance cost to ReconsiderProxyAfterError().
Power users can get better information on the cause of the failure by looking at the LoadLog anyway.
BUG=34386
Review URL: http://codereview.chromium.org/567030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38170 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/socks5_client_socket_unittest.cc')
| -rw-r--r-- | net/socket/socks5_client_socket_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/socket/socks5_client_socket_unittest.cc b/net/socket/socks5_client_socket_unittest.cc index b4eb2cf..4b87a14 100644 --- a/net/socket/socks5_client_socket_unittest.cc +++ b/net/socket/socks5_client_socket_unittest.cc @@ -204,7 +204,7 @@ TEST_F(SOCKS5ClientSocketTest, LargeHostNameFails) { // the transport socket first) because the hostname is too long. TestCompletionCallback callback; int rv = user_sock_->Connect(&callback, NULL); - EXPECT_EQ(ERR_INVALID_URL, rv); + EXPECT_EQ(ERR_SOCKS_CONNECTION_FAILED, rv); } TEST_F(SOCKS5ClientSocketTest, PartialReadWrites) { |