diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-19 22:45:53 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-19 22:45:53 +0000 |
commit | 61a86c4d5644817d291e7f22ffd0b0b5cef56295 (patch) | |
tree | dfd15e590bbbf44af479f702875d24aa19d1f491 /net/socket/socks_client_socket_pool_unittest.cc | |
parent | 74d7e1d0cb8040ba0bfe15619ccb240e5c7d5c19 (diff) | |
download | chromium_src-61a86c4d5644817d291e7f22ffd0b0b5cef56295.zip chromium_src-61a86c4d5644817d291e7f22ffd0b0b5cef56295.tar.gz chromium_src-61a86c4d5644817d291e7f22ffd0b0b5cef56295.tar.bz2 |
Fix crash on IP address change.
Revert r43908: "Flush socket pools and SPDY session pool properly on explicit requests and network changes."
This change was reverted on the 375 branch, but not on trunk.
BUG=41190
Review URL: http://codereview.chromium.org/1604045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44973 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/socks_client_socket_pool_unittest.cc')
-rw-r--r-- | net/socket/socks_client_socket_pool_unittest.cc | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/net/socket/socks_client_socket_pool_unittest.cc b/net/socket/socks_client_socket_pool_unittest.cc index cef7ff6..4291f3c 100644 --- a/net/socket/socks_client_socket_pool_unittest.cc +++ b/net/socket/socks_client_socket_pool_unittest.cc @@ -10,6 +10,7 @@ #include "base/compiler_specific.h" #include "base/time.h" #include "net/base/mock_host_resolver.h" +#include "net/base/mock_network_change_notifier.h" #include "net/base/net_errors.h" #include "net/base/test_completion_callback.h" #include "net/socket/client_socket_factory.h" @@ -83,9 +84,10 @@ class MockTCPClientSocketPool : public TCPClientSocketPool { MockTCPClientSocketPool(int max_sockets, int max_sockets_per_group, const std::string& name, - ClientSocketFactory* socket_factory) + ClientSocketFactory* socket_factory, + NetworkChangeNotifier* network_change_notifier) : TCPClientSocketPool(max_sockets, max_sockets_per_group, name, - NULL, NULL), + NULL, NULL, network_change_notifier), client_socket_factory_(socket_factory), release_count_(0), cancel_count_(0) {} @@ -169,12 +171,11 @@ class SOCKSClientSocketPoolTest : public ClientSocketPoolTest { : ignored_tcp_socket_params_("proxy", 80, MEDIUM, GURL(), false), tcp_socket_pool_(new MockTCPClientSocketPool( kMaxSockets, kMaxSocketsPerGroup, "MockTCP", - &tcp_client_socket_factory_)), + &tcp_client_socket_factory_, &tcp_notifier_)), ignored_socket_params_(ignored_tcp_socket_params_, true, "host", 80, MEDIUM, GURL()), - pool_(new SOCKSClientSocketPool( - kMaxSockets, kMaxSocketsPerGroup, - "SOCKSUnitTest", NULL, tcp_socket_pool_.get())) { + pool_(new SOCKSClientSocketPool(kMaxSockets, kMaxSocketsPerGroup, + "SOCKSUnitTest", NULL, tcp_socket_pool_.get(), &socks_notifier_)) { } int StartRequest(const std::string& group_name, RequestPriority priority) { @@ -184,9 +185,11 @@ class SOCKSClientSocketPoolTest : public ClientSocketPoolTest { TCPSocketParams ignored_tcp_socket_params_; MockClientSocketFactory tcp_client_socket_factory_; + MockNetworkChangeNotifier tcp_notifier_; scoped_refptr<MockTCPClientSocketPool> tcp_socket_pool_; SOCKSSocketParams ignored_socket_params_; + MockNetworkChangeNotifier socks_notifier_; scoped_refptr<SOCKSClientSocketPool> pool_; }; |