diff options
author | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-11 01:41:59 +0000 |
---|---|---|
committer | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-11 01:41:59 +0000 |
commit | 5ecc992a4bf8546b21db89901f2d87e8b4ae1a94 (patch) | |
tree | c96fe65384323dee8a3d7c69dec9ae41ffe96801 /net/socket/socks_client_socket_unittest.cc | |
parent | d871f2ede5f2e511fdb621305ceef207f1c9e52d (diff) | |
download | chromium_src-5ecc992a4bf8546b21db89901f2d87e8b4ae1a94.zip chromium_src-5ecc992a4bf8546b21db89901f2d87e8b4ae1a94.tar.gz chromium_src-5ecc992a4bf8546b21db89901f2d87e8b4ae1a94.tar.bz2 |
There was confusion in the mock socket classes due to
overlapping names. The MockSocket is not actually a socket.
It is an interface for fetching data for reads and writes
on a socket. The MockClientSocket and MockTCPClientSocket
are the actual sockets.
Rename MockSocket to SocketDataProvider.
Rename SSLMockSocket to SSLSocketDataProvider.
Update all tests to reflect name change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/384024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31640 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/socks_client_socket_unittest.cc')
-rw-r--r-- | net/socket/socks_client_socket_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/socket/socks_client_socket_unittest.cc b/net/socket/socks_client_socket_unittest.cc index 6b5c0fb..6fb7daf 100644 --- a/net/socket/socks_client_socket_unittest.cc +++ b/net/socket/socks_client_socket_unittest.cc @@ -39,7 +39,7 @@ class SOCKSClientSocketTest : public PlatformTest { ClientSocket* tcp_sock_; TestCompletionCallback callback_; scoped_refptr<MockHostResolver> host_resolver_; - scoped_ptr<MockSocket> mock_socket_; + scoped_ptr<SocketDataProvider> data_; private: DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketTest); @@ -61,8 +61,8 @@ SOCKSClientSocket* SOCKSClientSocketTest::BuildMockSocket( int port) { TestCompletionCallback callback; - mock_socket_.reset(new StaticMockSocket(reads, writes)); - tcp_sock_ = new MockTCPClientSocket(address_list_, mock_socket_.get()); + data_.reset(new StaticSocketDataProvider(reads, writes)); + tcp_sock_ = new MockTCPClientSocket(address_list_, data_.get()); int rv = tcp_sock_->Connect(&callback, NULL); EXPECT_EQ(ERR_IO_PENDING, rv); |