diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-09 16:35:24 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-09 16:35:24 +0000 |
| commit | f906bfeb44b51d2d9016a8d4efe3869ed02ca348 (patch) | |
| tree | 9de9ec83bd6b82ffa7dca56c964a88ea63815cb4 /net/socket/ssl_client_socket_pool.cc | |
| parent | f78a8a90d139a74424bb6e2ed90c67e9dc787878 (diff) | |
| download | chromium_src-f906bfeb44b51d2d9016a8d4efe3869ed02ca348.zip chromium_src-f906bfeb44b51d2d9016a8d4efe3869ed02ca348.tar.gz chromium_src-f906bfeb44b51d2d9016a8d4efe3869ed02ca348.tar.bz2 | |
Add revocation checking field trial.
We wish to measure the impact of revocation checking on SSL connection times.
This change sets up a 50/50 field trial where members of the trial don't do
revocation checking on sites that we currently have certificate pins for.
BUG=none
TEST=none
http://codereview.chromium.org/7113008/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88542 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/ssl_client_socket_pool.cc')
| -rw-r--r-- | net/socket/ssl_client_socket_pool.cc | 35 |
1 files changed, 27 insertions, 8 deletions
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc index 33c7e8b..565e064 100644 --- a/net/socket/ssl_client_socket_pool.cc +++ b/net/socket/ssl_client_socket_pool.cc @@ -329,19 +329,38 @@ int SSLConnectJob::DoSSLConnectComplete(int result) { base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10), 100); - } else { - UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency", + } + + UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency", + connect_duration, + base::TimeDelta::FromMilliseconds(1), + base::TimeDelta::FromMinutes(10), + 100); + + const std::string& host = params_->host_and_port().host(); + bool is_google = host == "google.com" || + (host.size() > 11 && + host.rfind(".google.com") == host.size() - 11); + if (is_google) { + UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google", connect_duration, base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10), 100); - const std::string& host = params_->host_and_port().host(); - bool is_google = host == "google.com" || - (host.size() > 11 && - host.rfind(".google.com") == host.size() - 11); - if (is_google) { - UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google", + base::FieldTrial* trial = base::FieldTrialList::Find("RevCheckingImpact"); + if (trial) { + std::string histogram_name; + if (trial->group() != base::FieldTrial::kDefaultGroupNumber || + !params_->ssl_config().rev_checking_enabled) { + histogram_name = + "Net.SSL_Connection_Latency_Google_No_Revocation_Checking"; + } else { + histogram_name = + "Net.SSL_Connection_Latency_Google_Revocation_Checking"; + } + + UMA_HISTOGRAM_CUSTOM_TIMES(histogram_name, connect_duration, base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10), |