diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 18:21:14 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 18:21:14 +0000 |
| commit | e05c55d4aa4b1e8698f4d013c7ad4899fa9f933c (patch) | |
| tree | 949cf8184e8c47cada0016358498ab4f61fc52dc /net/socket/ssl_client_socket_win.cc | |
| parent | 9f75d561e947566e2d3b75e811fba8a7bd7f2085 (diff) | |
| download | chromium_src-e05c55d4aa4b1e8698f4d013c7ad4899fa9f933c.zip chromium_src-e05c55d4aa4b1e8698f4d013c7ad4899fa9f933c.tar.gz chromium_src-e05c55d4aa4b1e8698f4d013c7ad4899fa9f933c.tar.bz2 | |
Initialize 'processed' to 0 before passing its address to SSLRead or
SSLWrite.
Ignore errSSLClosedNoNotify for site compatibility, even though it
makes us potentially vulnerable to truncation attacks.
Replace the default ERR_FAILED error code with the more specific
ERR_SSL_PROTOCOL_ERROR.
R=avi
BUG=http://crbug.com/16758
TEST=see bug 16758 for a test case.
Review URL: http://codereview.chromium.org/165025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22626 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/ssl_client_socket_win.cc')
| -rw-r--r-- | net/socket/ssl_client_socket_win.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/socket/ssl_client_socket_win.cc b/net/socket/ssl_client_socket_win.cc index 86412d5..fba04ea 100644 --- a/net/socket/ssl_client_socket_win.cc +++ b/net/socket/ssl_client_socket_win.cc @@ -928,9 +928,9 @@ int SSLClientSocketWin::DoPayloadReadComplete(int result) { if (result == 0 && !ignore_ok_result_) { // TODO(wtc): Unless we have received the close_notify alert, we need to // return an error code indicating that the SSL connection ended - // uncleanly, a potential truncation attack. + // uncleanly, a potential truncation attack. See http://crbug.com/18586. if (bytes_received_ != 0) - return ERR_FAILED; + return ERR_SSL_PROTOCOL_ERROR; return OK; } |