diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-27 23:20:45 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-27 23:20:45 +0000 |
| commit | d13f51bc832e8e7965e92f5aa4b16b8c10c3f913 (patch) | |
| tree | d5a1a413bf8716befbae7d056cd8c6194eed5a98 /net/socket/tcp_client_socket_pool.cc | |
| parent | f2286c23e17c0012d53800a5ef28975b6e22393a (diff) | |
| download | chromium_src-d13f51bc832e8e7965e92f5aa4b16b8c10c3f913.zip chromium_src-d13f51bc832e8e7965e92f5aa4b16b8c10c3f913.tar.gz chromium_src-d13f51bc832e8e7965e92f5aa4b16b8c10c3f913.tar.bz2 | |
Cleanup: Address some of the todos in net_log.h
- Get rid of the AddString() and AddStringLiteral() methods.
- Make EventParameters able to serialize to JSON, instead of a string.
BUG=37421
Review URL: http://codereview.chromium.org/1716007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45750 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/tcp_client_socket_pool.cc')
| -rw-r--r-- | net/socket/tcp_client_socket_pool.cc | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/net/socket/tcp_client_socket_pool.cc b/net/socket/tcp_client_socket_pool.cc index 5cf1fa1..ed75d0e 100644 --- a/net/socket/tcp_client_socket_pool.cc +++ b/net/socket/tcp_client_socket_pool.cc @@ -200,9 +200,13 @@ int TCPClientSocketPool::RequestSocket( static_cast<const TCPSocketParams*>(params); if (net_log.HasListener()) { - net_log.AddString(StringPrintf("Requested TCP socket to: %s [port %d]", - casted_params->destination().hostname().c_str(), - casted_params->destination().port())); + // TODO(eroman): Split out the host and port parameters. + net_log.AddEventWithString( + NetLog::TYPE_TCP_CLIENT_SOCKET_POOL_REQUESTED_SOCKET, + "host_and_port", + StringPrintf("%s [port %d]", + casted_params->destination().hostname().c_str(), + casted_params->destination().port())); } return base_.RequestSocket(group_name, *casted_params, priority, handle, |