summaryrefslogtreecommitdiffstats
path: root/net/socket/tcp_client_socket_pool_unittest.cc
diff options
context:
space:
mode:
authorthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-20 15:01:16 +0000
committerthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-20 15:01:16 +0000
commit9f864b3e9d0650004a957035d08357c2bde81b99 (patch)
treec373f03088eae4d9688285165877660b814c5b87 /net/socket/tcp_client_socket_pool_unittest.cc
parent5f9a7f97780db19175a8549d39b97f62fa6c9afb (diff)
downloadchromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.zip
chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.tar.gz
chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.tar.bz2
Turn GetPeerName into a pure virtual and provide local impls, this way any future bugs like the one referenced are compile time and not runtime so they won't wide waiting to be found.
BUG=32595 TEST=everything builds and tests pass Review URL: http://codereview.chromium.org/552048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36629 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/tcp_client_socket_pool_unittest.cc')
-rw-r--r--net/socket/tcp_client_socket_pool_unittest.cc9
1 files changed, 9 insertions, 0 deletions
diff --git a/net/socket/tcp_client_socket_pool_unittest.cc b/net/socket/tcp_client_socket_pool_unittest.cc
index 8aa9ea0..500725a 100644
--- a/net/socket/tcp_client_socket_pool_unittest.cc
+++ b/net/socket/tcp_client_socket_pool_unittest.cc
@@ -42,6 +42,9 @@ class MockClientSocket : public ClientSocket {
virtual bool IsConnectedAndIdle() const {
return connected_;
}
+ virtual int GetPeerName(struct sockaddr* name, socklen_t* namelen) {
+ return ERR_UNEXPECTED;
+ }
// Socket methods:
virtual int Read(IOBuffer* buf, int buf_len,
@@ -76,6 +79,9 @@ class MockFailingClientSocket : public ClientSocket {
virtual bool IsConnectedAndIdle() const {
return false;
}
+ virtual int GetPeerName(struct sockaddr* name, socklen_t* namelen) {
+ return ERR_UNEXPECTED;
+ }
// Socket methods:
virtual int Read(IOBuffer* buf, int buf_len,
@@ -115,6 +121,9 @@ class MockPendingClientSocket : public ClientSocket {
virtual bool IsConnectedAndIdle() const {
return is_connected_;
}
+ virtual int GetPeerName(struct sockaddr* name, socklen_t* namelen) {
+ return ERR_UNEXPECTED;
+ }
// Socket methods:
virtual int Read(IOBuffer* buf, int buf_len,