diff options
author | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-12 00:25:12 +0000 |
---|---|---|
committer | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-12 00:25:12 +0000 |
commit | ec08bb23238e41b66daa676c3c55f23544a0de14 (patch) | |
tree | aef939a8d5cccb67d037d8d055380a82e95bbfaa /net/socket/tcp_client_socket_pool_unittest.cc | |
parent | db471b330fc82a9f450807ec1f4307c29dda23c4 (diff) | |
download | chromium_src-ec08bb23238e41b66daa676c3c55f23544a0de14.zip chromium_src-ec08bb23238e41b66daa676c3c55f23544a0de14.tar.gz chromium_src-ec08bb23238e41b66daa676c3c55f23544a0de14.tar.bz2 |
Add a "LoadLog" parameter to transactions, hostresolver, clientsocketpool and proyxservice.This dependency comes from the parent URLRequest, and is used as a container for per-request profiling data.This change is strictly a no-op refactor -- the parameter is unused, and LoadLog does nothing.BUG=http://crbug.com/14478TEST=none -- just needs to compile and pass existing tests.DESIGN=<http://docs.google.com/Doc?id=dfhcnb2v_21gbtrcpr3&hl=en>
Review URL: http://codereview.chromium.org/126303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23127 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/tcp_client_socket_pool_unittest.cc')
-rw-r--r-- | net/socket/tcp_client_socket_pool_unittest.cc | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/net/socket/tcp_client_socket_pool_unittest.cc b/net/socket/tcp_client_socket_pool_unittest.cc index ad7cb16..649790a 100644 --- a/net/socket/tcp_client_socket_pool_unittest.cc +++ b/net/socket/tcp_client_socket_pool_unittest.cc @@ -209,7 +209,7 @@ TEST_F(TCPClientSocketPoolTest, Basic) { TestCompletionCallback callback; ClientSocketHandle handle(pool_.get()); HostResolver::RequestInfo info("www.google.com", 80); - int rv = handle.Init("a", info, 0, &callback); + int rv = handle.Init(NULL, "a", info, 0, &callback); EXPECT_EQ(ERR_IO_PENDING, rv); EXPECT_FALSE(handle.is_initialized()); EXPECT_FALSE(handle.socket()); @@ -226,7 +226,7 @@ TEST_F(TCPClientSocketPoolTest, InitHostResolutionFailure) { TestSocketRequest req(pool_.get(), &request_order_, &completion_count_); HostResolver::RequestInfo info("unresolvable.host.name", 80); EXPECT_EQ(ERR_IO_PENDING, - req.handle()->Init("a", info, kDefaultPriority, &req)); + req.handle()->Init(NULL, "a", info, kDefaultPriority, &req)); EXPECT_EQ(ERR_NAME_NOT_RESOLVED, req.WaitForResult()); } @@ -236,13 +236,13 @@ TEST_F(TCPClientSocketPoolTest, InitConnectionFailure) { TestSocketRequest req(pool_.get(), &request_order_, &completion_count_); HostResolver::RequestInfo info("a", 80); EXPECT_EQ(ERR_IO_PENDING, - req.handle()->Init("a", info, kDefaultPriority, &req)); + req.handle()->Init(NULL, "a", info, kDefaultPriority, &req)); EXPECT_EQ(ERR_CONNECTION_FAILED, req.WaitForResult()); // Make the host resolutions complete synchronously this time. host_resolver_->set_synchronous_mode(true); EXPECT_EQ(ERR_CONNECTION_FAILED, - req.handle()->Init("a", info, kDefaultPriority, &req)); + req.handle()->Init(NULL, "a", info, kDefaultPriority, &req)); } TEST_F(TCPClientSocketPoolTest, PendingRequests) { @@ -348,7 +348,7 @@ TEST_F(TCPClientSocketPoolTest, CancelRequestClearGroup) { TestSocketRequest req(pool_.get(), &request_order_, &completion_count_); HostResolver::RequestInfo info("www.google.com", 80); EXPECT_EQ(ERR_IO_PENDING, - req.handle()->Init("a", info, kDefaultPriority, &req)); + req.handle()->Init(NULL, "a", info, kDefaultPriority, &req)); req.handle()->Reset(); PlatformThread::Sleep(100); @@ -367,9 +367,9 @@ TEST_F(TCPClientSocketPoolTest, TwoRequestsCancelOne) { HostResolver::RequestInfo info("www.google.com", 80); EXPECT_EQ(ERR_IO_PENDING, - req.handle()->Init("a", info, kDefaultPriority, &req)); + req.handle()->Init(NULL, "a", info, kDefaultPriority, &req)); EXPECT_EQ(ERR_IO_PENDING, - req2.handle()->Init("a", info, kDefaultPriority, &req2)); + req2.handle()->Init(NULL, "a", info, kDefaultPriority, &req2)); req.handle()->Reset(); @@ -385,12 +385,14 @@ TEST_F(TCPClientSocketPoolTest, ConnectCancelConnect) { TestSocketRequest req(pool_.get(), &request_order_, &completion_count_); HostResolver::RequestInfo info("www.google.com", 80); - EXPECT_EQ(ERR_IO_PENDING, handle.Init("a", info, kDefaultPriority, &callback)); + EXPECT_EQ(ERR_IO_PENDING, + handle.Init(NULL, "a", info, kDefaultPriority, &callback)); handle.Reset(); TestCompletionCallback callback2; - EXPECT_EQ(ERR_IO_PENDING, handle.Init("a", info, kDefaultPriority, &callback2)); + EXPECT_EQ(ERR_IO_PENDING, + handle.Init(NULL, "a", info, kDefaultPriority, &callback2)); host_resolver_->set_synchronous_mode(true); // At this point, handle has two ConnectingSockets out for it. Due to the @@ -479,8 +481,8 @@ class RequestSocketCallback : public CallbackRunner< Tuple1<int> > { if (!within_callback_) { handle_->Reset(); within_callback_ = true; - int rv = handle_->Init( - "a", HostResolver::RequestInfo("www.google.com", 80), 0, this); + int rv = handle_->Init(NULL, "a", + HostResolver::RequestInfo("www.google.com", 80), 0, this); EXPECT_EQ(OK, rv); } } @@ -498,8 +500,8 @@ class RequestSocketCallback : public CallbackRunner< Tuple1<int> > { TEST_F(TCPClientSocketPoolTest, RequestTwice) { ClientSocketHandle handle(pool_.get()); RequestSocketCallback callback(&handle); - int rv = handle.Init( - "a", HostResolver::RequestInfo("www.google.com", 80), 0, &callback); + int rv = handle.Init(NULL, "a", + HostResolver::RequestInfo("www.google.com", 80), 0, &callback); ASSERT_EQ(ERR_IO_PENDING, rv); // The callback is going to request "www.google.com". We want it to complete |