summaryrefslogtreecommitdiffstats
path: root/net/socket/tcp_client_socket_win.h
diff options
context:
space:
mode:
authorjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-25 20:29:45 +0000
committerjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-25 20:29:45 +0000
commit9b5614aec311bc0d04416b1fa279e496cca84714 (patch)
treeef89c857a897d45a8540aa0a84252a4a9329b83a /net/socket/tcp_client_socket_win.h
parent4055f9a6cd7de30e99288aa1f51b42276a93e705 (diff)
downloadchromium_src-9b5614aec311bc0d04416b1fa279e496cca84714.zip
chromium_src-9b5614aec311bc0d04416b1fa279e496cca84714.tar.gz
chromium_src-9b5614aec311bc0d04416b1fa279e496cca84714.tar.bz2
Gather preconnection use vs waste statistics
I now gather statistics only in the transport socket classes TcpClientSocket*. All other socket classes forward significant data (that they are used in a speculation) to their transport class, where this data is stored, and then dumped when the TCP socket is closed. This CL also repaired a slight miscount in bytes read and written on Windows, as error codes were mistakenly accumulated as byte counts. This CL repaired a significant undercounting in linux/mac via StatsCounter (the logging counter appears correct). Libjingle support is minimal (NOTREACHED), but I don't know that there are subresources that will be speculatively preconnected from that class (and it is less obvious how the class uses underlying sockets, if at all). BUG=42694 r=willchan Review URL: http://codereview.chromium.org/3163033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57377 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/tcp_client_socket_win.h')
-rw-r--r--net/socket/tcp_client_socket_win.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/net/socket/tcp_client_socket_win.h b/net/socket/tcp_client_socket_win.h
index 8940978..bd31960 100644
--- a/net/socket/tcp_client_socket_win.h
+++ b/net/socket/tcp_client_socket_win.h
@@ -28,7 +28,7 @@ class TCPClientSocketWin : public ClientSocket, NonThreadSafe {
net::NetLog* net_log,
const net::NetLog::Source& source);
- ~TCPClientSocketWin();
+ virtual ~TCPClientSocketWin();
// ClientSocket methods:
virtual int Connect(CompletionCallback* callback);
@@ -37,6 +37,8 @@ class TCPClientSocketWin : public ClientSocket, NonThreadSafe {
virtual bool IsConnectedAndIdle() const;
virtual int GetPeerAddress(AddressList* address) const;
virtual const BoundNetLog& NetLog() const { return net_log_; }
+ virtual void SetSubresourceSpeculation();
+ virtual void SetOmniboxSpeculation();
// Socket methods:
// Multiple outstanding requests are not supported.
@@ -114,6 +116,10 @@ class TCPClientSocketWin : public ClientSocket, NonThreadSafe {
BoundNetLog net_log_;
+ // Record of connectivity and transmissions, for use in speculative connection
+ // histograms.
+ UseHistory use_history_;
+
DISALLOW_COPY_AND_ASSIGN(TCPClientSocketWin);
};