diff options
author | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-27 20:07:36 +0000 |
---|---|---|
committer | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-27 20:07:36 +0000 |
commit | 817498d34ca487bd6c8791ed8efa104b2ab38ebf (patch) | |
tree | f86c17561b68ba43118f77e359868dfcba7c3897 /net/socket/tcp_server_socket_win.cc | |
parent | 5407bb916f12047a2186c92b896f81a1e588db06 (diff) | |
download | chromium_src-817498d34ca487bd6c8791ed8efa104b2ab38ebf.zip chromium_src-817498d34ca487bd6c8791ed8efa104b2ab38ebf.tar.gz chromium_src-817498d34ca487bd6c8791ed8efa104b2ab38ebf.tar.bz2 |
Revert 87077 - Bind() methods for TCP sockets
BUG=80245
TEST=None
Review URL: http://codereview.chromium.org/7004055
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7082013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87079 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/tcp_server_socket_win.cc')
-rw-r--r-- | net/socket/tcp_server_socket_win.cc | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/net/socket/tcp_server_socket_win.cc b/net/socket/tcp_server_socket_win.cc index 55c2439..a850a8a 100644 --- a/net/socket/tcp_server_socket_win.cc +++ b/net/socket/tcp_server_socket_win.cc @@ -46,7 +46,7 @@ int TCPServerSocketWin::Listen(const IPEndPoint& address, int backlog) { return ERR_FAILED; } - socket_ = socket(address.GetFamily(), SOCK_STREAM, IPPROTO_TCP); + socket_ = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); if (socket_ < 0) { PLOG(ERROR) << "socket() returned an error"; return MapSystemError(WSAGetLastError()); @@ -126,8 +126,8 @@ int TCPServerSocketWin::AcceptInternal(scoped_ptr<StreamSocket>* socket) { socklen_t addr_len = sizeof(addr_storage); struct sockaddr* addr = reinterpret_cast<struct sockaddr*>(&addr_storage); - int new_socket = accept(socket_, addr, &addr_len); - if (new_socket < 0) { + int result = accept(socket_, addr, &addr_len); + if (result < 0) { int net_error = MapSystemError(WSAGetLastError()); if (net_error != ERR_IO_PENDING) net_log_.EndEventWithNetErrorCode(NetLog::TYPE_TCP_ACCEPT, net_error); @@ -137,22 +137,16 @@ int TCPServerSocketWin::AcceptInternal(scoped_ptr<StreamSocket>* socket) { IPEndPoint address; if (!address.FromSockAddr(addr, addr_len)) { NOTREACHED(); - if (closesocket(new_socket) < 0) + if (closesocket(result) < 0) PLOG(ERROR) << "closesocket"; net_log_.EndEventWithNetErrorCode(NetLog::TYPE_TCP_ACCEPT, ERR_FAILED); return ERR_FAILED; } - scoped_ptr<TCPClientSocket> tcp_socket(new TCPClientSocket( + TCPClientSocket* tcp_socket = new TCPClientSocket( AddressList::CreateFromIPAddress(address.address(), address.port()), - net_log_.net_log(), net_log_.source())); - int adopt_result = tcp_socket->AdoptSocket(new_socket); - if (adopt_result != OK) { - if (closesocket(new_socket) < 0) - PLOG(ERROR) << "closesocket"; - net_log_.EndEventWithNetErrorCode(NetLog::TYPE_TCP_ACCEPT, adopt_result); - return adopt_result; - } - socket->reset(tcp_socket.release()); + net_log_.net_log(), net_log_.source()); + tcp_socket->AdoptSocket(result); + socket->reset(tcp_socket); net_log_.EndEvent(NetLog::TYPE_TCP_ACCEPT, make_scoped_refptr(new NetLogStringParameter( "address", address.ToString()))); |