diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-27 15:38:07 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-27 15:38:07 +0000 |
| commit | f55bd486ab0ada0402fdcd34fb70a20d155fd968 (patch) | |
| tree | 1eb9cf7c078d40c20320126d34f4cc4694082b1f /net/socket | |
| parent | 4b0bd5f4c2d58c1620b49628be68f877928025fd (diff) | |
| download | chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.zip chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.tar.gz chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket')
| -rw-r--r-- | net/socket/tcp_client_socket_win.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/socket/tcp_client_socket_win.cc b/net/socket/tcp_client_socket_win.cc index 7c6f41d..c663992 100644 --- a/net/socket/tcp_client_socket_win.cc +++ b/net/socket/tcp_client_socket_win.cc @@ -508,7 +508,7 @@ int TCPClientSocketWin::Read(IOBuffer* buf, core_->read_buffer_.buf = buf->data(); // TODO(wtc): Remove the CHECK after enough testing. - CHECK_EQ(WAIT_TIMEOUT, + CHECK_EQ(static_cast<DWORD>(WAIT_TIMEOUT), WaitForSingleObject(core_->read_overlapped_.hEvent, 0)); DWORD num, flags = 0; int rv = WSARecv(socket_, &core_->read_buffer_, 1, &num, &flags, @@ -558,7 +558,7 @@ int TCPClientSocketWin::Write(IOBuffer* buf, core_->write_buffer_length_ = buf_len; // TODO(wtc): Remove the CHECK after enough testing. - CHECK_EQ(WAIT_TIMEOUT, + CHECK_EQ(static_cast<DWORD>(WAIT_TIMEOUT), WaitForSingleObject(core_->write_overlapped_.hEvent, 0)); DWORD num; int rv = WSASend(socket_, &core_->write_buffer_, 1, &num, 0, |