diff options
| author | jgraettinger@chromium.org <jgraettinger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-25 05:42:05 +0000 |
|---|---|---|
| committer | jgraettinger@chromium.org <jgraettinger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-25 05:42:05 +0000 |
| commit | 53669f6067d653bd701a145e0bde26edfa074605 (patch) | |
| tree | 6e0cb51106b8ee6a1a421ac24f51794474527b07 /net/spdy/buffered_spdy_framer.cc | |
| parent | 1214b853e84214f7e908a61272eefebe82b7303d (diff) | |
| download | chromium_src-53669f6067d653bd701a145e0bde26edfa074605.zip chromium_src-53669f6067d653bd701a145e0bde26edfa074605.tar.gz chromium_src-53669f6067d653bd701a145e0bde26edfa074605.tar.bz2 | |
Implements the ACK flag for SPDY4/HTTP2 PING frames
This lands server change 61378132 by birenroy.
Also update SpdySession, BufferedSpdyFramer, etc to accept and pass
the |is_ack| flag.
BUG=345769
Review URL: https://codereview.chromium.org/169283012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253088 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/spdy/buffered_spdy_framer.cc')
| -rw-r--r-- | net/spdy/buffered_spdy_framer.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/net/spdy/buffered_spdy_framer.cc b/net/spdy/buffered_spdy_framer.cc index 7d419ba..3ac24d0 100644 --- a/net/spdy/buffered_spdy_framer.cc +++ b/net/spdy/buffered_spdy_framer.cc @@ -186,8 +186,8 @@ void BufferedSpdyFramer::OnSetting(SpdySettingsIds id, visitor_->OnSetting(id, flags, value); } -void BufferedSpdyFramer::OnPing(SpdyPingId unique_id) { - visitor_->OnPing(unique_id); +void BufferedSpdyFramer::OnPing(SpdyPingId unique_id, bool is_ack) { + visitor_->OnPing(unique_id, is_ack); } void BufferedSpdyFramer::OnRstStream(SpdyStreamId stream_id, @@ -295,8 +295,10 @@ SpdyFrame* BufferedSpdyFramer::CreateSettings( } // TODO(jgraettinger): Eliminate uses of this method (prefer SpdyPingIR). -SpdyFrame* BufferedSpdyFramer::CreatePingFrame(uint32 unique_id) const { +SpdyFrame* BufferedSpdyFramer::CreatePingFrame(uint32 unique_id, + bool is_ack) const { SpdyPingIR ping_ir(unique_id); + ping_ir.set_is_ack(is_ack); return spdy_framer_.SerializePing(ping_ir); } |