summaryrefslogtreecommitdiffstats
path: root/net/spdy/spdy_proxy_client_socket.cc
diff options
context:
space:
mode:
authorakalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-17 19:23:49 +0000
committerakalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-17 19:23:49 +0000
commit09a8d917eb7bc6b45277b24a851ccec6e8e499a9 (patch)
treeabeb2c359417e5681f241c0d8eba10ceacc69aa1 /net/spdy/spdy_proxy_client_socket.cc
parent15c709e5127e3fd3c27b4bd2ac7d642608582f23 (diff)
downloadchromium_src-09a8d917eb7bc6b45277b24a851ccec6e8e499a9.zip
chromium_src-09a8d917eb7bc6b45277b24a851ccec6e8e499a9.tar.gz
chromium_src-09a8d917eb7bc6b45277b24a851ccec6e8e499a9.tar.bz2
[SPDY] Avoid leaking bytes from the session flow control receive window
Add a way to add ConsumeCallbacks to a SpdyBuffer in order to be notified when Consume() is called. Use that to ensure that flow control receive windows are updated appropriately regardless of what the SpdyStream's delegate does. Make IncreaseRevWindowSize private in both SpdyStream and SpdySession. BUG=176592 Review URL: https://codereview.chromium.org/14311002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194655 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/spdy/spdy_proxy_client_socket.cc')
-rw-r--r--net/spdy/spdy_proxy_client_socket.cc7
1 files changed, 1 insertions, 6 deletions
diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc
index c09a5bd..245a58b 100644
--- a/net/spdy/spdy_proxy_client_socket.cc
+++ b/net/spdy/spdy_proxy_client_socket.cc
@@ -217,12 +217,7 @@ int SpdyProxyClientSocket::Read(IOBuffer* buf, int buf_len,
}
size_t SpdyProxyClientSocket::PopulateUserReadBuffer(char* data, size_t len) {
- size_t bytes_consumed = read_buffer_queue_.Dequeue(data, len);
-
- if (bytes_consumed > 0 && spdy_stream_)
- spdy_stream_->IncreaseRecvWindowSize(bytes_consumed);
-
- return bytes_consumed;
+ return read_buffer_queue_.Dequeue(data, len);
}
int SpdyProxyClientSocket::Write(IOBuffer* buf, int buf_len,