diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-22 22:34:04 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-22 22:34:04 +0000 |
| commit | 63c8cb0e1d055530f8c29250c68553175f2b1287 (patch) | |
| tree | adc83b98055bbb18655de703cceee1dd2233ee9e /net/spdy/spdy_proxy_client_socket.cc | |
| parent | a25be0da26b666f73d6c0bb6eff716b1adae23d9 (diff) | |
| download | chromium_src-63c8cb0e1d055530f8c29250c68553175f2b1287.zip chromium_src-63c8cb0e1d055530f8c29250c68553175f2b1287.tar.gz chromium_src-63c8cb0e1d055530f8c29250c68553175f2b1287.tar.bz2 | |
[SPDY] Remove SpdyStream::Delegate::OnSendBody()'s return value
Add comment explaining semantics of OnSendBody().
Audit SpdyStream::Delegate implementations to either
comply with those semantics or CHECK-fail.
Strengthen some related checks in SpdyHttpStream.
Fix typo in spdy_stream_spdy3_unittest.cc.
BUG=242288
R=rch@chromium.org
Review URL: https://codereview.chromium.org/15555003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201622 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/spdy/spdy_proxy_client_socket.cc')
| -rw-r--r-- | net/spdy/spdy_proxy_client_socket.cc | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc index 2fcb899..5bc617c 100644 --- a/net/spdy/spdy_proxy_client_socket.cc +++ b/net/spdy/spdy_proxy_client_socket.cc @@ -468,18 +468,17 @@ SpdySendStatus SpdyProxyClientSocket::OnSendHeadersComplete() { return NO_MORE_DATA_TO_SEND; } -int SpdyProxyClientSocket::OnSendBody() { +void SpdyProxyClientSocket::OnSendBody() { // Because we use |spdy_stream_| via STATE_OPEN (ala WebSockets) - // OnSendBody() should never be called. - NOTREACHED(); - return ERR_UNEXPECTED; + // OnSendBody() must never be called. + CHECK(false); } SpdySendStatus SpdyProxyClientSocket::OnSendBodyComplete( size_t /*bytes_sent*/) { // Because we use |spdy_stream_| via STATE_OPEN (ala WebSockets) - // OnSendBodyComplete() should never be called. - NOTREACHED(); + // OnSendBodyComplete() must never be called. + CHECK(false); return NO_MORE_DATA_TO_SEND; } |