diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-05 23:14:12 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-05 23:14:12 +0000 |
| commit | 8ad1c1427d7e5cf404a6d0e90f6235ed6119eae8 (patch) | |
| tree | c2bcf68623cce5b567548e733b25719bd51f53e6 /net/spdy/spdy_session.cc | |
| parent | 097287815ee24b2c8c037da68d2daee15b8feb74 (diff) | |
| download | chromium_src-8ad1c1427d7e5cf404a6d0e90f6235ed6119eae8.zip chromium_src-8ad1c1427d7e5cf404a6d0e90f6235ed6119eae8.tar.gz chromium_src-8ad1c1427d7e5cf404a6d0e90f6235ed6119eae8.tar.bz2 | |
Fix leak in SpdyNetworkTransactionTest.CloseWithActiveStream.
The test case identified a case where previously we hung (we didn't close out
the stream on the now-dead session). With the fix, we closed the streams, but
we didn't remove the session reference, leaving it leaked. The test case did
properly catch this.
BUG=43179
TEST=SpdyNetworkTransactionTest.CloseWithActiveStream.
Review URL: http://codereview.chromium.org/1916004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46518 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/spdy/spdy_session.cc')
| -rw-r--r-- | net/spdy/spdy_session.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc index fc20bd0..f0d0904 100644 --- a/net/spdy/spdy_session.cc +++ b/net/spdy/spdy_session.cc @@ -629,7 +629,7 @@ void SpdySession::ReadSocket() { switch (bytes_read) { case 0: // Socket is closed! - CloseAllStreams(ERR_CONNECTION_CLOSED); + CloseSessionOnError(ERR_CONNECTION_CLOSED); return; case net::ERR_IO_PENDING: // Waiting for data. Nothing to do now. |