diff options
| author | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-12 13:12:04 +0000 |
|---|---|---|
| committer | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-12 13:12:04 +0000 |
| commit | 79cb5c1739afa979cb0d5aa3701f128c6a50dde5 (patch) | |
| tree | 8e46e6ee56d1b0a8b339a358a2418a83f354a436 /net/spdy | |
| parent | 89b1769644f8a140ef663db69156a651422f50db (diff) | |
| download | chromium_src-79cb5c1739afa979cb0d5aa3701f128c6a50dde5.zip chromium_src-79cb5c1739afa979cb0d5aa3701f128c6a50dde5.tar.gz chromium_src-79cb5c1739afa979cb0d5aa3701f128c6a50dde5.tar.bz2 | |
Change AuthChallengeInfo to better represent underlying encodings.
* Use a HostPortPair to indicate the challenger info. This may be a punycode-encoded host.
* scheme is always ASCII encoded and a string
* realm is converted to UTF-16 rather than a wstring. Over the wire this is usually ASCII, can be ISO-8859-1 encoded as it's a quoted string, and could potentially be other encodings as specified by RFC 2047.
BUG=95692
TEST=http://greenbytes.de/tech/tc/httpauth/simplebasicrealmiso88591.asis should display an a with an umlaut.
Review URL: http://codereview.chromium.org/7569015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100676 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/spdy')
| -rw-r--r-- | net/spdy/spdy_network_transaction_unittest.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc index a41a415..5acd830 100644 --- a/net/spdy/spdy_network_transaction_unittest.cc +++ b/net/spdy/spdy_network_transaction_unittest.cc @@ -4927,10 +4927,11 @@ TEST_P(SpdyNetworkTransactionTest, SpdyBasicAuth) { ASSERT_TRUE(response_start->headers != NULL); EXPECT_EQ(401, response_start->headers->response_code()); EXPECT_TRUE(response_start->was_fetched_via_spdy); - ASSERT_TRUE(response_start->auth_challenge.get() != NULL); - EXPECT_FALSE(response_start->auth_challenge->is_proxy); - EXPECT_EQ(L"basic", response_start->auth_challenge->scheme); - EXPECT_EQ(L"MyRealm", response_start->auth_challenge->realm); + AuthChallengeInfo* auth_challenge = response_start->auth_challenge.get(); + ASSERT_TRUE(auth_challenge != NULL); + EXPECT_FALSE(auth_challenge->is_proxy); + EXPECT_EQ("basic", auth_challenge->scheme); + EXPECT_EQ("MyRealm", auth_challenge->realm); // Restart with a username/password. const string16 kFoo(ASCIIToUTF16("foo")); |