diff options
| author | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-05 21:51:05 +0000 |
|---|---|---|
| committer | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-05 21:51:05 +0000 |
| commit | 9d3cd0500b365f511604fcfa70f63cf29242ee5b (patch) | |
| tree | bd366ad6fb28e2397a630c1d4a98f9fb15dd6e0d /net/test/test_server.cc | |
| parent | bbf4467a11440950f05432d3d68495c61e5623c6 (diff) | |
| download | chromium_src-9d3cd0500b365f511604fcfa70f63cf29242ee5b.zip chromium_src-9d3cd0500b365f511604fcfa70f63cf29242ee5b.tar.gz chromium_src-9d3cd0500b365f511604fcfa70f63cf29242ee5b.tar.bz2 | |
Do not enforce pyproto dir for running testserver.
Apparently, the test_server enforces that it can find the generated pyproto
dir before it fires off testserver.py. This is wrong:
- generated pyproto files are not archived, so cannot be used other than on
the builders that build it
- you can get away by just creating an empty pyproto dir, which gives a
false sense of success.
Changed fatal error to warning, and moving on.
BUG=71976
TEST=
Review URL: http://codereview.chromium.org/6368106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73935 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/test/test_server.cc')
| -rw-r--r-- | net/test/test_server.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/test/test_server.cc b/net/test/test_server.cc index fcc7d79a..8f5f3d2 100644 --- a/net/test/test_server.cc +++ b/net/test/test_server.cc @@ -295,8 +295,9 @@ bool TestServer::SetPythonPath() { // Locate the Python code generated by the protocol buffers compiler. FilePath pyproto_code_dir; if (!GetPyProtoPath(&pyproto_code_dir)) { - LOG(ERROR) << "Failed to get python dir for generated code."; - return false; + LOG(WARNING) << "Cannot find pyproto dir for generated code. " + << "Testserver features that rely on it will not work"; + return true; } AppendToPythonPath(pyproto_code_dir); |