Make members of Singleton<T> private and only visible to the singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.

As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.

There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5682008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 2 deletions

diff --git a/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp b/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
index aae8d90..cf2b0cf 100644
--- a/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
+++ b/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
@@ -43,9 +43,9 @@
 #include <secerr.h>
 
 #include "base/crypto/scoped_nss_types.h"
+#include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/nss_util_internal.h"
-#include "base/singleton.h"
 #include "base/string_util.h"
 #include "net/base/net_errors.h"
 #include "net/base/x509_certificate.h"
@@ -252,10 +252,13 @@ class PKCS12InitSingleton {
   }
 };
 
+static base::LazyInstance<PKCS12InitSingleton> g_pkcs12_init_singleton(
+    base::LINKER_INITIALIZED);
+
 }  // namespace
 
 void EnsurePKCS12Init() {
-  Singleton<PKCS12InitSingleton>::get();
+  g_pkcs12_init_singleton.Get();
 }
 
 // Based on nsPKCS12Blob::ImportFromFile.