diff options
author | dcheng <dcheng@chromium.org> | 2014-10-27 14:58:51 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-27 21:59:04 +0000 |
commit | ff0bb8c4fe2ec9f2c2f27f3ffe0afefb986ef666 (patch) | |
tree | 9ea098564d62a2a6047bde7ecf1287e32ea9871d /net/tools/balsa | |
parent | 0a5ed8fe9450d16d1a5a6a9be7a96be2e7179a14 (diff) | |
download | chromium_src-ff0bb8c4fe2ec9f2c2f27f3ffe0afefb986ef666.zip chromium_src-ff0bb8c4fe2ec9f2c2f27f3ffe0afefb986ef666.tar.gz chromium_src-ff0bb8c4fe2ec9f2c2f27f3ffe0afefb986ef666.tar.bz2 |
Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=rch@chromium.org
Review URL: https://codereview.chromium.org/678073004
Cr-Commit-Position: refs/heads/master@{#301457}
Diffstat (limited to 'net/tools/balsa')
-rw-r--r-- | net/tools/balsa/balsa_frame_test.cc | 2 | ||||
-rw-r--r-- | net/tools/balsa/balsa_headers_test.cc | 6 | ||||
-rw-r--r-- | net/tools/balsa/noop_balsa_visitor.h | 65 |
3 files changed, 35 insertions, 38 deletions
diff --git a/net/tools/balsa/balsa_frame_test.cc b/net/tools/balsa/balsa_frame_test.cc index 334f5ef..4a00a66 100644 --- a/net/tools/balsa/balsa_frame_test.cc +++ b/net/tools/balsa/balsa_frame_test.cc @@ -58,7 +58,7 @@ class Visitor : public BalsaVisitorInterface { class BalsaFrameTest : public ::testing::Test { public: - virtual void SetUp() override { + void SetUp() override { frame_.reset(new BalsaFrame); frame_headers_.reset(new BalsaHeaders); visitor_.reset(new Visitor); diff --git a/net/tools/balsa/balsa_headers_test.cc b/net/tools/balsa/balsa_headers_test.cc index b1479c6..3dc8eb3 100644 --- a/net/tools/balsa/balsa_headers_test.cc +++ b/net/tools/balsa/balsa_headers_test.cc @@ -19,7 +19,7 @@ using ::base::StringPiece; class BalsaBufferTest : public ::testing::Test { public: - virtual void SetUp() override { + void SetUp() override { buffer_.reset(new BalsaBuffer); anotherBuffer_.reset(new BalsaBuffer); } @@ -33,9 +33,7 @@ namespace { class BalsaHeadersTest: public ::testing::Test { public: - virtual void SetUp() override { - headers_.reset(new BalsaHeaders); - } + void SetUp() override { headers_.reset(new BalsaHeaders); } protected: scoped_ptr<BalsaHeaders> headers_; diff --git a/net/tools/balsa/noop_balsa_visitor.h b/net/tools/balsa/noop_balsa_visitor.h index c47b0b3..89e9719 100644 --- a/net/tools/balsa/noop_balsa_visitor.h +++ b/net/tools/balsa/noop_balsa_visitor.h @@ -17,39 +17,38 @@ namespace net { class NoOpBalsaVisitor : public BalsaVisitorInterface { public: NoOpBalsaVisitor() { } - virtual ~NoOpBalsaVisitor() { } - - virtual void ProcessBodyInput(const char* input, size_t size) override { } - virtual void ProcessBodyData(const char* input, size_t size) override { } - virtual void ProcessHeaderInput(const char* input, size_t size) override { } - virtual void ProcessTrailerInput(const char* input, size_t size) override { } - virtual void ProcessHeaders(const BalsaHeaders& headers) override { } - - virtual void ProcessRequestFirstLine(const char* line_input, - size_t line_length, - const char* method_input, - size_t method_length, - const char* request_uri_input, - size_t request_uri_length, - const char* version_input, - size_t version_length) override { } - virtual void ProcessResponseFirstLine(const char* line_input, - size_t line_length, - const char* version_input, - size_t version_length, - const char* status_input, - size_t status_length, - const char* reason_input, - size_t reason_length) override { } - virtual void ProcessChunkLength(size_t chunk_length) override { } - virtual void ProcessChunkExtensions(const char* input, size_t size) override { - } - virtual void HeaderDone() override { } - virtual void MessageDone() override { } - virtual void HandleHeaderError(BalsaFrame* framer) override { } - virtual void HandleHeaderWarning(BalsaFrame* framer) override { } - virtual void HandleChunkingError(BalsaFrame* framer) override { } - virtual void HandleBodyError(BalsaFrame* framer) override { } + ~NoOpBalsaVisitor() override {} + + void ProcessBodyInput(const char* input, size_t size) override {} + void ProcessBodyData(const char* input, size_t size) override {} + void ProcessHeaderInput(const char* input, size_t size) override {} + void ProcessTrailerInput(const char* input, size_t size) override {} + void ProcessHeaders(const BalsaHeaders& headers) override {} + + void ProcessRequestFirstLine(const char* line_input, + size_t line_length, + const char* method_input, + size_t method_length, + const char* request_uri_input, + size_t request_uri_length, + const char* version_input, + size_t version_length) override {} + void ProcessResponseFirstLine(const char* line_input, + size_t line_length, + const char* version_input, + size_t version_length, + const char* status_input, + size_t status_length, + const char* reason_input, + size_t reason_length) override {} + void ProcessChunkLength(size_t chunk_length) override {} + void ProcessChunkExtensions(const char* input, size_t size) override {} + void HeaderDone() override {} + void MessageDone() override {} + void HandleHeaderError(BalsaFrame* framer) override {} + void HandleHeaderWarning(BalsaFrame* framer) override {} + void HandleChunkingError(BalsaFrame* framer) override {} + void HandleBodyError(BalsaFrame* framer) override {} private: DISALLOW_COPY_AND_ASSIGN(NoOpBalsaVisitor); |