diff options
| author | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-28 16:01:19 +0000 |
|---|---|---|
| committer | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-28 16:01:19 +0000 |
| commit | 60390d08ca58b164594272e3607604b28dd7016b (patch) | |
| tree | 4672e6587275d54d5c9a66af2c11770996a3b402 /net/tools | |
| parent | a6f0365ee0fc41d58422ccc90e222899d5d90e55 (diff) | |
| download | chromium_src-60390d08ca58b164594272e3607604b28dd7016b.zip chromium_src-60390d08ca58b164594272e3607604b28dd7016b.tar.gz chromium_src-60390d08ca58b164594272e3607604b28dd7016b.tar.bz2 | |
HttpAuthHandlerFactory::CreateDefault requires a HostResolver argument.
Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL.
So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.
BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.
Review URL: http://codereview.chromium.org/3447027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60791 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/tools')
| -rw-r--r-- | net/tools/fetch/fetch_client.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tools/fetch/fetch_client.cc b/net/tools/fetch/fetch_client.cc index 9adf20b..435dc93 100644 --- a/net/tools/fetch/fetch_client.cc +++ b/net/tools/fetch/fetch_client.cc @@ -145,7 +145,7 @@ int main(int argc, char**argv) { net::SSLConfigService::CreateSystemSSLConfigService()); net::HttpTransactionFactory* factory = NULL; scoped_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory( - net::HttpAuthHandlerFactory::CreateDefault()); + net::HttpAuthHandlerFactory::CreateDefault(host_resolver)); if (use_cache) { factory = new net::HttpCache(host_resolver, proxy_service, ssl_config_service, http_auth_handler_factory.get(), NULL, NULL, |