diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-01 22:05:45 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-01 22:05:45 +0000 |
| commit | bc2ff51999fe9ef5c041f2df2ffbbdb4c30baec9 (patch) | |
| tree | 98113aa6f92a67972c0000db1ef6dbd5979f94bd /net/tools | |
| parent | ff0450cc3834b456ab6eb8ee664eb5b98dcecbc0 (diff) | |
| download | chromium_src-bc2ff51999fe9ef5c041f2df2ffbbdb4c30baec9.zip chromium_src-bc2ff51999fe9ef5c041f2df2ffbbdb4c30baec9.tar.gz chromium_src-bc2ff51999fe9ef5c041f2df2ffbbdb4c30baec9.tar.bz2 | |
Implement most of the ridealong fixes/cleanups I suggested during review for enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2395001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/tools')
| -rw-r--r-- | net/tools/dump_cache/cache_dumper.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/tools/dump_cache/cache_dumper.cc b/net/tools/dump_cache/cache_dumper.cc index a2e071a3..47602e6 100644 --- a/net/tools/dump_cache/cache_dumper.cc +++ b/net/tools/dump_cache/cache_dumper.cc @@ -89,10 +89,8 @@ bool DiskDumper::CreateEntry(const std::string& key, #ifdef WIN32_LARGE_FILENAME_SUPPORT entry_ = CreateFileW(file.c_str(), GENERIC_WRITE|GENERIC_READ, 0, 0, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0); - if (entry_ == INVALID_HANDLE_VALUE) { + if (entry_ == INVALID_HANDLE_VALUE) wprintf(L"CreateFileW (%s) failed: %d\n", file.c_str(), GetLastError()); - return false; - } return entry_ != INVALID_HANDLE_VALUE; #else entry_ = file_util::OpenFile(entry_path_, "w+"); @@ -147,7 +145,7 @@ bool DiskDumper::WriteEntry(disk_cache::Entry* entry, int index, int offset, std::string headers; const char *data; - int len; + size_t len; if (index == 0) { // Stream 0 is the headers. net::HttpResponseInfo response_info; bool truncated; |