summaryrefslogtreecommitdiffstats
path: root/net/tools
diff options
context:
space:
mode:
authormmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-06 17:34:53 +0000
committermmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-06 17:34:53 +0000
commitb8dd619aa87b909ca80c2684485b393e03db9dcc (patch)
treeee3326525c1e7d1926851d0cf9009291ad666bf8 /net/tools
parentd60c79650e1be14bb75b25362b2eadd0c76b48ba (diff)
downloadchromium_src-b8dd619aa87b909ca80c2684485b393e03db9dcc.zip
chromium_src-b8dd619aa87b909ca80c2684485b393e03db9dcc.tar.gz
chromium_src-b8dd619aa87b909ca80c2684485b393e03db9dcc.tar.bz2
Revert 70618 - First pass at adding http/backend cache events to the NetLog.
Adds sources and events for ActiveCacheEntry and EntryImpl objects, as well as adding cache read/write events to HttpCacheTransactions. Most new read/write events are only logged when NetLog logging mode is set to log all events. Also, net-internals now merges begin and end events that have parameters, as long as only one of them has parameters. I think this increases readability, at the cost of making it a little more difficult to follow timings with just the "st" values. BUG=59382 TEST=none yet, other than updates to existing tests. Review URL: http://codereview.chromium.org/4067002 TBR=mmenke@chromium.org Review URL: http://codereview.chromium.org/6005015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70619 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/tools')
-rw-r--r--net/tools/crash_cache/crash_cache.cc8
-rw-r--r--net/tools/dump_cache/upgrade.cc4
2 files changed, 6 insertions, 6 deletions
diff --git a/net/tools/crash_cache/crash_cache.cc b/net/tools/crash_cache/crash_cache.cc
index 40c6a41..44672ed 100644
--- a/net/tools/crash_cache/crash_cache.cc
+++ b/net/tools/crash_cache/crash_cache.cc
@@ -135,7 +135,7 @@ int SimpleInsert(const FilePath& path, RankCrashes action,
disk_cache::Backend* cache;
int rv = disk_cache::CreateCacheBackend(net::DISK_CACHE, path, 0, false,
cache_thread->message_loop_proxy(),
- NULL, &cache, &cb);
+ &cache, &cb);
if (cb.GetResult(rv) != net::OK || cache->GetEntryCount())
return GENERIC;
@@ -176,7 +176,7 @@ int SimpleRemove(const FilePath& path, RankCrashes action,
// Use a simple LRU for eviction.
int rv = disk_cache::CreateCacheBackend(net::MEDIA_CACHE, path, 0, false,
cache_thread->message_loop_proxy(),
- NULL, &cache, &cb);
+ &cache, &cb);
if (cb.GetResult(rv) != net::OK || cache->GetEntryCount())
return GENERIC;
@@ -219,7 +219,7 @@ int HeadRemove(const FilePath& path, RankCrashes action,
// Use a simple LRU for eviction.
int rv = disk_cache::CreateCacheBackend(net::MEDIA_CACHE, path, 0, false,
cache_thread->message_loop_proxy(),
- NULL, &cache, &cb);
+ &cache, &cb);
if (cb.GetResult(rv) != net::OK || cache->GetEntryCount())
return GENERIC;
@@ -256,7 +256,7 @@ int LoadOperations(const FilePath& path, RankCrashes action,
// Work with a tiny index table (16 entries).
disk_cache::BackendImpl* cache = new disk_cache::BackendImpl(
- path, 0xf, cache_thread->message_loop_proxy(), NULL);
+ path, 0xf, cache_thread->message_loop_proxy());
if (!cache || !cache->SetMaxSize(0x100000))
return GENERIC;
diff --git a/net/tools/dump_cache/upgrade.cc b/net/tools/dump_cache/upgrade.cc
index fae924c..30fbc8c6 100644
--- a/net/tools/dump_cache/upgrade.cc
+++ b/net/tools/dump_cache/upgrade.cc
@@ -326,7 +326,7 @@ bool MasterSM::DoInit() {
FilePath::FromWStringHack(path_), 0,
false,
cache_thread_.message_loop_proxy(),
- NULL, &cache, &cb);
+ &cache, &cb);
if (cb.GetResult(rv) != net::OK) {
printf("Unable to initialize new files\n");
return false;
@@ -607,7 +607,7 @@ SlaveSM::SlaveSM(const std::wstring& path, HANDLE channel)
FilePath::FromWStringHack(path), 0,
false,
cache_thread_.message_loop_proxy(),
- NULL, &cache, &cb);
+ &cache, &cb);
if (cb.GetResult(rv) != net::OK) {
printf("Unable to open cache files\n");
return;