summaryrefslogtreecommitdiffstats
path: root/net/url_request/url_request.cc
diff options
context:
space:
mode:
authormpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-08 22:44:04 +0000
committermpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-08 22:44:04 +0000
commit0a3ab50df3145e4593c9e9b4e54103b2105e8e10 (patch)
treeeb259a08b02daf9d8597b6fbf6d072cbe4cb58f3 /net/url_request/url_request.cc
parentc70e946a98b9f74f38ed78993cc9c49a30e7fa2b (diff)
downloadchromium_src-0a3ab50df3145e4593c9e9b4e54103b2105e8e10.zip
chromium_src-0a3ab50df3145e4593c9e9b4e54103b2105e8e10.tar.gz
chromium_src-0a3ab50df3145e4593c9e9b4e54103b2105e8e10.tar.bz2
Fix leak of the onBeforeRequest callback in URLRequest.
TBR=willchan BUG=no TEST=no Review URL: http://codereview.chromium.org/6648010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77354 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request.cc')
-rw-r--r--net/url_request/url_request.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 229611ca..d4c1542 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -362,10 +362,10 @@ void URLRequest::Start() {
if (context_ && context_->network_delegate()) {
before_request_callback_ = new CancelableCompletionCallback<URLRequest>(
- this, &URLRequest::BeforeRequestComplete);
- before_request_callback_->AddRef(); // balanced in BeforeRequestComplete
+ this, &URLRequest::BeforeRequestComplete);
if (context_->network_delegate()->NotifyBeforeURLRequest(
- this, before_request_callback_)) {
+ this, before_request_callback_)) {
+ before_request_callback_->AddRef(); // balanced in BeforeRequestComplete
net_log_.BeginEvent(NetLog::TYPE_URL_REQUEST_BLOCKED_ON_EXTENSION, NULL);
return; // paused
}