diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-09 23:39:40 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-09 23:39:40 +0000 |
| commit | 0dd261c0b9b03c6a8b73327a971968798d8b5109 (patch) | |
| tree | 896850f58919203ca2000067b9783246a2888b83 /net/url_request/url_request.cc | |
| parent | 01f072566696e48e7fc3d77ed978df7c587c14e3 (diff) | |
| download | chromium_src-0dd261c0b9b03c6a8b73327a971968798d8b5109.zip chromium_src-0dd261c0b9b03c6a8b73327a971968798d8b5109.tar.gz chromium_src-0dd261c0b9b03c6a8b73327a971968798d8b5109.tar.bz2 | |
Make sure that URLRequestJob holds a reference to the read IOBuffer rather than just a raw pointer.
Addresses a crash where consumer was passing in a "throw-away" buffer that it didn't hold a reference to.
BUG=46055
Review URL: http://codereview.chromium.org/2908004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52019 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request.cc')
| -rw-r--r-- | net/url_request/url_request.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc index c2a8d28..3198e82 100644 --- a/net/url_request/url_request.cc +++ b/net/url_request/url_request.cc @@ -339,7 +339,7 @@ void URLRequest::DoCancel(int os_error, const net::SSLInfo& ssl_info) { // about being called recursively. } -bool URLRequest::Read(net::IOBuffer* dest, int dest_size, int *bytes_read) { +bool URLRequest::Read(net::IOBuffer* dest, int dest_size, int* bytes_read) { DCHECK(job_); DCHECK(bytes_read); DCHECK(!job_->is_done()); |